Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a584e92d-61cb-6b9c-456b-6cbe40db6518@huawei.com>
Date:   Wed, 19 Oct 2022 15:24:46 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH -next] drivers: soc: ti: mark knav_acc_firmwares as static
To:     Nishanth Menon <nm@ti.com>
CC:     <ssantosh@kernel.org>, <m-karicheri2@ti.com>, <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20220927061951.103450-1-chenjiahao16@huawei.com>
 <20221017221909.ds24hrbivwap5cek@countable>
From:   "chenjiahao (C)" <chenjiahao16@huawei.com>
In-Reply-To: <20221017221909.ds24hrbivwap5cek@countable>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/10/18 6:19, Nishanth Menon 写道:
> On 14:19-20220927, Chen Jiahao wrote:
>> There is a sparse warning shown below:
>>
>> drivers/soc/ti/knav_qmss_queue.c:70:12: warning: symbol
>> 'knav_acc_firmwares' was not declared. Should it be static?
>>
>> Since 'knav_acc_firmwares' is only called within knav_qmss_queue.c,
>> mark it as static to fix the warning.
>>
>> Fixes: 96ee19becc3b ("soc: ti: add firmware file name as part of the driver")
>> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
>> ---
>>   drivers/soc/ti/knav_qmss_queue.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
>> index 92af7d1b6f5b..c466b98a0293 100644
>> --- a/drivers/soc/ti/knav_qmss_queue.c
>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>> @@ -67,7 +67,7 @@ static DEFINE_MUTEX(knav_dev_lock);
>>    * Newest followed by older ones. Search is done from start of the array
>>    * until a firmware file is found.
>>    */
>> -const char *knav_acc_firmwares[] = {"ks2_qmss_pdsp_acc48.bin"};
>> +static const char *knav_acc_firmwares[] = {"ks2_qmss_pdsp_acc48.bin"};
> next-20221017 checkpatch suggests:
>
> static const char * array should probably be static const char * const
>
> Could you check to ensure we are clear here?

Sure, it is safe to mark 'knav_acc_firmwares' as static const char * const.

Thanks for your reminder

>>   
>>   static bool device_ready;
>>   bool knav_qmss_device_ready(void)
>> -- 
>> 2.31.1
>>