Date: Fri, 29 Jun 2007 11:34:51 -0400 (EDT)
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Alexey Dobriyan <adobriyan@sw.ru>
cc: Andrew Morton <akpm@linux-foundation.org>, dhowells@redhat.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch
In-Reply-To: <20070629145821.GA7003@localhost.sw.ru>
Message-ID: <Pine.LNX.4.64.0706291132450.16107@localhost.localdomain>
References: <20070628140921.GA9753@localhost.sw.ru>
 <20070628151257.7a03e81b.akpm@linux-foundation.org>
 <Pine.LNX.4.64.0706290904420.13877@localhost.localdomain>
 <20070629145821.GA7003@localhost.sw.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2013
Lines: 54

On Fri, 29 Jun 2007, Alexey Dobriyan wrote:

> On Fri, Jun 29, 2007 at 09:10:52AM -0400, Robert P. J. Day wrote:

> >   i actually asked about this on either the janitors or newbies
> > list the other day -- one of the early examples from the LDD3
> > device drivers book which built fine all this time suddenly
> > stopped building, until i explicitly included <linux/sched.h> to
> > be able to dereference a pointer to "task_struct":
> >
> > /home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type
> > /home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type
> >
> >   clearly, until now, that header file was being picked up
> > *somewhere*,
>
> from include/linux/mm.h , yes
>
> > but not now.
>
> dammit!
>
> > so i'm guessing there's going to be code all over the place that
> > suddenly needs to add that inclusion of sched.h.
>
> this is the last known to me bit of compile breakage that was caused by
> commit e8edc6e03a5c8562dc70a6d969f732bdb355a7e7 aka
> "[PATCH] Detach sched.h from mm.h"
>
> And after you'll check diffstat and build current kernel for
> different archs yourself, I hope you'll take that "all over the
> place" back.

i didn't mean code *in the kernel* necessarily, merely code
representing out-of-tree loadable drivers that will now need to
include sched.h that didn't need it before.  such as that very example
out of LDD3.

sorry that i wasn't more clear about that.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/