Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933660AbXF2PvK (ORCPT ); Fri, 29 Jun 2007 11:51:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765163AbXF2Puz (ORCPT ); Fri, 29 Jun 2007 11:50:55 -0400 Received: from mail.screens.ru ([213.234.233.54]:32783 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760139AbXF2Puy (ORCPT ); Fri, 29 Jun 2007 11:50:54 -0400 Date: Fri, 29 Jun 2007 19:51:16 +0400 From: Oleg Nesterov To: Alexey Kuznetsov Cc: Ingo Molnar , Jeff Garzik , Linus Torvalds , Steven Rostedt , LKML , Andrew Morton , Thomas Gleixner , Christoph Hellwig , john stultz , "Paul E. McKenney" , Dipankar Sarma , "David S. Miller" , matthew.wilcox@hp.com Subject: Re: [RFC PATCH 0/6] Convert all tasklets to workqueues Message-ID: <20070629155116.GA422@tv-sign.ru> References: <20070622040014.234651401@goodmis.org> <20070622204058.GA11777@elte.hu> <20070622215953.GA22917@elte.hu> <46834BB8.1020007@garzik.org> <20070628092340.GB23566@elte.hu> <20070628143850.GA11780@ms2.inr.ac.ru> <20070628160001.GA15495@elte.hu> <20070629113423.GA9042@ms2.inr.ac.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070629113423.GA9042@ms2.inr.ac.ru> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 25 On 06/29, Alexey Kuznetsov wrote: > > > Just look at the tasklet_disable() logic. > > Do not count this. A slightly off-topic question, tasklet_kill(t) doesn't try to steal t from tasklet_head.list if t was scheduled, but waits until t completes. If I understand correctly, this is because tasklet_head.list is protected by local_irq_save(), and t could be scheduled on another CPU, so we just can't steal it, yes? If we use worqueues, we can change the semantics of tasklet_kill() so that it really cancels an already scheduled tasklet. The question is: would it be the wrong/good change? Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/