Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp900560rwi; Wed, 19 Oct 2022 04:31:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5+Dl/0lChwnss5Afs/W1lEe3C4Z7UWfD27rUQjbg4wHwifOJM/bIqutKWfdlsVS7+AAjPi X-Received: by 2002:a17:906:328c:b0:780:7574:ced2 with SMTP id 12-20020a170906328c00b007807574ced2mr6402486ejw.634.1666179068990; Wed, 19 Oct 2022 04:31:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666179068; cv=none; d=google.com; s=arc-20160816; b=veiDxEu2MupNxFYBx3ATDk9IVl09ND17x7wUsdhikGMTt1zMJxaUiI3JFfSigAikd6 qnk8TFuwaC1QOT4f1AUe8wA6rGd+N9u0DfupIrssFf95MASlzeeocQVBXPTpE+lwWVhb QTnHlSfLMr15uif7oqhVpuwnNo4jxwKp+Kf4tcU1B2OYqCTIBto/oahdUDSxCPFzAPNQ mLCdw4+aBa1JCS8Q8J1WOLtGjk/LL9P2sfr4IMYsp7jFQVEkFzt12erFB+X5JhKVHJcJ dUgYPW+c8FQ+RmTsTrKVE18AG3l3MvNvXKwFIE3uEAxXrglcOs/53gizuNdenZQZbBDp Vqdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g4PC4xOrQIxZ0ydw36JaxPy1FgjMMgTstwR54iH0OOQ=; b=QhCp5T7u1ZL/Rrfe/sH7wNJgIuJTSqrNf2nj/TACG+NqU3d0vV+maNWryrN9P1dUXd viTti8TOLnk0yYbjK0MqTYcMzPfV3uoCtj5CREpUJZ2RJaYTaX6pQimTV2hA6t+BCrSA FmRbWJduf08o0Z4gwt2v9LZNQZbkLN3ALP/EckM7ApU71P895vv5zHK2sLNo7zutJ7Rj 3EDd08JGzgVK/jzY+4sUMkFe/0Lv6Ys1QoeIJHgF5blTGzSoIcao9kFAU86c0TYaQ5Kc 2fCewBJ0/A5hGCZxkObOlE3QYjaZiimWAsQsmfy9NP5k7pIRSf7yBNPFX4GEeMZgAcr1 pYxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nqonhaDo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fk24-20020a056402399800b0045cafc51fbfsi14063646edb.525.2022.10.19.04.30.41; Wed, 19 Oct 2022 04:31:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nqonhaDo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231932AbiJSKjx (ORCPT + 99 others); Wed, 19 Oct 2022 06:39:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232271AbiJSKjF (ORCPT ); Wed, 19 Oct 2022 06:39:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA85110D69E; Wed, 19 Oct 2022 03:18:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A06AB824E0; Wed, 19 Oct 2022 09:15:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7604C433C1; Wed, 19 Oct 2022 09:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666170932; bh=6HicgzDugBOerZVbAxSgXH2xBFYBrHxtY5zu4BuDnVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nqonhaDovym4BaCrV1Gw6FqJVXilEjOwRQpbQRZJUknKhe1nbfwbBXmiPGmtroCJI ReLhR5zzSKhblf6klIFlbPxJG3E4qWzfJNcaF2I4YChFSgCF0BWaG/BmjJnDO+e3+n qG9zndaBjg841Ko4jhZ4e8C68UxfKNUcNEWpYiq8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Hunter , Namhyung Kim , Ian Rogers , Jiri Olsa , Arnaldo Carvalho de Melo Subject: [PATCH 6.0 841/862] perf intel-pt: Fix system_wide dummy event for hybrid Date: Wed, 19 Oct 2022 10:35:28 +0200 Message-Id: <20221019083327.051777058@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Adrian Hunter commit 6cef7dab3e2e5cb23a13569c3880c0532326748c upstream. User space tasks can migrate between CPUs, so when tracing selected CPUs, system-wide sideband is still needed, however evlist->core.has_user_cpus is not set in the hybrid case, so check the target cpu_list instead. Fixes: 7d189cadbeebc778 ("perf intel-pt: Track sideband system-wide when needed") Signed-off-by: Adrian Hunter Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Jiri Olsa Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20221012082259.22394-3-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/arch/x86/util/intel-pt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/perf/arch/x86/util/intel-pt.c +++ b/tools/perf/arch/x86/util/intel-pt.c @@ -871,7 +871,7 @@ static int intel_pt_recording_options(st * User space tasks can migrate between CPUs, so when tracing * selected CPUs, sideband for all CPUs is still needed. */ - need_system_wide_tracking = evlist->core.has_user_cpus && + need_system_wide_tracking = opts->target.cpu_list && !intel_pt_evsel->core.attr.exclude_user; tracking_evsel = evlist__add_aux_dummy(evlist, need_system_wide_tracking);