Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ff2967c-b047-a799-0db9-124a79bb8ded@nvidia.com>
Date:   Wed, 19 Oct 2022 10:48:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2] serial: tegra: Read DMA status before terminating
Content-Language: en-US
To:     Kartik <kkartik@nvidia.com>, ldewangan@nvidia.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        thierry.reding@gmail.com, alan@linux.intel.com, swarren@nvidia.com,
        akhilrajeev@nvidia.com, linux-serial@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1666105086-17326-1-git-send-email-kkartik@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <1666105086-17326-1-git-send-email-kkartik@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHhZd2RDRURFSTlxNjlNZ2pya3J6L0tjY0VnZEo2RFlxTzl4dklndGhkZ2xk?=
 =?utf-8?B?YUZ3amVsalpoelB5WXgwdUo2L2RTWFp2UTZWQ3E3NlJyVkVJelVCWlFBeXNn?=
 =?utf-8?B?ZGQrK2hqOWNvQVJzd3YzWnAyL3h5OGNVQldJY2hwc01Zd2k0MWFZbUpTMkM0?=
 =?utf-8?B?eGNCYURWTXhnMEFCdlY3bVdWMXJpTW4vK0JZQ0pIVDY3MXJXelFzWUZ2SXli?=
 =?utf-8?B?R0hmRDFnYnZjZ1dWRU9iMGduSmRHbWVhd1dZTU0raWg2aWdDWTRhTGlva3Z4?=
 =?utf-8?B?V0JQcmpuSm85TWZZSzdqcWVSMlhWeXF3aHNYY2ZFeDVrbkdhSWNSd3d3U3hD?=
 =?utf-8?B?S3hWcFZJcG1tU2d6MFNxejB4WTg0YzNuaTZzU29LSzRESnFBL0xFYmtjdFgw?=
 =?utf-8?B?ZzUvZHJEcG9CN09Jd0k3VE1JakF3UEJZa2NzLzM1dFpFQnAwZ2hWYkpKd1Rw?=
 =?utf-8?B?ZTZqK21ON2YrZGRUcVdKaWdjQ0FycXVxTVdYUnFtSFFpK2tUOFd4N0x0ZUNh?=
 =?utf-8?B?bVJ2UTIvSkNScjBxZ1U2akRBK1dJL1YzQngycEhzSlMwTEUxdEZjK2tvVzd2?=
 =?utf-8?B?bTlyQytRUzhDbGZsN2xSQlRhVUorSzdHbnA3L0NDT09wek1MTGxLZjJMVnNp?=
 =?utf-8?B?R29MbUd6cXZnbGZkcjRVWDBPb3dzeHFJRnQxOGZyVkZWRWdlWnhMdzVXVWhQ?=
 =?utf-8?B?U0N5aWNLZnZlK0FWUCtibzBjcHZGSlFnQmQ2OENwUGdLUC9YZ1BLdjBhOUU1?=
 =?utf-8?B?dkp3UjBjVlIzbCsrRXAyaUxkOWJXRHhZZUFrYzJ0UmxtbXp6TTZCem9JZFNl?=
 =?utf-8?B?dWFQUFJEUEhNTlcwRkt3dlRVekk0RVArTjFBQnkxSlBZaU4ya0YwcWNmcUFq?=
 =?utf-8?B?ZExpSk1EM0k1UGlQUmtkRlJMTUZuemQ4ZXh0bGlickkvb3A0U2JVVWZUWGxX?=
 =?utf-8?B?UVYzeEx2ZDZ1ZW1kYUlIOHp5NUlNa2dCUHpMcWpUSXNONWVQMHk0WWlMZ1Az?=
 =?utf-8?B?ZUhWb2tKVGdaZFpsSnc0OC9rSVhQa1g0ZVlqZWdCMVdmb3RsK0tXRkgxZkli?=
 =?utf-8?B?WUlVRXpIb2tEdW9rcnc1aFMrYk1PZWlsZFJDSnNGN2pnVnh1bms4aGhMWmpM?=
 =?utf-8?B?eDJXbkRMdkxDemdSNjBGQXl5My9ZU21qQmNOSXNXbHFsRmV2d1ZPL2FsamhQ?=
 =?utf-8?B?dWFMNWE5d2pQdVZIWWU4ZnhpMjR4OTlBTXU1Y2pBOGtQOW9TUTIvREJuWjdW?=
 =?utf-8?B?ZHQyYXkyRnF5RTh4MTNMTFdSRnRlak9QUEY4WDA2b2UzUEtPSXpRVXl3MGJT?=
 =?utf-8?B?ZmdaVkRCNm9neVpFUXhhb2pZMkNoWTlGQklBaUNZbUdzRzdWWlBCWXZTQWox?=
 =?utf-8?B?WFdjOE04MGpkRGV5bTB0Z2lrVTFzTWxyK2NFWVhCQVNEdDB0cnZSekl1QUFD?=
 =?utf-8?B?UHBsdlFwNVU2U3Y3ZmpsMDhZdHYzcktuMTh5MGViSmVZYUlHeWQ3R0RNdU85?=
 =?utf-8?B?cTluNVd4cGt0bkdvbElvMU9iakIrN3VqSFZyYUdiVzArTWtnUUVTb0ZmcmZi?=
 =?utf-8?B?MmNVcXBYZkUyWHVibU8rcmxObFhQYmk4QjROSi8yVXZDemI3VTVPQk9acXBH?=
 =?utf-8?B?WE5vU3laTXdiUUtqMmx5QTdsVW5LRnZSM3hUcmoyWlhoQTRxS0dIR3ErNjFF?=
 =?utf-8?B?eXNsQ3B0Y0c0TEthVEw5alhIUWVwZTY2R3BENXhNUGVDOStkYkcvVStpZVJj?=
 =?utf-8?B?V2VrT3drcGVaMWJhbkNPZWRnK0duRW00ZkJlekluMVJ3UjRkOFkxTStqVU9V?=
 =?utf-8?B?QW1JMGg1dTdkdC9QNHkzcERhZm9RWkQ1REMrVlN3L2plbEpzbGloenhQTmkz?=
 =?utf-8?B?UXZ6V2VOcjFpV2k4TWZLQ0hRZ1dxZFpDWEJSbWZqYlFHYlJBWktReXVSOCs5?=
 =?utf-8?B?RjBlc3lJUXpKd1Y4cGZQL0hIY3RKQVNDVmU2d3VoSkhydFFiTXlYTzZLNHdR?=
 =?utf-8?B?K2JZNjRQRmVtZ0lUeXBNQksrOWlVV3I4cDU1cDJMVS9lSEZWNE9kR2lITXJu?=
 =?utf-8?B?alYrZ29mOWFFYTB2S3pjOU1yQTc4SDZjUWZGbkZmdG1mTTZTTFpaS3A0aHp3?=
 =?utf-8?B?STc3NndhcXMzeFNHSXB5MW9OMHBISm0wSlVXeUZIY3ExNW5RL2RwYmZSR3Nj?=
 =?utf-8?B?akdTUGVDY05mRERNb01zNXhaYmZuMTI4eC9ITlBXNDBUYk5vUThTTm41Ky9M?=
 =?utf-8?B?bTlaUlRpRHJqdFhVUldOTmRzZnpnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76d3a67c-6b8b-41fa-603d-08dab1b71ab5
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 09:48:41.3915
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aqp0ENKZdHJXWMCSDc4Ase/4UT3wgtwV4jw4yejAwZwOBCTRvsQ0X+R5OsolF8Gq/1KSdnNdKDY/PjY4D0imyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5732
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/10/2022 15:58, Kartik wrote:
> Read the DMA status before terminating the DMA, as doing so deletes
> the DMA desc.
> 
> Also, to get the correct transfer status information, pause the DMA
> using dmaengine_pause() before reading the DMA status.
> 
> Fixes: e9ea096dd225 ("serial: tegra: add serial driver")
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
> v1->v2:
>   * Pause the DMA before reading the DMA status.
>   * Updated commit message.
> 
>   drivers/tty/serial/serial-tegra.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
> index b7170cb9a544..cda9cd4fa92c 100644
> --- a/drivers/tty/serial/serial-tegra.c
> +++ b/drivers/tty/serial/serial-tegra.c
> @@ -619,8 +619,9 @@ static void tegra_uart_stop_tx(struct uart_port *u)
>   	if (tup->tx_in_progress != TEGRA_UART_TX_DMA)
>   		return;
>   
> -	dmaengine_terminate_all(tup->tx_dma_chan);
> +	dmaengine_pause(tup->tx_dma_chan);
>   	dmaengine_tx_status(tup->tx_dma_chan, tup->tx_cookie, &state);
> +	dmaengine_terminate_all(tup->tx_dma_chan);
>   	count = tup->tx_bytes_requested - state.residue;
>   	async_tx_ack(tup->tx_dma_desc);
>   	uart_xmit_advance(&tup->uport, count);
> @@ -763,8 +764,9 @@ static void tegra_uart_terminate_rx_dma(struct tegra_uart_port *tup)
>   		return;
>   	}
>   
> -	dmaengine_terminate_all(tup->rx_dma_chan);
> +	dmaengine_pause(tup->rx_dma_chan);
>   	dmaengine_tx_status(tup->rx_dma_chan, tup->rx_cookie, &state);
> +	dmaengine_terminate_all(tup->rx_dma_chan);
>   
>   	tegra_uart_rx_buffer_push(tup, state.residue);
>   	tup->rx_dma_active = false;

Thanks!

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic