Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 15:15:09 +0530
From:   "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Subject: Re: [PATCH] selftests/ftrace: Limit number of lines processed in
 'trace'
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     Akanksha J N <akanksha@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
References: <20221017105502.307506-1-naveen.n.rao@linux.vnet.ibm.com>
        <20221017105103.540a87c7@gandalf.local.home>
        <20221019001949.950fb044677f96c6cdd00fdf@kernel.org>
        <20221018112224.372a3484@gandalf.local.home>
In-Reply-To: <20221018112224.372a3484@gandalf.local.home>
MIME-Version: 1.0
User-Agent: astroid/4d6b06ad (https://github.com/astroidmail/astroid)
Message-Id: <1666172148.1jppmgndx2.naveen@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Steven Rostedt wrote:
> On Wed, 19 Oct 2022 00:19:49 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>=20
>> > You need to make sure that the "pause-on-trace" option is set or traci=
ng_on
>> > is set to 0 (disabled). Otherwise, if the tracing is still active, the=
n the
>> > reading of the trace file could potentially never end. =20
>>=20
>> initialize_ftrace() does this setting. So it must be set.
>> If you run the ftracetest on old kernel, this feature is not there and
>> it may cause a trouble. Naveen, can you clarify it?

Yes, the change to not pause on opening the trace file looks to be the=20
problem.

>=20
> But for old kernels that do not have "pause-on-trace" it should be the
> default. The "pause-on-trace" was added when the default was changed to n=
ot
> pause the trace while reading it.

It looks like the kernel patch was picked up, but Masami's patch for the=20
selftest wasn't backported. I have requested a test with that applied.

Separately, before I saw your response, I came up with the below patch=20
to update the selftests to disable tracing before reading the trace=20
file. I have also requested this to be tested.


- Naveen

---
 .../selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc     | 4 +++-
 tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc | 2 ++
 .../selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc | 3 ++-
 .../testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc | 3 ++-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-sta=
ck.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
index cf3ea42b12b09f..7e74df1ef928f9 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
@@ -39,6 +39,7 @@ disable_tracing
 clear_trace
 enable_tracing
 sleep 1
+disable_tracing
=20
 count=3D`cat trace | grep '()' | grep -v schedule | wc -l`
=20
@@ -54,8 +55,9 @@ fi
=20
 echo 0 > /proc/sys/kernel/stack_tracer_enabled
 clear_trace
+enable_tracing
 sleep 1
-
+disable_tracing
=20
 count=3D`cat trace | grep '()' | grep -v schedule | wc -l`
=20
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc =
b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
index b3ccdaec2a61ba..7e65a115054127 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
@@ -24,6 +24,8 @@ fi
 echo function_graph > current_tracer
 enable_tracing
 sleep 1
+disable_tracing
+
 # search for functions (has "()" on the line), and make sure
 # that only the schedule function was found
 count=3D`cat trace | grep '()' | grep -v schedule | wc -l`
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notra=
ce-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrac=
e-pid.tc
index 80541964b9270b..9fb0511b5d2eeb 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.=
tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.=
tc
@@ -51,6 +51,7 @@ do_test() {
=20
     enable_tracing
     yield
+    disable_tracing
=20
     count_pid=3D`cat trace | grep -v ^# | grep $PID | wc -l`
     count_other=3D`cat trace | grep -v ^# | grep -v $PID | wc -l`
@@ -60,7 +61,6 @@ do_test() {
 	fail "PID filtering not working? traced task =3D $count_pid; other tasks =
=3D $count_other "
     fi
=20
-    disable_tracing
     clear_trace
=20
     if [ $do_function_fork -eq 0 ]; then
@@ -77,6 +77,7 @@ do_test() {
=20
     enable_tracing
     yield
+    disable_tracing
=20
     count_pid=3D`cat trace | grep -v ^# | grep $PID | wc -l`
     count_other=3D`cat trace | grep -v ^# | grep -v $PID | wc -l`
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.t=
c b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
index 2f7211254529ba..c55bcf2fe1966f 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
@@ -51,6 +51,7 @@ do_test() {
=20
     enable_tracing
     yield
+    disable_tracing
=20
     count_pid=3D`cat trace | grep -v ^# | grep $PID | wc -l`
     count_other=3D`cat trace | grep -v ^# | grep -v $PID | wc -l`
@@ -60,7 +61,6 @@ do_test() {
 	fail "PID filtering not working?"
     fi
=20
-    disable_tracing
     clear_trace
=20
     if [ $do_function_fork -eq 0 ]; then
@@ -72,6 +72,7 @@ do_test() {
=20
     enable_tracing
     yield
+    disable_tracing
=20
     count_pid=3D`cat trace | grep -v ^# | grep $PID | wc -l`
     count_other=3D`cat trace | grep -v ^# | grep -v $PID | wc -l`