Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org, lukas@wunner.de,
        ilpo.jarvinen@linux.intel.com
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH V2] tty: serial: fsl_lpuart: don't break the on-going transfer when global reset
Date:   Wed, 19 Oct 2022 19:07:20 +0800
Message-Id: <20221019110720.31722-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rwiR7mdf/RTajtFdwskQ3xWXmbW4P/Nt9gsgjSp0nchk80R4xjJZsYNYwUDw?=
 =?us-ascii?Q?fwccKrutMCVKhE1fINVtpwXGNjCdtrl5xUwAmfkOGgNipMM2ONXptNI978Xz?=
 =?us-ascii?Q?N3ViqJdu8abb9IOaYayjrJdEgu8XHab+w1L2AMptZW0FbWRss917y36zUlRq?=
 =?us-ascii?Q?r9rSo8UDo8ya+16K25CwmEB5VnzKl4MsiEMDdD4zkTEiJXYq1xmVuwFGt5DB?=
 =?us-ascii?Q?7au2wvFXN+gkszMAzmIqxps8OJ+dOsgs1kmpo2URQF028FS3EHpw42NtuHZP?=
 =?us-ascii?Q?E1MeVepWNFkF2D2grBJ+akIFpYVWhk5tVh+Y/Py3o69Iylc5qz+QxZIxAzkf?=
 =?us-ascii?Q?dOJZ3FpooxWedjdOJReaNvMoD0+yaqTYA5aBEeAWlIEnsNRKxO9TTDATvvme?=
 =?us-ascii?Q?mcGvwLQeFFy31kBEORrOoOycL0mXx/6abK1UcXGC3HzfhAOIOnV8NJQKaSMn?=
 =?us-ascii?Q?PjCE8Js3RB87SuBeycGeVJoG7VKbJ52v/pm8WWRRXedhM40uJUlUG/bVFuc8?=
 =?us-ascii?Q?wuXVEhxfu/AsaQn0In3b3Vc+zbaH8EH0ZII15Cy4yvZUcYPm/4FKIc46pjuP?=
 =?us-ascii?Q?FQRXopQ/lLpqbGzx/9u3d8l7b4xTv9JnS14WpWyd9s6uNEf7nbJbyIES4tRj?=
 =?us-ascii?Q?02SBoM9/KeYHqg1GrGY9IZpRkocJ0WLGW5uPXpcHRrMUxseou3oArnyqHSMc?=
 =?us-ascii?Q?M1eHPolmwd7Q1XV7r1q/L9MCr69rjTHnbXAA/wD73xCkHkepVbESp1CFJ5A/?=
 =?us-ascii?Q?rfIK5HciMbD9H8Z7QODZ3zv8qwbOzVTIef9yV/O8I+le0WL/BGi/lqPZByqP?=
 =?us-ascii?Q?3IUnu0ozNQtssaZ+bIPpIIiGgruDiEFKZrQh+mNaEfRXafYRUUFzfvEOZYu3?=
 =?us-ascii?Q?74dOPBOMx1hht/KoPitxzxrYSsY7YoZkLDnVeQ+FPICP4w//pqpBS7mdxTUW?=
 =?us-ascii?Q?AJaprc6MaxdweksT6L3YlO9nGDVaTUjGX2rGuTrN4TGZgdJvHb2Yh2BM/wmq?=
 =?us-ascii?Q?CK95bfLHUkMAd4SQYVyiuzQe2eI2xWBKnBA0z0CC30Rsl0QAPlqcu5CkbwFp?=
 =?us-ascii?Q?ZxBmNMXgoiRXjQjVfUMqPsl8Pk0UOAmF2LWZU5qGjPeMxA1qWRBtKQBbiMK8?=
 =?us-ascii?Q?rM+fC7R0Eh8pIO5FX45eQNR/UpElg1JFVJo0iC7m/BEEOyTSf47TGkSTTA2S?=
 =?us-ascii?Q?dcS5G7a6ry+ImhjXOrt6xx0rX5Rvb/1DTN9vf7ZFh4FfXSH1oNzP8tXMcfG5?=
 =?us-ascii?Q?oH3qfusbyDf8mGmlGCwKHrv+arEHBVXgIMPchDYe1JczcpDlEWmS+kj6MeZz?=
 =?us-ascii?Q?IsOeeCQaz8CVaavQSp6AvcDwTOaOchrWdtj3Z6jIaK8AGnJZxyLUxEEmzMuG?=
 =?us-ascii?Q?lE9/0EXk3XbiJLY1TRhH1YWnaiMlQiQCXaOHMGUKfI0eYUFDMGyQQvzA0+Ih?=
 =?us-ascii?Q?iXm0jZjPpab/DANeMaekOLXngBQW5nnGxAy23DOObM+wGPDqeKVK+x90nIK4?=
 =?us-ascii?Q?40gSyZE54NVRJpJ+WXcbEOYO9MDRKbMgLiLGbz3c88scHUO5iO5u5UpHkoX2?=
 =?us-ascii?Q?91FloDfUPgqIXOnuxCHb09XrC9E/DUrayCVlEMXT?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9418579-eefc-4e12-2bff-08dab1c2712a
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 11:09:50.9676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3SZ5hMFjQYoGsEAVOWKxRA0a8GlLaE8vc02Pmt7YoFeFndTDJ8udd4qzNojubjUVESxoTvHhMtppOSeT2BhMYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6848
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

lpuart_global_reset() shouldn't break the on-going transmit engin, need
to recover the on-going data transfer after reset.

This can help earlycon here, since commit 60f361722ad2 ("serial:
fsl_lpuart: Reset prior to registration") moved lpuart_global_reset()
before uart_add_one_port(), earlycon is writing during global reset,
as global reset will disable the TX and clear the baud rate register,
which caused the earlycon cannot work any more after reset, needs to
restore the baud rate and re-enable the transmitter to recover the
earlycon write.

Fixes: bd5305dcabbc ("tty: serial: fsl_lpuart: do software reset for imx7ulp and imx8qxp")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Changes in V2:
1. The while loop may never exit as the stat and sfifo are not re-read inside
the loop, fix that.
---
 drivers/tty/serial/fsl_lpuart.c | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 67fa113f77d4..9a0781395b1f 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -408,11 +408,9 @@ static int lpuart_global_reset(struct lpuart_port *sport)
 {
 	struct uart_port *port = &sport->port;
 	void __iomem *global_addr;
+	unsigned long tx_enable, bd;
 	int ret;
 
-	if (uart_console(port))
-		return 0;
-
 	ret = clk_prepare_enable(sport->ipg_clk);
 	if (ret) {
 		dev_err(sport->port.dev, "failed to enable uart ipg clk: %d\n", ret);
@@ -420,11 +418,29 @@ static int lpuart_global_reset(struct lpuart_port *sport)
 	}
 
 	if (is_imx7ulp_lpuart(sport) || is_imx8qxp_lpuart(sport)) {
+		/*
+		 * If the transmitter is used by earlycon, wait transmit engin complete
+		 * and then reset
+		 */
+		tx_enable = lpuart32_read(port, UARTCTRL) & UARTCTRL_TE;
+		if (tx_enable) {
+			bd = lpuart32_read(&sport->port, UARTBAUD);
+			while (!(lpuart32_read(port, UARTSTAT) & UARTSTAT_TC &&
+				 lpuart32_read(port, UARTFIFO) & UARTFIFO_TXEMPT))
+				cpu_relax();
+		}
+
 		global_addr = port->membase + UART_GLOBAL - IMX_REG_OFF;
 		writel(UART_GLOBAL_RST, global_addr);
 		usleep_range(GLOBAL_RST_MIN_US, GLOBAL_RST_MAX_US);
 		writel(0, global_addr);
 		usleep_range(GLOBAL_RST_MIN_US, GLOBAL_RST_MAX_US);
+
+		/* Recover the transmitter for earlycon */
+		if (tx_enable) {
+			lpuart32_write(port, bd, UARTBAUD);
+			lpuart32_write(port, UARTCTRL_TE, UARTCTRL);
+		}
 	}
 
 	clk_disable_unprepare(sport->ipg_clk);
-- 
2.17.1