Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ae8251a-456d-abdd-ed1a-1bfc04356741@virtuozzo.com>
Date:   Wed, 19 Oct 2022 13:38:13 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v5 6/8] drivers: vmware: balloon - report inflated
 memory
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Nadav Amit <namit@vmware.com>,
        VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        Arnd Bergmann <arnd@arndb.de>, kernel@openvz.org,
        linux-kernel@vger.kernel.org
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
 <20221019095620.124909-7-alexander.atanasov@virtuozzo.com>
 <Y0/Qu0eSYFqtuC/v@kroah.com>
From:   Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <Y0/Qu0eSYFqtuC/v@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGZxai9rZzU1VXQzcFRHQnpubGdWaXhoNlRTTmN1ZGxyZDZJbnJMQjZEV2ZS?=
 =?utf-8?B?SGUrczRLRnBtM1FvTDdxd3pJOG1qQkhkODdUQXdSY1hlL1gydFFqZ3pETWRE?=
 =?utf-8?B?L1I0MVFqWGpxSGY3c28xZnlZMXMrcnN0Q1dKcmovU1NVUXZRMjNBUFhJWkhy?=
 =?utf-8?B?NGZLSTBDWlh4Y2lPL3BRWnlrU3c0bEh5cERFUlkvUFN1M2NDcHRqUDdWRi9R?=
 =?utf-8?B?L1BobGU1R1BqUEtWVVR5dW9GT0xxMy9UNEppRVRNaDJLMWNMS1llYi9keDdL?=
 =?utf-8?B?R1VmcURVTUNiZmJEMXQxOTBxZm9oZ0tWWXhmSkZaZktIVENaM3hhUXAxdFRQ?=
 =?utf-8?B?NVQ0cElZMTh0SzQveFZJM0sxVE91NHdobWVBYlVWdzhSemZ3YUlzZmhuajFD?=
 =?utf-8?B?dXJrL3ladUgwamFNYng4Wm5Ca096WEVlUkcwdG1FT0ZoUmNhZXlaWXI0aVFj?=
 =?utf-8?B?S0JQL0ZrVElGSU43cW12dU1Bc0lLaDlrelNBcG44QmtyLzVLUGZCU0ZVL0h2?=
 =?utf-8?B?VmVqTlN6NVVsdzZFMDVjVFEzY1VNSXJVelpSWVY0SGx5NXNBUUdyTU1yQ2w2?=
 =?utf-8?B?QlVNcFFKMHlxK2lNTzBBZHZwOFdzMFM1S1lvb3pDdVdrcCtyT1R6SEtEbjlG?=
 =?utf-8?B?Y2JMSmpBWEdPWlpENm5laUp4S1N6TFh6d1I4TmtvQ1VnRmphTjJleWtqajE2?=
 =?utf-8?B?d2laWkpRdy9FL0s0R0xqSkMrZ0czUDA4U1hmQnVjaXl2bDhYSEZ1eWEwQk9r?=
 =?utf-8?B?cDNVenVnQ2ZyQWFxQ3B0Yi9sQ0NXc0ptNG5vWTJJRlJPMW9iSERzTldZQThI?=
 =?utf-8?B?TE9vZkx0SDZlWlVROEpYUGFtdHpjaE5rL1JTMjdiYXROMGhhZ0tLT3ZKKys0?=
 =?utf-8?B?SEFvRHNtT0ppdDBsbXhkRU04bW5EL3BCS1dmeVNWY3BJc2xGazUyM3NNdlY5?=
 =?utf-8?B?K003UmV1T0lBcllEL25MZWVEckJGdHhWcnUrUi92TnltSU5ZOWR3WlVIVVEy?=
 =?utf-8?B?cndsbDQrK0VvbWhtR0o2bnc0UGZTbkFhaW5QR2tLNVFNdzBJSVlmSEVMQ3ZZ?=
 =?utf-8?B?RlA1cXJVeW9uYnM4NiswbkJIUEtXcDFVUTdXRHZKNExrUTA1MlkyaDNJbGpn?=
 =?utf-8?B?RU1YQ1paRWxkZHROSE5FR3RXV1BJSmVrMFhPNVFDZS8zeDlDU1AzV3pwUUhI?=
 =?utf-8?B?QmVEMUtLdmd4dzlkWlNySE1KQlJuWHB6b3M0a21Dc1JlSW9uU0FLNFVDOFZ6?=
 =?utf-8?B?UjVqL1p4YlpXT2M2dTBUeDJHWDBjQmRmdnk1a3ovSHhTb2trbFMwNkFqdm1D?=
 =?utf-8?B?QldMN3E5RmFaK3k5VXhsRkdKdkhPOEJiTElrUFYyY2FZMDFVczhHclJWL3la?=
 =?utf-8?B?VURoN1d1cjE1NEhLL2xhSXk0RUZSYVVmem4xVEJOWWl4RmY1cnJKMC9hRmNX?=
 =?utf-8?B?RmdBMWwvUlFvdUNmaG5QUkJDeHk0RWlFS3JtYk9qaWNjT05JbzB2NENyTTJI?=
 =?utf-8?B?dWxaRFNCR2cvRnZLNFBZOXdITTRJL1g2SVhWR05xaHJudWF0clRYcm1BY05J?=
 =?utf-8?B?VmJWUUNGZWEvQ1hsN1FrMkF0QTNXVm0rZkJ1Y2g3N2ZHOGlFT3BtUDR6b2F2?=
 =?utf-8?B?RDZnZ2lTWTYzb05qSTBoN3l5ZEttL0pEbXorYmtvems1QWdFczVMWFJCTk51?=
 =?utf-8?B?Q2xXOVVQWkd3OVp5VHkyaWVzVFpXZFltNmUzdXo5RGJoS29CdXcrTHNSTWhP?=
 =?utf-8?B?VDdhOERxd1U5bE52YzFRdTdzVjdpZy9QMDVxeEpBWGVVbis2L0h3Q2w2cUdk?=
 =?utf-8?B?K08xMFFTNUJaM2Q1QysvYXBnZC95bE9zZmVCL01qdjk1RTN5c0R1UFpVelZO?=
 =?utf-8?B?cHZjdnZwMU83dEJtemxYUHU1YWVURVd4QzVPWEJzVHUrZlUyRDZnZ3owMmpF?=
 =?utf-8?B?U1ZMVFZ3T20zUkxteFVYdVdIYXpkbEV5VGV2ZWIwbzFJbkxvT1kxeDl2MUpI?=
 =?utf-8?B?L0xla1U2UTlaWUw4SzVJZ0FheGE0RmFWRFoycHkrU0dUcHBqVE9XL29aQWYv?=
 =?utf-8?B?UDVKNllzcjNURFJJNE9ENzNJU1plSFFPUnprNTY0U3duNVp3aWJUZ0syWHBT?=
 =?utf-8?B?VmpJOFVFZG1hUTBkVGVzM0lQRTlsWmpkUDd1YWNWTDZURmpvZU1HQ3dlM2NR?=
 =?utf-8?B?eEE9PQ==?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff6a2cbe-7fb5-4452-8e69-08dab1be0723
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4765.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 10:38:14.8801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ztuKDWo6qag8TwK624eMNWX9Wojf40ROdjOsQN7B0wATPjbxbgO2AwQlP0MtWfdt9VSy84TPuie9RX0FyhrhxdvVPtNoTzNTnIOLCPvi+xWxJgXqmWI0E42GIq6Poj98
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5530
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19.10.22 13:26, Greg Kroah-Hartman wrote:
> On Wed, Oct 19, 2022 at 12:56:18PM +0300, Alexander Atanasov wrote:
>> Update the inflated memory in the mm core on change.
> 
> That says what this does, but not why it is needed.
> 
> Please expand on this.
> 
> Also, is this actually fixing a bug?  Is it a new feature?  Something
> else?

The whole series is about adding a new feature - providing access to the 
balloon inflated memory amount - it's in the cover letter. Should I 
repeat it for every driver that implements it?

I've organized it classically:
- prepare
- add infra
- use the infra

What can I improve here?

-- 
Regards,
Alexander Atanasov