Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 08:53:20 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>, iommu@lists.linux.dev,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Gerd Bayer <gbayer@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] iommu/s390: Use RCU to allow concurrent domain_list
 iteration
Message-ID: <Y0/lMCQ8oeXJ2HTg@nvidia.com>
References: <20221018145132.998866-1-schnelle@linux.ibm.com>
 <20221018145132.998866-4-schnelle@linux.ibm.com>
 <Y07Dz/NROAMI0Hku@nvidia.com>
 <8e268ab5e0dadf86be5fd7ffaa9debb76cea67f3.camel@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8e268ab5e0dadf86be5fd7ffaa9debb76cea67f3.camel@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZgqiUD5hM+Axckl6sQ2yBizFLCEzXXNEVcMjgaTyYCn7zICWNsBppoxg3G1Z?=
 =?us-ascii?Q?XYdc8Rh/wGSi9HFKPq1tagGmtRNPHWfQ0i0krKu2ok5UHRPpwJKuEyo/WBUa?=
 =?us-ascii?Q?wh4xdPX/Th64gMjP1CTvx3pIbhsufZLiaSv4a4nxRLkyPqdnd7w3GLo6unG0?=
 =?us-ascii?Q?WYyHzHDYQU+5liKHY4nIhFk2aTmCPz3/ngikRg2fd/OBZtCqIQNlc6Le86gd?=
 =?us-ascii?Q?jGXvIwS2Np27acFFitxC6TSXY1mU24zk7IN4E5JCcfYwsQq3cHVmRodqtqrR?=
 =?us-ascii?Q?/y5A9HmmILrXoZgiwqRQWZUslv0+G2i5EDElOW/BJwgNCmVtiHWnz5+hzJXD?=
 =?us-ascii?Q?MUoPzLbtzo74+F1G0J3S2bxMQ/4ik7HyS3zWXcIYFYpZ1fjp3g9k490FJOhA?=
 =?us-ascii?Q?izediWHx1MBZGpskZ7sCiBu1hHPaTaIMSexp8Z9NS1Q0WNuqjXqjmq1OQFe5?=
 =?us-ascii?Q?FbuQiqFo1NwLuXYt4eM3UrhL/8Hxi87eHG24sPlmv3yDFf4TGDrWblTASKXV?=
 =?us-ascii?Q?dKLwwCtuTCICn8UaDjSKT3qESwYTq09VUSK/b7xRTJIh5e2WmT4ae6pGpcvZ?=
 =?us-ascii?Q?ZDhS3cuhZVK3n7DLvwwr9MEM/PluxkxN0UcW4xbAN3f5atWg/P2tAjRE6EAr?=
 =?us-ascii?Q?VM3jjAVzCqMKIEYlfCK4qXPt0Cae+6osQOFcpd1mM0AiXXiIYXUSudixp79s?=
 =?us-ascii?Q?9LcbaZaI31Bzr+xXjjqLOK8DQ9JXSPXYjjXD3kcjgaF5A7IPOg6zG6uFUMni?=
 =?us-ascii?Q?TgFi7rjAEFN37Oc8n7gga5E0WA96GTw90nZ+GPNZgixw+dq446nlqKV0YIQQ?=
 =?us-ascii?Q?yV8gnjpSdGPvNsq0KfvuHr5U9CvX5qUnvlzDUBwzCsEqlFhnhNypAB80xe/g?=
 =?us-ascii?Q?MWT3QefZ3n17EHb7ucmHA3P2epiAI87BhpVIXOG/o2muDhP+s53sQMOJTzhS?=
 =?us-ascii?Q?+kXV884DmGRaybJI2E9SYTwVPHqnDhSuG+8lzQVS8xzoLtzPlEyiEWkYqhVZ?=
 =?us-ascii?Q?8XAwcMTNyYJlZWmDbyq+2CHrHBKGE+FogblqGZXVYCEXo04RR/U/1lWIeKXk?=
 =?us-ascii?Q?kbVCkS0fl4Pg1TKTl1r7iYosE6nkMLeE1Y8SOxo809uwdC8uEo0MMKIjBV/G?=
 =?us-ascii?Q?Kl0UvYeW8lqfyqFC2XJa609iP6g7j+o0lunfoRhUPwLS0yD2Aj54d28Vhagh?=
 =?us-ascii?Q?MGENjfkIDPCvozGMUQbj4wVTFcohFrGkXMXa7CenQQ91LXMyGrtUWiqN59Eu?=
 =?us-ascii?Q?Ib8AXTyer+w3aoWz8o5faovnuoctkpQT8wvFAcikNf6tJpqrshixy7uL52aM?=
 =?us-ascii?Q?xBjeWaRFbNFk1Iyzguacmw+BgzQYaqyrV6pTPEBiEBn8LvBZujzopN7waBtu?=
 =?us-ascii?Q?k35ysnqbQxK8MZXnar87sv4CK3aCW6EGMpJ5Na16Z5jUFVxKJVOEKOIupmZC?=
 =?us-ascii?Q?Ax47xcwEB196WbFvsmlRT6V2Jm6AHZXyXimQ7ULsJNwOhAnVK8pfzJDrpuaI?=
 =?us-ascii?Q?jmnFlEiysDIelc6PZnlqF0OoOzWLUeCgP4xZgTdpTarDzQJGvnN52cD3OFZB?=
 =?us-ascii?Q?VbnmVOmWyc6PbNLmM1U=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4077c7ec-a773-41d1-cacd-08dab1c8857e
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 11:53:21.9632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6lPcJ1aETTxaQo4UnF+9Kjbv+JEE2/LWmml/+gy3x9QKMD++6brib8kK0ymsFnEP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7307
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 19, 2022 at 10:31:21AM +0200, Niklas Schnelle wrote:
> On Tue, 2022-10-18 at 12:18 -0300, Jason Gunthorpe wrote:
> > On Tue, Oct 18, 2022 at 04:51:30PM +0200, Niklas Schnelle wrote:
> > 
> > > @@ -84,7 +88,7 @@ static void __s390_iommu_detach_device(struct zpci_dev *zdev)
> > >  		return;
> > >  
> > >  	spin_lock_irqsave(&s390_domain->list_lock, flags);
> > > -	list_del_init(&zdev->iommu_list);
> > > +	list_del_rcu(&zdev->iommu_list);
> > >  	spin_unlock_irqrestore(&s390_domain->list_lock, flags);
> > 
> > This doesn't seem obviously OK, the next steps remove the translation
> > while we can still have concurrent RCU protected flushes going on.
> > 
> > Is it OK to call the flushes when after the zpci_dma_exit_device()/etc?
> > 
> > Jason
> 
> Interesting point. So for the flushes themselves this should be fine,
> once the zpci_unregister_ioat() is executed all subsequent and ongoing
> IOTLB flushes should return an error code without further adverse
> effects. Though I think we do still have an issue in the IOTLB ops for
> this case as that error would skip the IOTLB flushes of other attached
> devices.

That sounds bad


> The bigger question and that seems independent from RCU is how/if
> detach is supposed to work if there are still DMAs ongoing. Once we do
> the zpci_unregister_ioat() any DMA request coming from the PCI device
> will be blocked and will lead to the PCI device being isolated (put
> into an error state) for attempting an invalid DMA. So I had expected
> that calls of detach/attach would happen without expected ongoing DMAs
> and thus IOTLB flushes? 

"ongoing DMA" from this device shouuld be stopped, it doesn't mean
that the other devices attached to the same domain are not also still
operating and also still having flushes. So now that it is RCU a flush
triggered by a different device will continue to see this now disabled
device and try to flush it until the grace period.

Jason