Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933774AbXF2SLT (ORCPT ); Fri, 29 Jun 2007 14:11:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760754AbXF2SLB (ORCPT ); Fri, 29 Jun 2007 14:11:01 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:45768 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757027AbXF2SLA (ORCPT ); Fri, 29 Jun 2007 14:11:00 -0400 Date: Fri, 29 Jun 2007 20:12:05 +0200 From: Sam Ravnborg To: Jeremy Fitzhardinge Cc: Roman Zippel , "Eric W. Biederman" , lkml , Andrew Morton , Linux Arch , Al Viro Subject: Re: [PATCH] cross-architecture ELF clean up Message-ID: <20070629181205.GA16724@uranus.ravnborg.org> References: <20070620230854.246399397@goop.org> <20070620230902.387008536@goop.org> <468168FD.1080200@goop.org> <4683D78E.6080309@goop.org> <46851CF3.2070608@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46851CF3.2070608@goop.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 22 On Fri, Jun 29, 2007 at 10:53:39AM -0400, Jeremy Fitzhardinge wrote: > Roman Zippel wrote: > >The problem I have is that you want to separate _all_ constants, which > >doesn't really make sense to me, because many of them are useless without > >the correspending structures. > > > > It seems cleanest to just put all the constants in one place rather than > scatter them around based on how they happen to be used. Grouping related things together is always a good approach. But the right factor should be used for the grouping. For the ELF file is would from a usage perspective be natural to have constants close to the definition that they are used to describe. Having constants grouped with other constants just _because_ they are constants does not cut here. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/