Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <faaae681-65b7-0cc5-d413-b8995978d2c5@amd.com>
Date:   Wed, 19 Oct 2022 09:27:18 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static
Content-Language: en-US
To:     ruanjinjie <ruanjinjie@huawei.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, jiapeng.chong@linux.alibaba.com,
        aurabindo.pillai@amd.com, isabbasso@riseup.net,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20221019063115.3757510-1-ruanjinjie@huawei.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20221019063115.3757510-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUhOTWsyYVRkQm8yMDFxQ1p0dFFnV0RZTkk3WU5EOUNqaXVsd2NlVGF2V1VN?=
 =?utf-8?B?RW9zaTF2MFJXZXd4QWhoQnRCb21VeHlDQmxjQkM0WXNwcnIyMUdkSGcvaXda?=
 =?utf-8?B?YzlzaFZRV0laU2F2U1RyV05reWxCMXhOVmdpWXhyTUZoT3ZyMUNURUQ0QjZz?=
 =?utf-8?B?VzM5VjhuUmk3NTZaYWhNV3BUTCtNdkMvVU9sZ1JaV1JQT2kwa2hQS3cxUXVY?=
 =?utf-8?B?VmdneU9nU3hXT1VqUlpGMy9KM2FPcmtFYXRnUS9BRFV0dmJrSjZkWHlZd1hy?=
 =?utf-8?B?Ym5SUENKQ1dtM3JvSDdiR2d0clJ6Y09PdmttbTNqMm1XaFVHMm9RazBHdXJX?=
 =?utf-8?B?ZWhZK2lEZkwvTmlvZXJ0eUdOWHo4b1pCeTR2SVh0NlpwaFMzdnNBU3FIdkZq?=
 =?utf-8?B?ekRibkdlZVZZWHVjbTRLVGVSeUh3NHdRdWY4c1NTdmRpclkvczVwR1RIbFVO?=
 =?utf-8?B?RFJ5MEtrdUVSUUFFRjFUTU5kNGMydUVYMjZoWlpBa1dSMGs2YzRYaFJ5Rkhl?=
 =?utf-8?B?cm9DOTA1eHg5VWNpNlA4VlNoWHU4Z3ZXWGpCNmtuVnhMWUsyUzkwNmpEL3R4?=
 =?utf-8?B?MDdmbUFtQkNhb3N5NzMrVkhZMEJxS2hDQ0kzRXpyWkhTbFM0eVVKRmNIMENm?=
 =?utf-8?B?VUJVRkY5NStUVDM1eUhkTUx3WVMranRtd1U3NlZDQUU1dG4xVExUVFlVOVUy?=
 =?utf-8?B?Ry80TGlMY1pQUkloWG4yd2w3MlZUR0ttMks0VUNNOEZNT08xVlRTYWU1aGtB?=
 =?utf-8?B?T2dCaVNOWmRKRWYzbVc0Wjh2bTRZUExxVk9YTzhOcnN5NG5PVzZmaVJtckwy?=
 =?utf-8?B?OW42NzNLNnFHdUNFemlLc1c1T3lxbS9CL1JCVklGNVJNMzRZeDFhcXYweGIx?=
 =?utf-8?B?cVZZLzJ6KzN5Wkk2aVlCTFdwUUh6OWpwQkhOQngvSFF1L0NVN2dBVnBUbHY3?=
 =?utf-8?B?emhTZSttVFV5a085RHo2SkdndUcrSW9QcGdsT3IrbkE5NGJUL045R1JKL2Yw?=
 =?utf-8?B?MDBhTjhoeDhaRXlQRTNHQmh2dHVMQ2VTd0JFajNJVGhnSkpyMjdDa2I5RCtE?=
 =?utf-8?B?RmFrb0EvR2tUSW4zSW5pd3hiNXZXYitzeHlwZDB0d2xCT2JqVnJYeExNa3Jz?=
 =?utf-8?B?V1RuU3YzY2hXOUFMdkNmVFJYVzNuZ0R1blNPN2JhUktWNFlqcXhoN1Rjbkxj?=
 =?utf-8?B?WU93ZUtFYkR6ajZpTkhvQ2c5OGJjZGN5bEh1ZHZSMnlicUswKzdabnB5NmdZ?=
 =?utf-8?B?alVtYks5bzFpQTRMN1BlMmRIc3dMTmhHQTZRS2NHODVMdEovRE9pR1NvRlEz?=
 =?utf-8?B?UjJqNUpaVklZanBmc01WMmxVcVR3NG15MzhvSU0zQU50enF4OVBBNXVuYmVO?=
 =?utf-8?B?OUNlMmhjUG16NFV4ZzdQNk4rV0owcUw1dFRySjlYclErb1VwUm45dzMrS1NM?=
 =?utf-8?B?TkpRcmtMQldiNzYrSGVXZWYzelFqeGFXN1JvNkpsVnBNcE0xOXczK1N2TkRw?=
 =?utf-8?B?N095UnkyRDNNR2wxcWxIR1hqNUhsOWNubW53VUMzM2RHTE1GRG5NV3dkaVYz?=
 =?utf-8?B?US8xQ3dmamk1K0tCaEhrN0swK3NyQi94RExuemEwRzlqK3pFbmJTTDluTnhP?=
 =?utf-8?B?alFpSm1uL2lWR2lkU0s0ZDNtekhWcGM2b1RkOU0xWDBPMUVpcWZEUi9FU0xa?=
 =?utf-8?B?YVd0d09mWHVXQXZzT2hoYnhDOS9hb0RIZmhNYzgySUc1V2JhdzdleWpVdGlQ?=
 =?utf-8?B?RUNkbXMxTmlTYXhJU1VLaG16UHJ4NS9Ib3NId04wcVR0VjR1THZHaUI5R1k1?=
 =?utf-8?B?aE40aXFPaVh3MWgwNW8xRCtWdzBLUWFySUwyZWZMQ3lxUFVzVi9oYkpRcU5i?=
 =?utf-8?B?NW9jaExHZFdXbnZWVkJ5TmIzcS9qT1JmL3lIMlR5amM1RmQ4ZG9HaTNGejJS?=
 =?utf-8?B?bkRHZU9ablFVQkl1K0dGKzJ1bG1hUUJmKzNTeXpPNTZzd0NYVGJXcm4xTk9E?=
 =?utf-8?B?b281clpxaDI4Sk8xblp0VXVIT3p3MmJpNTcyY3JiSHZ6YmZTcGhtSU5mU3Vn?=
 =?utf-8?B?TjZHbU1UMG4zV2tqTXNDeTltdGxZUDNoSTFnc1JCa1hULzJWR3hFdThXWlRs?=
 =?utf-8?Q?xPKHcZQ3UhhB5Ya2MTHVba5aG?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63d85d61-7fdf-4efc-6cbe-08dab1d5a704
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 13:27:21.8644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uBD/qpRa49MJIF6jRtZLt45vTRF1fyYIfsCyEZPQwwFILIWL32w9Z2S5C7WoP/wO3HubRuvLy+j5N063u9GRGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6140
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-10-19 02:31, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
> warning: symbol 'dcn32_mmhubbub_funcs' was
> not declared. Should it be static?
> 
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> index 41b0baf8e183..c3b089ba511a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
>  	REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE,  params->arbitration_slice);
>  }
>  
> -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
>  	.warmup_mcif		= mmhubbub32_warmup_mcif,
>  	.enable_mcif		= mmhubbub2_enable_mcif,
>  	.disable_mcif		= mmhubbub2_disable_mcif,