Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 19:03:00 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     ldewangan@nvidia.com, jonathanh@nvidia.com,
        thierry.reding@gmail.com, p.zabel@pengutronix.de,
        dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 1/3] dt-bindings: dmaengine: Add
 dma-channel-mask to Tegra GPCDMA
Message-ID: <Y0/8jF++NeUGtPGM@matsya>
References: <20221018162812.69673-1-akhilrajeev@nvidia.com>
 <20221018162812.69673-2-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221018162812.69673-2-akhilrajeev@nvidia.com>
Precedence: bulk

On 18-10-22, 21:58, Akhil R wrote:
> Add dma-channel-mask property in Tegra GPCDMA document.
> 
> The property would help to specify the channels to be used in
> kernel and reserve few for the firmware. This was previously
> achieved by limiting the channel number to 31 in the driver.
> Now since we can list all 32 channels, update the interrupts
> property as well to list all 32 interrupts.

Pls cc dt folks and ML on DT patches!

> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> ---
>  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml   | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index c8894476b6ab..851bd50ee67f 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -39,7 +39,7 @@ properties:
>        Should contain all of the per-channel DMA interrupts in
>        ascending order with respect to the DMA channel index.
>      minItems: 1
> -    maxItems: 31
> +    maxItems: 32
>  
>    resets:
>      maxItems: 1
> @@ -52,6 +52,9 @@ properties:
>  
>    dma-coherent: true
>  
> +  dma-channel-mask:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -60,6 +63,7 @@ required:
>    - reset-names
>    - "#dma-cells"
>    - iommus
> +  - dma-channel-mask
>  
>  additionalProperties: false
>  
> @@ -108,5 +112,6 @@ examples:
>          #dma-cells = <1>;
>          iommus = <&smmu TEGRA186_SID_GPCDMA_0>;
>          dma-coherent;
> +        dma-channel-mask = <0xfffffffe>;
>      };
>  ...
> -- 
> 2.17.1

-- 
~Vinod