Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 15:11:55 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     xinlei.lee@mediatek.com
Cc:     thierry.reding@gmail.com, matthias.bgg@gmail.com,
        jitao.shi@mediatek.com, linux-pwm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v4] pwm: mtk-disp: Fix the parameters calculated by the
 enabled flag of disp_pwm
Message-ID: <20221019131155.52d2yr34f6zapz5d@pengutronix.de>
References: <1666172538-11652-1-git-send-email-xinlei.lee@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xhy4bguvzu5lob7d"
Content-Disposition: inline
In-Reply-To: <1666172538-11652-1-git-send-email-xinlei.lee@mediatek.com>
Precedence: bulk


--xhy4bguvzu5lob7d
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 19, 2022 at 05:42:18PM +0800, xinlei.lee@mediatek.com wrote:
> From: xinlei lee <xinlei.lee@mediatek.com>
>=20
> In the original mtk_disp_pwm_get_state() function wrongly uses bit 0 of
> CON0 to judge if the PWM is enabled.
> However that is indicated by a bit (at a machine dependent position) in
> the DISP_PWM_EN register. Fix this accordingly.
>=20
> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
> Signed-off-by: xinlei lee <xinlei.lee@mediatek.com>

Nice commit log text :-)

This now matches the bit that the .apply() callback sets, so looks
right.

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--xhy4bguvzu5lob7d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNP95YACgkQwfwUeK3K
7AnmNgf/R5fc4bTc7jwlwiPYCqu6y2+9CwYzDaBQRKTTm07Wn728qFUCf+/PMfDh
xMoThPYZRd8iLccDFydMRHavS82UrvIvMAKkh3Utf0j9luEriB3mOZCEw4PkkZ90
xoAj7F0avheWNPHDwapjS45TMfVOSwIDHaAxA9y9irVZmCt50ICb2SDAakk+nB8j
4d4MnpUv/N9uYGEKK2iLrH3pNpcdkq9EX4/6JC324ok7c17blRNG73RJzfFAJLYx
qzSXyi3BqRnCo1FUHDMbM/x79jR6gR9jMKju/+Dw1y9jEIK13//2PxmhrsatUGQv
R6OtXDe92i4kXdVbwHR2BKZl/xYWDQ==
=JPEN
-----END PGP SIGNATURE-----

--xhy4bguvzu5lob7d--