Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad
Mime-Version: 1.0
Message-Id: <7d97c52d-9917-4b3b-8ad2-7243566ae582@app.fastmail.com>
In-Reply-To: <20221019154841.1cb2a15a@kmaincent-XPS-13-7390>
References: <20221019133208.319626-1-kory.maincent@bootlin.com>
 <20221019133208.319626-4-kory.maincent@bootlin.com>
 <5e6858b7-231a-187c-acaf-f82b82a956bf@linaro.org>
 <20221019154841.1cb2a15a@kmaincent-XPS-13-7390>
Date:   Wed, 19 Oct 2022 15:52:12 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     =?UTF-8?Q?K=C3=B6ry_Maincent?= <kory.maincent@bootlin.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com,
        "Russell King" <linux@armlinux.org.uk>,
        "Gregory Clement" <gregory.clement@bootlin.com>,
        "Sudeep Holla" <sudeep.holla@arm.com>,
        "Alexandre Ghiti" <alexandre.ghiti@canonical.com>
Subject: Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 19, 2022, at 15:48, K=C3=B6ry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 19/10/2022 09:32, K=C3=B6ry Maincent wrote:
>> > From: Kory Maincent <kory.maincent@bootlin.com>
>> >=20
>> > Enable the PL110 DRM driver, used by the spear600.
>> >=20
>> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFI=
G_DRM. =20
>>=20
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selec=
ted it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by d=
efault.
> Why keeping something that is already automatically enabled by CONFIG_=
DRM?

It's something that DRM probably should not select, so if this
ever gets fixed in DRM, you get a broken build. Just leaving
the line in there is harmless.

      Arnd