Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <644c4a8a-8e30-5f00-7b9f-55c2d59e0d69@linaro.org>
Date:   Wed, 19 Oct 2022 09:57:26 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display
 controller
Content-Language: en-US
To:     =?UTF-8?Q?K=c3=b6ry_Maincent?= <kory.maincent@bootlin.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com, Russell King <linux@armlinux.org.uk>,
        Arnd Bergmann <arnd@arndb.de>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Alexandre Ghiti <alexandre.ghiti@canonical.com>
References: <20221019133208.319626-1-kory.maincent@bootlin.com>
 <20221019133208.319626-4-kory.maincent@bootlin.com>
 <5e6858b7-231a-187c-acaf-f82b82a956bf@linaro.org>
 <20221019154841.1cb2a15a@kmaincent-XPS-13-7390>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221019154841.1cb2a15a@kmaincent-XPS-13-7390>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 19/10/2022 09:48, Köry Maincent wrote:
> Hello Krzysztof,
> 
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 19/10/2022 09:32, Köry Maincent wrote:
>>> From: Kory Maincent <kory.maincent@bootlin.com>
>>>
>>> Enable the PL110 DRM driver, used by the spear600.
>>>
>>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.  
>>
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
> 
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?

Same question every few months :)

Because otherwise we can drop select in DRM and do not update the
defconfigs.

https://patchwork.kernel.org/project/linux-samsung-soc/patch/20191125125515.30795-1-m.szyprowski@samsung.com/#23021125

https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/

https://lore.kernel.org/all/c5150e83-0e50-3be6-b6bd-bf30fe5e94d1@linaro.org/

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2315d3aea5976acd919d3d3fcf82f752562c25b

Best regards,
Krzysztof