Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8eb93fb6-a1c4-5ef4-f549-8649bb36e59a@amd.com>
Date:   Wed, 19 Oct 2022 09:28:03 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static
Content-Language: en-US
To:     ruanjinjie <ruanjinjie@huawei.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, jiapeng.chong@linux.alibaba.com,
        hanyihao@vivo.com, aurabindo.pillai@amd.com, Martin.Leung@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20221019062347.3756071-1-ruanjinjie@huawei.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20221019062347.3756071-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3pFV0JBZStXay9EaXF3M3pnd2o5Tkp2ejZVQmZlazlUMzVpTzdRV1Z4MHkw?=
 =?utf-8?B?d2NWVXo1UGJBekVHT0VIZndqcGZjMFRSc1VlalpaUmswMWowci85Nlp3RnQr?=
 =?utf-8?B?S2ZReWxDeHg3TGg2NlUvVmFMVmlLNmxuRGY3aHcwVWRVZ0NjQ1pzZFJhYkQ0?=
 =?utf-8?B?Vy9jMXFXTUd2TEd6aHFzZkMrNGN4ZnNCSHArT2c3N0U4K2MwL0hQUzF5TEZP?=
 =?utf-8?B?NW9KeS9DNHpFeWYyUjNGTHNad054eG1hODJOTy82Vk9Sdzd3OVNZTHVhQmhp?=
 =?utf-8?B?QTdOVGdlY2pscTMvTGp3MWh6cCt2U0VLOVdTTmhrV2RETlE4ZDh6NlhqRWZh?=
 =?utf-8?B?cVQwYVNXT3Bib1AwSVBHbHp2L0Y3YXR2OWg4SEszdDNpaDV1blRTSEVpMXBw?=
 =?utf-8?B?TlRpSSsyWnN4MlhxYjFOMkpUQ3VWQms3T3dWS0Y3c3M3S003ZG5lanA0cktN?=
 =?utf-8?B?aHBvdVQzcmhJem1mZkdFNVdOUDVFU3Z5d01kS05DczZDNzRKN2prNG5ZTDZx?=
 =?utf-8?B?QkV3dmZKT1BLKzdoZUlGQU1wcFZoazNJYmhrS25Xemd0ZGdvSUVVNmgxZy92?=
 =?utf-8?B?K1VLWHg0RjJ3T2hUY0czanVONFU3SXRJZUVFalFYTG1OazNtQm9JaU0zZEMx?=
 =?utf-8?B?TUxSYXNZckJZQzNxZUdRTUNtdWJWVnQ3bDBFTHIwYis5VlF0Q3FJUElJdXlB?=
 =?utf-8?B?Uk5tUXFzbVJsRzg5cmUrZkpJcmlibGl3YlhVV3p6aUtKUldieW83V3FFRDND?=
 =?utf-8?B?NlFoQlM0Z25qMk1ueWNGRFNYZFFuNXdPQ0RpV3N6TlF3ZUdRSitzNkVyRGY4?=
 =?utf-8?B?UHN4UGVocVp0d1N0N1RjaEFVS011aDJxbGl4MjVISVFtWWVhaDJ0S3o2OEZ0?=
 =?utf-8?B?WVdLWGRlenZMREdwZStya3RQczJhSmYwVVgyTU1kMVBUc2FkNzJnV2Z5ZFRT?=
 =?utf-8?B?cDdkaGhLS0Z3bDQ3QnFuQzVhRlBQbEU5YmFMT0FINWtoZzc3SHRodW9zYkRT?=
 =?utf-8?B?aXRMa0VYeW9MTU5saGRNTytBcWtTZFdxUEVuNGI4NVowODYybWxlSjhpejdF?=
 =?utf-8?B?Ry9NNFZVb0pUaXE4NFlsQUpTZ01oVEhpWHlYVUtXWExwNlk5M2JKMUNlZGZ3?=
 =?utf-8?B?bGJyb2F1N1RhcEpmWmdCa3V4RUR5K1ZNd01RL3lISmhGRkV2TmxWcVl2SVc0?=
 =?utf-8?B?WldkaEtLWVZMTW95RUQvdHgweW0vQm5yWDdGWnQ2RHhJUHBNWk1VQWdxZjlF?=
 =?utf-8?B?bjVaZlhlajh6QktCMlMxNm5QTS8rNGI3cjN1eXYwaEZWOUE2V2F6Ukw4Nm90?=
 =?utf-8?B?c2hwUU9pZHo3WWdocFRGb29xd0I2UkJvaGgrMTljNG5KTk9kRjFaVzFFTzdZ?=
 =?utf-8?B?MHlzNjNaZ3BQSlhKaGpiakJIcEdVMmY1ME16S1JMQ2N5eUh3djZZSDVPMUNz?=
 =?utf-8?B?djBYS0hKT24zdCtSWms1aDhVeDNGWUorL1VVUzZFQ3JOUWpjQXZUVFRuVkww?=
 =?utf-8?B?dUY4NTZNb2JaS29IUllYV3RvR2h6TlpVcityOWloallBdU9IenREOFB2aFlQ?=
 =?utf-8?B?eXpUc0wvUGcvVG5DM0hyemZQMjBSMnc3VkZNSGZGalhmNjRMRTJ2NytpTXc5?=
 =?utf-8?B?aC9sRmNSN1Rqa01PRE8xdkZacEI1UThwZ3pDYzI2Q1VKakZVM1NlY012SXhE?=
 =?utf-8?B?a3ZqZWdHOXdOTzRVc0RNWDY3WXViZ1lZKzhFdEpyZnpBUUxkZFlxNjZjSWcv?=
 =?utf-8?B?d3RyVnZMbDUwNVVuTFNlS0ozSjl0WDBWa0R3bzV4R0lZUWNNbXNDam94bkJK?=
 =?utf-8?B?RGh0OG9EamR6RHFWM1ZQZ1FNRjZzNWV4b1hIUE9iSGY5NjBJR1ZOMWhSOElk?=
 =?utf-8?B?elVINkVZdzZLeXFZZnYzWEwwcDRlUk9Ud0F1bDJlMjZQL20zc01mMGc1WUdz?=
 =?utf-8?B?SitZYjJrNS8xSzBxU2l6L1FZVlhDVHBmb3NHeXlRYmZxdVp3cmNXZGxxS3hH?=
 =?utf-8?B?UndUNFlJUjJhZjlGN2lsY0ZRY1ZVUmJEYXA0dVNXdXY5VWJaMStzYlVCM1Fy?=
 =?utf-8?B?MHcwOTVzdTNEWXR4ZGlneEpJem00RlpxeWZaeUozK3Y2clBYKy9CWlpHOGdS?=
 =?utf-8?Q?nLe7Lxw6TlQ/WMu3tVSNxFHDx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd7279e2-6f39-476d-1c2a-08dab1d5c23b
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 13:28:07.3507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qomeJE+pJjzPHvDh87J1OcMku8icgg3oHsKrqkv9xnMA2yOqzM09ye5TNDtyel3Tv0JrqcwZg8r1I1cEsc5dPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4262
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-10-19 02:23, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning:
> symbol 'dcn32_mpc_funcs' was not declared. Should it be static?
> 
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> index 4edd0655965b..206a5ddbaf6d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut(
>  	return true;
>  }
>  
> -const struct mpc_funcs dcn32_mpc_funcs = {
> +static const struct mpc_funcs dcn32_mpc_funcs = {
>  	.read_mpcc_state = mpc1_read_mpcc_state,
>  	.insert_plane = mpc1_insert_plane,
>  	.remove_mpcc = mpc1_remove_mpcc,