Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1191818rwi; Wed, 19 Oct 2022 07:43:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM407kzJDi6iKqn2kUIpAYOQ/deRU5eVGKhF5thgKuo37QpXLr4P/RdFH9oy2Y83SWPwiTgJ X-Received: by 2002:a17:906:3e01:b0:781:6462:700f with SMTP id k1-20020a1709063e0100b007816462700fmr7108208eji.307.1666190635597; Wed, 19 Oct 2022 07:43:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666190635; cv=none; d=google.com; s=arc-20160816; b=lXcnBT5u9UfLh2i8Cq2GXgwmiPWm1DbIFVcyTzAh/fPh9NHOykKauFDAEowkPkNteC uhKd1DvnwVhfH3iXMskJXDktD3+rnCOc3wn9JOmNY09pSe5SYy+MU5hvrXeapnnGf9zL YKXr2XXDbdUgg816mDbIjiNUIjmBqf5+/30/kChvkuk/N99w0WNeQ2/zeUhYtfiCfbCu erp6XarMBVvpydkOcYEjWBGna1+chSQu+vREFUP/KCE0gezw5JaNMbGR6Tkw1LiaSggf fif435W7JGCwdCJOKWwgLds8Fc7ta8VfW3vrC5yrTDlb+nX3hRZ++nuCu0uADCN9b0M7 tRvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=OOfBa7+7Ac5J9E9dOike9309BkGfqPd11AE88K1rKqE=; b=RV2StDPdbeuWnsJg5PKy/iEqlykkZf9MSRC3qEZiaaU5dYu10jxON5ChUd1Fb5lkBY XQyACBBhBmORlVPi6DwpqTQwvHAAf1czTehVKOzrP2TYIlI5an4v/an/rC/aHrsDw7Cf im/xleeWIPUIiSn92ed3TK5uNLk7z/xSP2Gat7IO+quxtrow8b82eFKgxzXmqdc84mzw DBDcb9FcjXwXh+SgmVcsA+HcByuNYvC4bFoRHaMuikc5FdRn4q+OTbSdZrWfK62r8qZU YgQwkVO0DWyvMBmcFkEy5GcGrFmd6QhwuqB0IB2WTIZfGD7+wGyPS314fBwKrmJ3BUDb epzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=UCmD794v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020a056402350f00b0044ee4ec8915si16639092edd.39.2022.10.19.07.43.29; Wed, 19 Oct 2022 07:43:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=UCmD794v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233054AbiJSOJv (ORCPT + 99 others); Wed, 19 Oct 2022 10:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbiJSOJb (ORCPT ); Wed, 19 Oct 2022 10:09:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C2897D6F; Wed, 19 Oct 2022 06:51:37 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C1607660238F; Wed, 19 Oct 2022 14:48:10 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666187291; bh=JRFBIEM/o3vlqulr1q6kOtGadUUgU5fFs6PkyTMxPoM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UCmD794vdXoT52u4B6OT78/64SmEehyANCMurAXV+o/M6BESNlUbHQOjv3jkxrL3K 9BHh5/+85ySWzuLpP7nrVjysxQQG7CSGjLuo/NzoPd9x/rv1kKajohe3gYwOmMUAKQ VZ3Y7RSFJYmJRoqWW+Guri4l1q1fr2KAJSCn0OBVhTPBohP1KiapOQGFTw5tbiBD+l LgC3Db3v/ivXnLilPWVuqrwBSxZ9YPhBB1c/VAinDz1eeUhf2Ha2DZfJ0kCg6LaeHl gPpqH+TTY9yAIc9ni4o+ZaG0n2zBsfLoj2KLMROl8HFiNwYlX+ExHYApUr7XZtuTaJ u9ZL2m9yX1X6A== Message-ID: <56042926-4921-3e77-ae0f-3bc6c462bb5e@collabora.com> Date: Wed, 19 Oct 2022 15:48:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v4] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm Content-Language: en-US To: xinlei.lee@mediatek.com, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, matthias.bgg@gmail.com, jitao.shi@mediatek.com Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <1666172538-11652-1-git-send-email-xinlei.lee@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <1666172538-11652-1-git-send-email-xinlei.lee@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 19/10/22 11:42, xinlei.lee@mediatek.com ha scritto: > From: xinlei lee > > In the original mtk_disp_pwm_get_state() function wrongly uses bit 0 of > CON0 to judge if the PWM is enabled. > However that is indicated by a bit (at a machine dependent position) in > the DISP_PWM_EN register. Fix this accordingly. > > Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()") > Signed-off-by: xinlei lee > Reviewed-by: Uwe Kleine-König Reviewed-by: AngeloGioacchino Del Regno