Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 14:16:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Eric Farman <farman@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Halil Pasic <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Eric Auger <eric.auger@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        kvm@vger.kernel.org
Subject: Re: [PATCH v1 7/7] vfio: Remove vfio_free_device
Message-ID: <Y1Aw4Ync0SjaiES7@nvidia.com>
References: <20221019162135.798901-1-farman@linux.ibm.com>
 <20221019162135.798901-8-farman@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221019162135.798901-8-farman@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?18gHApC9mIqdzv/nGs8seMN1y0a+2G3+CmlG/zh3aUblPmIXh2Ds6zrPYgp6?=
 =?us-ascii?Q?PlWMru22ZeJaGnlR30mI5dihXQ/IGWLYDtg+UVpcu2P6Z6fyd8UsiPKlcYJ3?=
 =?us-ascii?Q?UlrP63mEHESXMM0gvsWPRUtlJCdqynTU9xGouEaKipU4XnxpEBmiA0wKr/vy?=
 =?us-ascii?Q?mhTy/xkHY+fHeLc4/6uYJtPkQrepbsh8Qxu64qHmpZVn/ns7i/POGnSw4lhg?=
 =?us-ascii?Q?6V73VojDRwuTOBTuyTdxDujmzOhmD+7vU8xpFjOBMwY2KJSUAY6iqquFdan+?=
 =?us-ascii?Q?K8aoRaVIgVv/Vb4D0Wj3LSbOMRrIH0lCc97/SpFXa4fk9hOuy8dDnvEARQGb?=
 =?us-ascii?Q?epp8kl0no5CuqV5O7o/T9v2+Ituxr3+6Z7U34+kNtvFgEhJc+IYGrLWuONNt?=
 =?us-ascii?Q?wonQ0v+PRiMoJbQEoMv2AstYYzwSeF0QSgP6wYv4aHD8rfege60y+s9Vee57?=
 =?us-ascii?Q?S00jqCAx8QQLI+4DMkMpJTyWr3KtXSJl6Rs+AHz3KsM5Pqngx7bCYwl0BPE0?=
 =?us-ascii?Q?zlGqyMjsJpiWsQD9oOMsqCKZgyooSLC8OwF0WnKBNbvHKC34HNTNXbsBDi1N?=
 =?us-ascii?Q?jtNSyGdnKv5Gsg+vrlD8CBV1qvnOvph7ZZx5S50Y5r6ey8VDWpeK52+xqiT6?=
 =?us-ascii?Q?P8uusrcTbE4iQLJw+KyzJwWfgF1wNoxyhuz8XEcm2hivZX8kNM7VZnj7HPtN?=
 =?us-ascii?Q?akygX8+zJ9/ErfHC7mzQTNcHpwe1ORfjVgq7w9LOGbOB/HRAotvGL6L2jJpy?=
 =?us-ascii?Q?q+zeDPbKreVKdIpucYPBC7REC18t9aI+OdYrhYkBPYS2mkldHxGeOZaojS1+?=
 =?us-ascii?Q?gcrPdGhAbpm9SBgSymUp0ofpkiCIPud9biJWofP+UJkpPP1Jq2nmKjvvXDm/?=
 =?us-ascii?Q?cocqqTcCWW00aWrXi8OkkUXbkPfzmOzQ148WfnQ8dbyt8tYbJ/lE1O6tf/SY?=
 =?us-ascii?Q?Qtbv82P1PPtkurrT0GR3IdwsU0S+1bRjlsk3ktOoXA7hy+xvnWbfW3k1YQyf?=
 =?us-ascii?Q?POrxd98bQSRY38BydsmZq79Q3b1fJn+t18ryrpJGxqszVbYoYCEHa2P/9ulW?=
 =?us-ascii?Q?ukvf7pNj6fzjXjRZAciZoRZv+pvvSFIYiBKhgEI++fW7hZpZNnY/GMaJCkRY?=
 =?us-ascii?Q?0b6XfvqV+8TGbksEcABQEmI9WxjCV7/COmIIygN5q1+xDvVBHlSIuwsqLkSe?=
 =?us-ascii?Q?YmtynVM8NNT89QT3/eZ70GuSGqpw+TDB+DQ3xCQM+/NCRfaJtjdyeqTLTB+1?=
 =?us-ascii?Q?yZW4/eNr+CdqALGiz5PVcujNlr9xXNlFcKhh84350OpINu+kZlA2NXrt+m3G?=
 =?us-ascii?Q?eWqDHFOEa9PQ9uaCHF7TY+eUViAyllQwmyyr1lIswD8dNsO7u0opfLy7ba1T?=
 =?us-ascii?Q?34o3D4QAnDNe4QDAR7U+D6qRUG/0XTnawOTcPg5/4UqHY2GJ9jbKlF6yUnXJ?=
 =?us-ascii?Q?OSBgXZP2jzXyduMU/obvwkjGTZZPIkclNq3jUPTWI6aY1wlHz3qIMSbId4QU?=
 =?us-ascii?Q?LzE0uq0TxpG94DkaJcDDqFX/0v6pNg/y69RQiI0XJC6bG2NRXNlYcowygD0d?=
 =?us-ascii?Q?8I4l1BxjGg5j6PLsUFw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 050e3267-5a97-434f-ab4d-08dab1f5a283
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 17:16:17.9863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TPm+XV/Eh8Ajb5sQCWJ5wblUDYGFAQGVtROij5Ja08kLRhJXOJce7WA975MqFVX3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4954
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 19, 2022 at 06:21:35PM +0200, Eric Farman wrote:
> With the "mess" sorted out, we should be able to inline the
> vfio_free_device call introduced by commit cb9ff3f3b84c
> ("vfio: Add helpers for unifying vfio_device life cycle")
> and remove them from driver release callbacks.
> 
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason