Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 14:15:30 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Eric Farman <farman@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Halil Pasic <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Eric Auger <eric.auger@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        kvm@vger.kernel.org
Subject: Re: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_
Message-ID: <Y1Awsh56Ur/cDrHh@nvidia.com>
References: <20221019162135.798901-1-farman@linux.ibm.com>
 <20221019162135.798901-7-farman@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221019162135.798901-7-farman@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TJnT5/dtaW4Qrq4V6mVMrzYp/tYa5MdjXOvNp3b//J1sHuKEIr7aJrUM96eW?=
 =?us-ascii?Q?DQMcCBM8T2q1spaCSmysQKCvA8FyZ+BgWD6c6aebvNeJgqtWHwwIXvfIhUAQ?=
 =?us-ascii?Q?I17Q6gY3QHS7ABC1e17l3Wo2fpk60cxarf3C4WUekQtCZQI4CwBjBYwaCvFv?=
 =?us-ascii?Q?sxD1dbI8aSfdyjK16JW6NQgaw6Ynz1xhXuIlDbX2GPcJm0lTeXzZnnaiUs0A?=
 =?us-ascii?Q?Qi8veOaCyQZGkuRsi6Z/2r+Rb5NHDZ139a6m5ClS34ErbWMDZJ+/0ybVx3Af?=
 =?us-ascii?Q?aAeerw6tph5wO+orCaTqt/1ml7J1J5b2X92tem119LROemKq+ckdHJ5wPQvp?=
 =?us-ascii?Q?G5dlFyHN7y8AN6YsNUx581zb9Wokd+IR5zJCPixrlC0T+BIcMD7Xfi8QK1Rl?=
 =?us-ascii?Q?P7tFt2lFTBY+jCFZB3H87pYxY6nVli0ggX56HJ6ftvfEDQkR2Ezi34FNzVNX?=
 =?us-ascii?Q?CmrdselhMpiVOW+XzokVOhqD74WjxpzwKWseqagTlVQaWFbbIxkYCn6L4dKn?=
 =?us-ascii?Q?U8/h0JSYcZYQoQdO1D1d8MvjxpRxUigPS242p4lqH0TjkYs8hThXULurfYpq?=
 =?us-ascii?Q?xd/Ixu3qlygrBq+HmVG5x8pKwxg0F7gBEdIUC0rdwAT1TISOrsCQWCWCRcgy?=
 =?us-ascii?Q?ndnIh7hto3y10vKcKoGgdH5UG7p1HrsiQm4rxwaSQ+hk70KnjKM/SrJholDL?=
 =?us-ascii?Q?BgTeCEtvrCvW+BvARxWdzPD8Ml2QG2ejGpArUDJmJqpp+tcezdHB2LVLG3ne?=
 =?us-ascii?Q?XiiAvXOay23zdQSH4X+sqMkG8kTlWecFvgDaL77SKR64EZg/Pv/UvdSSo10T?=
 =?us-ascii?Q?W1Raq2kACl9PVXoxUFBlSQxAqbDBSZesWTrtCYuqp72ek57+Czm7i5N9wrKC?=
 =?us-ascii?Q?LOSSujhc3urweC9yQbZcW6clyZV4DbJE9MrCqSqL3L1hNpFq5HnLumNZoiBF?=
 =?us-ascii?Q?kWlPL/5m/fgErS7VxDKK+pW219j2dQPAxIkK2SfclJAyjb+p5fe1itqCIpOx?=
 =?us-ascii?Q?Oq0v5yNUGt1ZJTee7MIN6JCzhnqXZEcWldsNjoUpa1U9N1SX7Ik101fFdVIP?=
 =?us-ascii?Q?7tL69YATnj2NzqscFbnzVscFA3Yd99dopHneWjGzB0qsEGU/jEHL1ERc9Cr5?=
 =?us-ascii?Q?yUqxlT3ZGWvPW8zCWr8gx5lIQKMRXAsiK68GM1s6fgMiKeayTePwPS4s6WdL?=
 =?us-ascii?Q?sAmjUFVd5LaXlPPCK1oB919PYNz/Hkx7WOiMzS/SRBKey/ttda7PB9vf1AEP?=
 =?us-ascii?Q?8Qh83UCOFd6jeInj0XAGuZnF1EK4buDsphrqeS4rda+wBqsA1ntJqba3eh5y?=
 =?us-ascii?Q?fJ7s1wZKaMHAAxVzEqPVEZXg6GDO50iGz+eO9Q8JPt5iMjwoCcHdC4BB+Y/T?=
 =?us-ascii?Q?KPVIoC4a9XumVnZZQ4MEj1XymLHP2sWBenU9Nc0IVswNenoEyHcscSvvolW8?=
 =?us-ascii?Q?U8xj067uf7zuO4Kvj6WuzxtU/WXGXKK0P+ltOokvR4mWodYUBQQYzqCfFoYO?=
 =?us-ascii?Q?i4srC9UPbEhz5iQ7omtZlMAGrYb80ZWNMkGtXQCmUFiBLx/JKR4uDAYd6Spk?=
 =?us-ascii?Q?wl/e0MdALHPcNQ6AqIs=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83d74008-cb3b-42d7-f916-08dab1f586c0
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 17:15:31.9117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mLBsXjG/earih/mHhaf87AYpyLZueUs1LoTMGTtfJf/ra5/oLKMdwB4GOICsvT4L
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7600
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote:

>  /*
>   * Initialize a vfio_device so it can be registered to vfio core.
> - *
> - * Only vfio-ccw driver should call this interface.
>   */
>  int vfio_init_device(struct vfio_device *device, struct device *dev,
>  		     const struct vfio_device_ops *ops)
> @@ -422,7 +420,6 @@ int vfio_init_device(struct vfio_device *device, struct device *dev,
>  	ida_free(&vfio.device_ida, device->index);
>  	return ret;
>  }
> -EXPORT_SYMBOL_GPL(vfio_init_device);

Should be made static as well

Jason