Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4d113cfd-4c22-780e-2a13-48ca0e2b28ab@foss.st.com>
Date:   Wed, 19 Oct 2022 19:23:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] dt-bindings: nvmem: add new stm32mp13 compatible for
 stm32-romem
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>
CC:     <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
References: <20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid>
 <7ada410d-8d13-b29a-869c-3f5d032528bf@linaro.org>
Content-Language: en-US
From:   Patrick DELAUNAY <patrick.delaunay@foss.st.com>
In-Reply-To: <7ada410d-8d13-b29a-869c-3f5d032528bf@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 10/18/22 03:56, Krzysztof Kozlowski wrote:
> On 14/10/2022 11:23, Patrick Delaunay wrote:
>> Add a new compatible for stm32mp13 support.
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>>
>>   Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
>> index 448a2678dc62..16f4cad2fa55 100644
>> --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
>> +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
>> @@ -22,6 +22,7 @@ properties:
>>     compatible:
>>       enum:
>>         - st,stm32f4-otp
>> +      - st,stm32mp13-bsec
>>         - st,stm32mp15-bsec
> According to usage in DTS (separate patch for some reason), the devices
> are compatible, so please describe them like that.


I push the separate patch "ARM: dts: stm32mp13: fix compatible for BSEC"

It is a advice of my colleagues: send an update of device tree

only when the binding modification is acked.


Sorry for disturbance, I can sent a V2 with the 2 patches.


The STM32MP15 and STM32MP13 don't use the same version of the BSEC device,

and the driver need to handle it.


In these 2 patches:

- [PATCH] dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem

- [PATCH] ARM: dts: stm32mp13: fix compatible for BSEC


I fix a error for BSEC node in the initial patch to support STM32MP13x,

the DTS "stm32mp131.dtsi" should not used/accepted with the a BSEC node 
using

the compatible "st,stm32mp15-bsec" in commit 1da8779c0029 ("ARM: dts: 
stm32: add STM32MP13 SoCs support")


It is a preliminary step to add support of STM32MP13x in STM32 ROMEM driver.


I don't indicate these patches as "Fixes:" to avoid a dts check issue

if only the DTS patch was backported.


Today it not blocking for STM32MP13x users because this SoC is not yet 
available for customers

and it is only used internally on the ST Microelectronics board 
STM32MP135F-DK.


Nobody (except STMicroelectronics) use this SoC  STM32MP13x with the 
current DTS / Linux version.


Moreover, by default, the STM32 ROMEM driver in not activated in any 
defconfig,

I prepare a other patch to activated it by default in arm_multiv7_defconfig.

but I am waiting this DTS correction to avoid to probe the stm32 romen 
driver with STM32MP15

configuration on STM32MP13x SoC.


I think is a good time to update this DTS error before the SoC availability,

agreed with SoC Maintainer, Alexandre Torgue, even if this patch breaks 
surrent users

of STM32MP13x DTS (but it is only internals user STMicroelectronics 
until now).


but perhaps you prefer a other solution ?


add Fixes in the DTS patch ?

+ Fixes: 1da8779c0029 ("ARM: dts: stm32: add STM32MP13 SoCs support")

or


         bsec: efuse@5c005000 {
             compatible = "st,stm32mp13-bsec", "st,stm32mp15-bsec";


sorry, I misses to share this context.


>
> Best regards,
> Krzysztof


Regards

Patrick