Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c3774a1-1577-2d4c-38d2-3648cc1d137e@nvidia.com>
Date:   Wed, 19 Oct 2022 18:33:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] mmc: core: support zeroout using TRIM
Content-Language: en-US
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>, kernel <kernel@axis.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "tytso@mit.edu" <tytso@mit.edu>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Prathamesh Shete <pshete@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <20220429152118.3617303-1-vincent.whitchurch@axis.com>
 <3c75ca82-f889-a346-a031-2c417c57e2b0@nvidia.com> <Y1ASr6zpqobEbFmG@axis.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <Y1ASr6zpqobEbFmG@axis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHI1eE9NUjZ0MmJXZ0N2V3A4VzJOUXExRkcvVUxzRTdQbGFQS05tOUVRTUU4?=
 =?utf-8?B?MkNjTlkvU0RiQ0NzYmg1Ynk1cmw3a25sRG1mRlBjbXNzV2hjNDlpalNPWTZo?=
 =?utf-8?B?Vk51YktWRHI0K3hrS2dVcWdTazJCSHFwaW9nQTh1eHVyTmZpZm9zTDRNelF0?=
 =?utf-8?B?Q1A5dlFnNGhtTFlBekZjY0hadEk1cTRWQkxIM0NEa3dQSHRNOTdDZEJySWo4?=
 =?utf-8?B?VnFwMUU2MzREaE5UNUp0N0duY1J2QXBtLyttZi9WcjRoSFh6dE9lK0hnbDIv?=
 =?utf-8?B?ZjVUbXdJWkQvSnEzWW54ejhRMmVaZXRtSG95NlE2VFFLWU9zd08xMlZmR2VW?=
 =?utf-8?B?VWNKTGZzQVFEd3NFOTNGWXVZcDk1VmU2SlRQSG9HaGxsMjVhVVFLcm9pNDRa?=
 =?utf-8?B?TFJqL0h5TzB0eERVWGxIY21KUmd1OEcxMWp4ekJHTHRITWpmV1AvK1VPZ3Ey?=
 =?utf-8?B?UXFhR0tGemgrUTFKdENqVnBaS0pjQVVkMS9jem9tYm96d3NONUdPbnhvZVl6?=
 =?utf-8?B?ZHJWR3dwU1FaVEY4MGJjeFN5N3dUZmxmRXB0V1hTYUtDWWg0QnhJY1R0SWRM?=
 =?utf-8?B?SlVCNEVNMVhzY3IvS2g3eC95WXBxUWs0RnYxQnlSUVp2TXoxYmo1RmYrZ3RP?=
 =?utf-8?B?dGJmb2hPQmVlT0doN21nZ0RLbnpoSUpMR055MVJuRmhUSzI0RWRkSEM1ZDFW?=
 =?utf-8?B?QmtIRXd0YzE5bndVZXMwZHpUZGhnRDdOKzhydGIxSHhBVHd3UGpXbE9PSnc3?=
 =?utf-8?B?L0ljd05rNzJrOVZSaHE3WmxpWXZmT0VyWkU4cXVlZm9BaDFYKy82UGhaQ0xE?=
 =?utf-8?B?eGMySlVLQUdDMlBLaGUrYzYweTcwWE5sMi9VRDNrMVhZSFh6V1hod1h4VUQ3?=
 =?utf-8?B?RVVxY2VQNnZpS0o0dlUyOEk0czYzQWcyZU1vNWEzK0g1eW1TQi9ZVTRFdEsz?=
 =?utf-8?B?ekhuSWthMzU1MXd5Y2twWmR4YnRwdkp5dlVlMHlxZFRlbVkzV3JrTmlHVDBT?=
 =?utf-8?B?VDBsWTNEWVhGV3lDT2NjOHlRa3JoWFB3aW1OTkVQbDRHMFZRQnRJOENUUm9z?=
 =?utf-8?B?b0lQeEp3U2FsYUZYYWtmU2RteW4wQi9pTjB4NDJZTVJ1allzRGxOMTJQMnBW?=
 =?utf-8?B?cWtyK1NzS3ZPTE1vNUhranYrdFYrTGNOUDVPUFRYZmVESFVwbzBERGVSbEhr?=
 =?utf-8?B?bVJ3UitSci8zR212YTFtVHk5V0QycUQrdXZYa2RUWndjTHlUNHJVSE50Y0d5?=
 =?utf-8?B?bW1rcWNFbUVEckE3TmhndlptMnI1ZnY5akZ4U2R0VHRpRmxYdWJRMDhpUmJI?=
 =?utf-8?B?d0tUSUc3bDdsK3RRSENwSFNiMGRVQy9WVjlzM2tlbStDWStJQTNYY1YraUVq?=
 =?utf-8?B?dVdwK1ZhT2VQY2FQcmF6TFl5TGdpdDVIbjBQTDQzNGdVT0gxVi9MRjNYV3NN?=
 =?utf-8?B?MDRsc0M3RlA4Y0ZLYnQrZHNjZGRkaDBRMWVrbGpiRklCemhYaUhtQjBrb21T?=
 =?utf-8?B?bDZqVnltdXdraGlKMU1pV1ZhaThNbFo1TTFxazRWRjYzVmUydlFXNFRNcUxo?=
 =?utf-8?B?QitoM2RuZkIrYUMzWnFiK0w0dzYzQndydjFaN3ZKdXdETWE1ZFkzaW43RVVW?=
 =?utf-8?B?VVN6bThjVGFYUVA3UE11UzdLeW0zYVRRampZMEppelkrK3ZVNUZNT05jZHZp?=
 =?utf-8?B?R1hnT3JCYStvNGVXanFINHhKSU9EY1lKbnlxTy8rU0NmNHltM0FpeXFYWCtJ?=
 =?utf-8?B?MENxeFZsWk85aUExZ3Q2d3dZaWpPVjFNT1hCb0hkWHFLZjBQb3R0N3AyTmFS?=
 =?utf-8?B?aUVlL3M4WXJsWlY0d3hVMjJqNEpHelp5VDAyYXhxMDE2SDUzWVliejNxL3NG?=
 =?utf-8?B?YnF5S2xhUEV3WWZOZEl2UE9sb2Q1cEsvMHE4Mit1MHZPMWRsUDFLamJ2UFdk?=
 =?utf-8?B?QzVsbGZBa0E1SUlpWGdOSDlJbllBTnkxWUgwVDRkd3pIckhOakZNdXVOSUlS?=
 =?utf-8?B?eTdxTWp4Qzg0cEtDOVYzaHVtay9LMlRjWWVyOFh1TkZ2bjBzV3kzT3lsRDVx?=
 =?utf-8?B?akxLS0llYTNiRTFSV3dhOHpEYlJkNy9xeERJMm9xVFhhaDBHbXI4bE5YRW1K?=
 =?utf-8?B?WE10TE5vYnVGd3Z5dmFEbFNOd1BWRlZyQUFuaUpjRCs2dzZWbk9iZUxSQmtv?=
 =?utf-8?B?RWtJQVpRdEhIcVh5aXQyUnUvNWpKclVqSnZjMTJDN2htM1ZCSDIvK1NuK05T?=
 =?utf-8?B?OEhKMG1wRGNTVzFLdTJIelFtcWpnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63e05700-5427-413f-66a5-08dab1f80e4a
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 17:33:37.8453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cB+FB/ZnlYdZESawiuzcCvrDgLi4Gy5je8wW810Ba7aekYZtoKYJZy/bFLrs0JjJKU/ZsEL9zKHMQe39FPjsnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6227
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19/10/2022 16:07, Vincent Whitchurch wrote:
> On Wed, Oct 19, 2022 at 04:54:12PM +0200, Jon Hunter wrote:
>> [    4.168317] mmc0: Command Queue Engine enabled
>> [    4.176723] mmc0: new HS400 Enhanced strobe MMC card at address 0001
>> [    4.189609] mmcblk0: mmc0:0001 HBG4a2 29.1 GiB
>> [    4.207660] mmc0: running CQE recovery
>> [    4.215332]  mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 p16 p17 p18 p19 p20 p21 p22 p23 p24 p25 p26 p27 p28 p29 p30 p31 p32 p33 p34 p35 p36 p37 p38 p39 p40 p41 p42
>> [    4.249403] mmcblk0boot0: mmc0:0001 HBG4a2 8.00 MiB
>> [    4.255457] mmcblk0boot1: mmc0:0001 HBG4a2 8.00 MiB
>> [    4.262063] mmcblk0rpmb: mmc0:0001 HBG4a2 4.00 MiB, chardev (511:0)
>> ...
>> [    9.034384] ------------[ cut here ]------------
>> [    9.038985] WARNING: CPU: 4 PID: 199 at /mlt/kernel/drivers/mmc/core/block.c:2379 mmc_blk_mq_issue_rq+0x370/0x820
>> [    9.049100] Modules linked in: ip_tables x_tables ipv6
>> [    9.054180] CPU: 4 PID: 199 Comm: kworker/4:1H Not tainted 6.1.0-rc1-00025-gaae703b02f92 #1
>> [    9.062399] Hardware name: NVIDIA Jetson AGX Xavier Developer Kit (DT)
>> [    9.068821] Workqueue: kblockd blk_mq_run_work_fn
>> [    9.073464] pstate: 20400009 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
>> [    9.080318] pc : mmc_blk_mq_issue_rq+0x370/0x820
>> [    9.084872] lr : mmc_blk_mq_issue_rq+0x70/0x820
>> [    9.089382] sp : ffff80000b5b3ad0
>> [    9.092643] x29: ffff80000b5b3ad0 x28: ffff00008467a288 x27: 0000000000000014
>> [    9.099733] x26: ffff000082d49000 x25: ffff00008467a240 x24: ffff0000802acad8
>> [    9.106758] x23: ffff0000802aca10 x22: ffff0000802aca00 x21: 0000000000000000
>> [    9.113810] x20: ffff000080fa0800 x19: ffff800009824000 x18: 0000000000000080
>> [    9.120858] x17: 0000000000000000 x16: f8ffffffffffffff x15: 000000000000029a
>> [    9.127918] x14: 0000000000000000 x13: 0000000000002000 x12: 0000000000000000
>> [    9.134980] x11: 0000000106d66000 x10: 0000000000000001 x9 : 0000000000000002
>> [    9.142066] x8 : 0000000000000009 x7 : ffff000084650118 x6 : 00000000000000ff
>> [    9.149171] x5 : ffff000084650000 x4 : 0000000000403082 x3 : ffffffffffffca4a
>> [    9.156240] x2 : 0000000000000000 x1 : 00000000ffffffe7 x0 : 0000000000000009
>> [    9.163276] Call trace:
>> [    9.165737]  mmc_blk_mq_issue_rq+0x370/0x820
>> [    9.169993]  mmc_mq_queue_rq+0x134/0x270
>> [    9.173900]  blk_mq_dispatch_rq_list+0x14c/0x8d8
>> [    9.178500]  blk_mq_do_dispatch_sched+0x330/0x348
>> [    9.183169]  __blk_mq_sched_dispatch_requests+0xd4/0x170
>> [    9.188440]  blk_mq_sched_dispatch_requests+0x34/0x70
>> [    9.193456]  __blk_mq_run_hw_queue+0x58/0xb0
>> [    9.197666]  blk_mq_run_work_fn+0x20/0x28
>> [    9.201673]  process_one_work+0x1e0/0x348
>> [    9.205672]  worker_thread+0x48/0x410
>> [    9.209326]  kthread+0xf4/0x110
>> [    9.212462]  ret_from_fork+0x10/0x20
>> [    9.216025] ---[ end trace 0000000000000000 ]---
>> [    9.220899] I/O error, dev mmcblk0, sector 12624 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
>> [   11.500035] I/O error, dev mmcblk0, sector 16720 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
>> [   13.804317] I/O error, dev mmcblk0, sector 20816 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
>> [   16.104063] I/O error, dev mmcblk0, sector 24912 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
>>
>>
>> Reverting this makes the issue go away. Please let me know if you have any thoughts on this.
> 
> Could you please test if the below change fixes it?  Thank you.
> 
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index fefaa901b50f..3661ba0bbc87 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -48,6 +48,7 @@ static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
>   	case REQ_OP_DRV_OUT:
>   	case REQ_OP_DISCARD:
>   	case REQ_OP_SECURE_ERASE:
> +	case REQ_OP_WRITE_ZEROES:
>   		return MMC_ISSUE_SYNC;
>   	case REQ_OP_FLUSH:
>   		return mmc_cqe_can_dcmd(host) ? MMC_ISSUE_DCMD : MMC_ISSUE_SYNC;


Thanks, that does appear to fix the problem.

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic