Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <5887691.lOV4Wx5bFT@kreacher> <166611112152.2353171.9661532286339710942.b4-ty@bootlin.com>
 <CAJZ5v0jh9g8fKAoymwv1UeUqtX7EcU3JkgMHsQWZSHngyQUFQg@mail.gmail.com> <Y1A/AZmfTI6hr3RZ@mail.local>
In-Reply-To: <Y1A/AZmfTI6hr3RZ@mail.local>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 19 Oct 2022 20:20:48 +0200
Message-ID: <CAJZ5v0hiVLroUiRv-96uyiMgj-7-GkJK5yB1O2ei8Q8gVvZPGA@mail.gmail.com>
Subject: Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Zhang Rui <rui.zhang@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Todd Brandt <todd.e.brandt@linux.intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rtc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 19, 2022 at 8:16 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On 19/10/2022 18:13:43+0200, Rafael J. Wysocki wrote:
> > On Tue, Oct 18, 2022 at 6:39 PM Alexandre Belloni
> > <alexandre.belloni@bootlin.com> wrote:
> > >
> > > On Tue, 18 Oct 2022 18:09:31 +0200, Rafael J. Wysocki wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > >
> > > > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration
> > > > ordering issue") overlooked the fact that cmos_do_probe() depended
> > > > on the preparations carried out by cmos_wake_setup() and the wake
> > > > alarm stopped working after the ordering of them had been changed.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/1] rtc: rtc-cmos: Fix wake alarm breakage
> > >       commit: 0782b66ed2fbb035dda76111df0954515e417b24
> >
> > Thank you!
> >
> > However, there is a build fix on top of this which has just been posted:
> >
> > https://lore.kernel.org/linux-acpi/2677035.mvXUDI8C0e@kreacher/
> >
> > Sorry about breaking it again.
>
> I had that in rtc-fixes:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-fixes

Looks good, thanks!