Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1659093rwi; Wed, 19 Oct 2022 13:38:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6CXhNxABmsda75I5PfH/hwCj2Vy/4M7noaFDiaQkVT6mAq5QVK1M60LW8od0KtI0m3CPRS X-Received: by 2002:aa7:d80b:0:b0:45f:b9ed:6e3c with SMTP id v11-20020aa7d80b000000b0045fb9ed6e3cmr1182686edq.22.1666211910209; Wed, 19 Oct 2022 13:38:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666211910; cv=none; d=google.com; s=arc-20160816; b=KBK6b8YHP3TZZ4l18XJTiAeZL6cZqBxk4FCCRb6O7pMkDmqc+FE5BhzpwvAxeQCPNT Pfc3YLd6NpAw1+4yX3VhBTJKFrBDN7iDyJzQxvKaE94Qv7ukxF36eGpcxkBmYu6h2FqH 26pb7PhDWtngyZHLQh+Ot0aVhnFy7+JfXygQHDVBnqPA8INe/QQ0JpxIw0wJhcwaf8/W rbOe3i8N0HvYOoQS60wH92VPT+lXlpmZJSFeorYP72QcPA8HCRL2z7apCNavwevnmeSJ 0/3KCLkcj2vVDXL3PsTgZOxcuHIUvaHnL4+3Z1uz07EVzrKcBAnTxe2Cl6CR1sk6FYEo 31fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=DE+pC1xoa6jKzJgz9ssD3qXjzyl5nNC8ht+oyc3rAWU=; b=vRlKX++uV+6tFzVRT0Dpv4hVk8BgJdaIVv9qztOhntyWnerC7GNuhbchG6Kqn8LfHS fjRlQlUQbTo4okYbHzRHwo6BkO3Kulzr9B1IdcT9m9Wq4B/S/cjo4O4V2tPxc/gdIAAN zrFLJZ9aVDm4U3NeYavtY9kWwUoRnpJInsqWWCLGq+6aLk1yIo2UrBvv9km+l47jPOAJ r1H7T0nnCC92oWoHOX1invET6ALj+QNC1b+KXSse8gdADui8B/R1d5ezYkCDtnOJxs7z 3xna015vcisXDz82k2t7gFIUSUerTcCaebQkvY22siDcBfyWfOhjF62NKT/89BBQBuC5 YTug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=yUHzem6s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a056402090d00b00458b71488bdsi17770308edz.388.2022.10.19.13.38.02; Wed, 19 Oct 2022 13:38:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=yUHzem6s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbiJSTtZ (ORCPT + 99 others); Wed, 19 Oct 2022 15:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230283AbiJSTtW (ORCPT ); Wed, 19 Oct 2022 15:49:22 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D9E81003 for ; Wed, 19 Oct 2022 12:49:20 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id o21so15854919ple.5 for ; Wed, 19 Oct 2022 12:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DE+pC1xoa6jKzJgz9ssD3qXjzyl5nNC8ht+oyc3rAWU=; b=yUHzem6sIADgl8VuoSM7oJkVqb+B5GHyJmRtSkk0r+NAk9gYc798fS+bCXMzJ0sPqz gvhK1tXz6VWvJO1Aut71+PSwDju5EPluhhqCTyB9zoRDkmzWhYIiZJNVrEjApe8DORn8 KcevE4cLtP5SHAZpXPXIFh4xUNN7j9hoL5P4wBDwwUNG4OFARL04b8gmHZGE5jbZZ/Ph AtWzdmd0UHVDDpgIdbRXMTQwQmEG7tr4dm2DJk2KynNJ1xzwv826mP1LceJ3JBfgdFYx PAvM2DUd4lH0lArT6GV6RokgNsDgwR1/9x8oR9ELO347v6rLm6YNmMTkiseODRtqZ+/3 0WgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DE+pC1xoa6jKzJgz9ssD3qXjzyl5nNC8ht+oyc3rAWU=; b=n32eOhGyU24la3HOTrM/ag4w4zHE1gYqTLTLNB+bc9HJWt7r5eAKMk5V9afvTa2rbB m8gRTCHDwjeD3yX+otH+rCKGluKQY95+EDjvHvbztBfKeNJwBzAaZ7ASgh/WPh3qi8+6 YhPh/WOXROTTsuMHDcZUFqpwDE3A/6eS1SMlWGaanh69xtY0uJ5MStjH4wiQ7nS2SeWl QpnpmoO/iB/vaOmRCatA5piQlYqYJ2ZQ3ltGle/9jd3kB5iENAgK/HuES4r4Z6Rihz7t /8Qm/KDt/3h4pyvvTGTmnzZkVyKtJYILgrkcDtTGqWWuubgtlOg8+IPm8jevxPt3hRhU UpRQ== X-Gm-Message-State: ACrzQf3SUa/kVVRjK5knn0VpzRJk4hsoYZnwAUH2mV9DykgnnV9TI4fD b27dnrYoXFyOb+YcZz8Om2qhMye1cRMvxUii X-Received: by 2002:a17:90a:a088:b0:20d:67b7:546d with SMTP id r8-20020a17090aa08800b0020d67b7546dmr12127533pjp.6.1666208959487; Wed, 19 Oct 2022 12:49:19 -0700 (PDT) Received: from [127.0.0.1] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id 72-20020a62194b000000b00562362dbbc1sm11531811pfz.157.2022.10.19.12.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 12:49:19 -0700 (PDT) From: Jens Axboe To: Harshit Mogalapalli Cc: Pavel Begunkov , linux-kernel@vger.kernel.org, vegard.nossum@oracle.com, io-uring@vger.kernel.org, harshit.m.mogalapalli@gmail.com, syzkaller In-Reply-To: <20221019171218.1337614-1-harshit.m.mogalapalli@oracle.com> References: <20221019171218.1337614-1-harshit.m.mogalapalli@oracle.com> Subject: Re: [PATCH] io_uring/msg_ring: Fix NULL pointer dereference in io_msg_send_fd() Message-Id: <166620895849.131373.4257100476341517725.b4-ty@kernel.dk> Date: Wed, 19 Oct 2022 12:49:18 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-d9ed3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Oct 2022 10:12:18 -0700, Harshit Mogalapalli wrote: > Syzkaller produced the below call trace: > > BUG: KASAN: null-ptr-deref in io_msg_ring+0x3cb/0x9f0 > Write of size 8 at addr 0000000000000070 by task repro/16399 > > CPU: 0 PID: 16399 Comm: repro Not tainted 6.1.0-rc1 #28 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2.el7 > Call Trace: > > dump_stack_lvl+0xcd/0x134 > ? io_msg_ring+0x3cb/0x9f0 > kasan_report+0xbc/0xf0 > ? io_msg_ring+0x3cb/0x9f0 > kasan_check_range+0x140/0x190 > io_msg_ring+0x3cb/0x9f0 > ? io_msg_ring_prep+0x300/0x300 > io_issue_sqe+0x698/0xca0 > io_submit_sqes+0x92f/0x1c30 > __do_sys_io_uring_enter+0xae4/0x24b0 > .... > RIP: 0033:0x7f2eaf8f8289 > RSP: 002b:00007fff40939718 EFLAGS: 00000246 ORIG_RAX: 00000000000001aa > RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f2eaf8f8289 > RDX: 0000000000000000 RSI: 0000000000006f71 RDI: 0000000000000004 > RBP: 00007fff409397a0 R08: 0000000000000000 R09: 0000000000000039 > R10: 0000000000000000 R11: 0000000000000246 R12: 00000000004006d0 > R13: 00007fff40939880 R14: 0000000000000000 R15: 0000000000000000 > > Kernel panic - not syncing: panic_on_warn set ... > > [...] Applied, thanks! [1/1] io_uring/msg_ring: Fix NULL pointer dereference in io_msg_send_fd() (no commit info) Best regards, -- Jens Axboe