Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6650b077-1900-a6e6-755e-a84282e5fd13@linexp.org>
Date:   Wed, 19 Oct 2022 21:53:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5 01/33] thermal/of: Rework the thermal device tree
 initialization
Content-Language: en-US
To:     Ido Schimmel <idosch@idosch.org>
Cc:     daniel.lezcano@linaro.org, rafael@kernel.org, rui.zhang@intel.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        khilman@baylibre.com, abailon@baylibre.com, lukasz.luba@arm.com,
        broonie@kernel.org, damien.lemoal@opensource.wdc.com,
        heiko@sntech.de, hayashi.kunihiko@socionext.com,
        mhiramat@kernel.org, talel@amazon.com, thierry.reding@gmail.com,
        digetx@gmail.com, jonathanh@nvidia.com, anarsoul@gmail.com,
        tiny.windzz@gmail.com, baolin.wang7@gmail.com,
        f.fainelli@gmail.com, bjorn.andersson@linaro.org,
        mcoquelin.stm32@gmail.com, glaroque@baylibre.com,
        miquel.raynal@bootlin.com, shawnguo@kernel.org,
        niklas.soderlund@ragnatech.se, matthias.bgg@gmail.com,
        j-keerthy@ti.com, Amit Kucheria <amitk@kernel.org>
References: <20220804224349.1926752-1-daniel.lezcano@linexp.org>
 <20220804224349.1926752-2-daniel.lezcano@linexp.org>
 <Y05/8JUU+3kLCZvb@shredder>
From:   Daniel Lezcano <daniel.lezcano@linexp.org>
In-Reply-To: <Y05/8JUU+3kLCZvb@shredder>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi Ido,

On 18/10/2022 12:29, Ido Schimmel wrote:
> On Fri, Aug 05, 2022 at 12:43:17AM +0200, Daniel Lezcano wrote:
>> +struct thermal_zone_device *thermal_of_zone_register(struct device_node *sensor, int id, void *data,
>> +						     const struct thermal_zone_device_ops *ops)
>> +{
>> +	struct thermal_zone_device *tz;
>> +	struct thermal_trip *trips;
>> +	struct thermal_zone_params *tzp;
>> +	struct thermal_zone_device_ops *of_ops;
>> +	struct device_node *np;
>> +	int delay, pdelay;
>> +	int ntrips, mask;
>> +	int ret;
>> +
>> +	of_ops = kmemdup(ops, sizeof(*ops), GFP_KERNEL);
>> +	if (!of_ops)
>> +		return ERR_PTR(-ENOMEM);
>> +	
>> +	np = of_thermal_zone_find(sensor, id);
>> +	if (IS_ERR(np)) {
>> +		pr_err("Failed to find thermal zone for %pOFn id=%d\n", sensor, id);
>> +		return ERR_CAST(np);
>> +	}
>> +
>> +	trips = thermal_of_trips_init(np, &ntrips);
>> +	if (IS_ERR(trips)) {
>> +		pr_err("Failed to find trip points for %pOFn id=%d\n", sensor, id);
>> +		return ERR_CAST(trips);
>> +	}
>> +
>> +	ret = thermal_of_monitor_init(np, &delay, &pdelay);
>> +	if (ret) {
>> +		pr_err("Failed to initialize monitoring delays from %pOFn\n", np);
>> +		goto out_kfree_trips;
>> +	}
>> +
>> +	tzp = thermal_of_parameters_init(np);
>> +	if (IS_ERR(tzp)) {
>> +		ret = PTR_ERR(tzp);
>> +		pr_err("Failed to initialize parameter from %pOFn: %d\n", np, ret);
>> +		goto out_kfree_trips;
>> +	}
>> +
>> +	of_ops->get_trip_type = of_ops->get_trip_type ? : of_thermal_get_trip_type;
>> +	of_ops->get_trip_temp = of_ops->get_trip_temp ? : of_thermal_get_trip_temp;
>> +	of_ops->get_trip_hyst = of_ops->get_trip_hyst ? : of_thermal_get_trip_hyst;
>> +	of_ops->set_trip_hyst = of_ops->set_trip_hyst ? : of_thermal_set_trip_hyst;
>> +	of_ops->get_crit_temp = of_ops->get_crit_temp ? : of_thermal_get_crit_temp;
>> +	of_ops->bind = thermal_of_bind;
>> +	of_ops->unbind = thermal_of_unbind;
>> +
>> +	mask = GENMASK_ULL((ntrips) - 1, 0);
>> +
>> +	tz = thermal_zone_device_register_with_trips(np->name, trips, ntrips,
>> +						     mask, data, of_ops, tzp,
>> +						     pdelay, delay);
>> +	if (IS_ERR(tz)) {
>> +		ret = PTR_ERR(tz);
>> +		pr_err("Failed to register thermal zone %pOFn: %d\n", np, ret);
>> +		goto out_kfree_tzp;
>> +	}
>> +
>> +	ret = thermal_zone_device_enable(tz);
>> +	if (ret) {
>> +		pr_err("Failed to enabled thermal zone '%s', id=%d: %d\n",
>> +		       tz->type, tz->id, ret);
>> +		thermal_of_zone_unregister(tz);
>> +		return ERR_PTR(ret);
>> +	}
>> +
>> +	return tz;
>> +
>> +out_kfree_tzp:
>> +	kfree(tzp);
>> +out_kfree_trips:
>> +	kfree(trips);
>> +
>> +	return ERR_PTR(ret);
>> +}
>> +EXPORT_SYMBOL_GPL(thermal_of_zone_register);
> 
> Daniel, I started seeing these memory leaks [1] since commit
> 613ed3f67609 ("hwmon: pm_bus: core: Switch to new of thermal API").
> Seems to be fixed by the following patch [2].
> 
> Do you already have a patch for this issue or should I submit it?

Thanks for reporting the issue. If you can submit it, that would be great