Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 22:11:28 +0200
From:   Wolfram Sang <wsa-dev@sang-engineering.com>
To:     Jason Gerecke <killertofu@gmail.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Ping Cheng <pinglinux@gmail.com>,
        "Tobita, Tatsunosuke" <tatsunosuke.tobita@wacom.com>,
        Jason Gerecke <jason.gerecke@wacom.com>,
        Ping Cheng <ping.cheng@wacom.com>
Subject: Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls
Message-ID: <Y1BZ8CjSnrKi+Yos@shikoro>
Mail-Followup-To: Wolfram Sang <wsa-dev@sang-engineering.com>,
        Jason Gerecke <killertofu@gmail.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Ping Cheng <pinglinux@gmail.com>,
        "Tobita, Tatsunosuke" <tatsunosuke.tobita@wacom.com>,
        Jason Gerecke <jason.gerecke@wacom.com>,
        Ping Cheng <ping.cheng@wacom.com>
References: <20220718153448.173652-1-jason.gerecke@wacom.com>
 <20220803145937.698603-1-jason.gerecke@wacom.com>
 <CAHp75Vd6yEctJoNT6TpJ1+h4ZQckyLsaUSeSCV4MHqg+LUDkcg@mail.gmail.com>
 <CANRwn3TutF6skHQHk08dFUa8gLMVGxui_QN7YK6nDacSpRHtLg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BGtONydHGv42/zAu"
Content-Disposition: inline
In-Reply-To: <CANRwn3TutF6skHQHk08dFUa8gLMVGxui_QN7YK6nDacSpRHtLg@mail.gmail.com>
Precedence: bulk


--BGtONydHGv42/zAu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > I believe you need to create a coccinelle script and run it over the
> > kernel source tree and then create a patch out of it.
>=20
> This would definitely be necessary to unify all callers to using
> unsigned variables rather than just swapping which callers generate
> the pointer-sign warnings.

I am all for using u8 because this is the proper type.

Yet, if we touch this function argument, I'd also like to remove all
inconsistencies once and for all. Removing some warnings here and add
some there is not a good choice IMO. However, how to do this switch of
types cleanly without too much churn, I sadly have no good idea yet.


--BGtONydHGv42/zAu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmNQWewACgkQFA3kzBSg
KbZ3Gw//crNGkl16EK/1GS4zVfBem5hUueVH2xbQhi5++pK1z+ykw7ap2dqC5WC6
kOJjK8nXpGaQJS4wPatM8jYP0uosEd9fpoZG3ULYnnzH6BYdzk/BPgpPQ/0nUaXp
I63fhBeafHComQkTzfqTZo//qWQkp3DVtyBrA6rfiQyVz8afJOer/n2T772pA3SP
kYTGL+A6KZQSztTkezKOJYWGPoUXupCLzVgPzonALtiZivgkiGS+OT40JHmPk6GA
IkvuqE6DlUw5qMx3rTz+oYBO7mijCVms4eBjlzh88vEjmq/UdLh+3RQl3gaps6fh
iNa2F+BJCQwMJt9NDvvLYeDa68VXNbcSvLkDIJXXP4WzBgkaW3wMJ++sl+f7Q+hB
/jjkiSOLf4HkJl4ocbWkZwRrqJzuqQWJezkdyleK7rREQ14uSEDoyT66znrmQapF
maiyP+cv1903PnVdKCq2fwg3q8gS827DI2zmXWFKdPAfT4e0Uvggb4Wa7icJqR1B
18As6Aews6zo3Dr9cJXgQE7oXz2r0NHQok1+pmXPaMmhGBlFvAoxEO0Ir72uK898
C6dC1qdBtD9ET9JIL16R5N0oaIWfksXlosPp323Y5J5k1dBKAk6emsNKnNYpdJCw
bH/876TSZ98j2PHNJUY4MJzneKEs3zNAAw6ZBQRFoNRf93n4rrM=
=gNnd
-----END PGP SIGNATURE-----

--BGtONydHGv42/zAu--