Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <2d22d0ac-ecc8-1c05-fb63-b0bd0569036c@roeck-us.net>
Date:   Wed, 19 Oct 2022 15:50:24 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-hwmon@vger.kernel.org, jdelvare@suse.com,
        linux-kernel@vger.kernel.org
References: <20221019214108.220319-1-martin.blumenstingl@googlemail.com>
 <0d1b4fed-7ded-88fc-3c37-4f859fc505c1@roeck-us.net>
 <CAFBinCAutvvNzSD7HXfMzLOg-NZ3ubifjtHzC9yURe=BZJQEiA@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] hwmon: (jc42) Restore the min/max/critical temperatures
 on resume
In-Reply-To: <CAFBinCAutvvNzSD7HXfMzLOg-NZ3ubifjtHzC9yURe=BZJQEiA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/19/22 15:03, Martin Blumenstingl wrote:
> Hi Guenter,
> 
> Thank you for the quick feedback!
> 
> On Wed, Oct 19, 2022 at 11:51 PM Guenter Roeck <linux@roeck-us.net> wrote:
> [...]
>>> +     if (data->valid || data->temp[t_min])
>>
>> This contradicts "with applying the previous values by only configuring
>> them if they are known valid". It explicitly applies the values if they
>> are marked as not valid, and it also applies the values if they are 0
>> (I don't really see the value of doing that).
>>
>> Sorry, I don't understand the logic. Did you mean to use "&&" instead
>> of "||" ?
> My understanding is that that:
> 1) data->valid = true is only set in jc42_update_device() (which is
> only called when reading back the values from the registers)
> 2) jc42_write() can write values without setting data->value = true
> In other words: if jc42_read() is never called but jc42_write() is
> then we still have some setting to apply while data->valid is false.
> Whether that's possible in reality is something that I'm not sure
> about.
> 

The above only means that the code is not optimized for the problem
you are trying to solve.

- Calling jc42_update_device() would solve the valid problem.
- Calling jc42_update_device() from the write function would
   solve it as well.

Relying on a previous call to the write function is most definitely
wrong.

Also, for optimization, jc42_update_device() should really read the limit
registers only once. The best solution would probably be to convert the
driver to use regmap and let regmap handle the caching.

Guenter

> If your suggestion is to simplify this to use data->valid only then I
> can do that.
> It would be great if you could also comment on whether
> jc42_update_device() should be called from jc42_suspend() to give the
> driver the chance to at least read the data once (and set data->valid)
> if this has not happened before.
> 
> 
> Best regards,
> Martin