Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Xingui Yang <yangxingui@huawei.com>
Cc:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <prime.zeng@hisilicon.com>,
        <kangfenglong@huawei.com>, <john.garry@huawei.com>
Subject: Re: [PATCH] scsi: sd: Update dix config everytime
 sd_revalidate_disk is called
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1h6zzz740.fsf@ca-mkp.ca.oracle.com>
References: <20221019081825.20794-1-yangxingui@huawei.com>
Date:   Wed, 19 Oct 2022 20:18:03 -0400
In-Reply-To: <20221019081825.20794-1-yangxingui@huawei.com> (Xingui Yang's
        message of "Wed, 19 Oct 2022 08:18:25 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NIp3bcqGEgIv86g7CxFf+KPiATmBDgtTsRGMuQlQGiQM7SDKqcRT52uJ+W78?=
 =?us-ascii?Q?TCv+F2c4/ABOq6svQr7UAD6DCSTjC2C0YsU3ep1RSf2nlcCzMTZ34nr7t5Kx?=
 =?us-ascii?Q?wndNNk4Q9XAhxyRayg8h2QOvSCUVyHTah4C6ESKKvjYYC7K3wqzySebHNI+y?=
 =?us-ascii?Q?NWOv15WdOyB716W4JLe063VAWz6/YCnTt/osq6KNRa2hBXCp3lFRwuqEaHA4?=
 =?us-ascii?Q?VMWh8PsDvdD6G66Nq3KdiDAbl3feJT2DCOqbJJPaGj+8j38JkKGuh+WBs4mO?=
 =?us-ascii?Q?bFeaVGQL5HL/tskz7DCNtAy889cBf+83Ys86BuqHTkhqYNEMjOOVuR+vc3QX?=
 =?us-ascii?Q?kNqAonjTjqMxQKxaiaaGW1SzDAUqvjsJOiBmIUbn0aOcRNRZTyTa8U7rVlD9?=
 =?us-ascii?Q?NlT/vPoZvqS5yoFFzfVlku7zRtzVOzH9a59C6kRo4gnPVdkaEXi/ItSGnmmx?=
 =?us-ascii?Q?rHnDYXS1YEatcqUnuXCj0NDlHB+jvfl+ehNSsWh5FfgGWMUBdx21FJYVRCjg?=
 =?us-ascii?Q?JxKu8YM7SVJqVbVgnZxqCs9kVNM8V1JH5CWwB5Jcp34A/vnB48RfzJUqaSNd?=
 =?us-ascii?Q?cs/+9BMQc7hAMV2uj0+SltSF+j7iR1yqQTlyEA5Evxe5SK43AczXkEHHHpL2?=
 =?us-ascii?Q?j4/mIoVous7/ef2STkyLFYx3NSsfTL6ESb6e5CPrUEyIqkzbatsf993/seop?=
 =?us-ascii?Q?1/scL/bs5wrYZeGDGwE8ITOfGsV95HyTh4qye41iU6DpuIluGOYP5LL6c8i1?=
 =?us-ascii?Q?Iu62YCWf3bEM481d2hFkgOzDkm+WRN3TSMqKq8hLf93VIbWdVE08FWTIcrQh?=
 =?us-ascii?Q?QgnioaVeWLpp4IxbDDyjyQq2cnmVZ1FPZWHeR9CkxpHAX/TYJVvP2ghKCmuO?=
 =?us-ascii?Q?2Ek3mdB2LHot+oQMHWw+1gCGvh1NuNLL6nfcFxaiHoLUVe+/nrNEBSahh4yN?=
 =?us-ascii?Q?NiTBcm9+ebrd7rQnL3SGIXDDnvx9BCH1iZvzClfXa8aVE199yI8XsokTU3O2?=
 =?us-ascii?Q?+ntKlLFHk5K2QZbh28T8OFN/U5BrPgyY6azlnE6MqByIxmykg0qKqbUAF9kG?=
 =?us-ascii?Q?8fyxtyO5r/LE/kuLD1ahQvlmG5Jz1in3U5CgduzPXvmT1ITNqhS48glnjga3?=
 =?us-ascii?Q?rF2/BkssY6lIQLeVrpKxCO6wR2jY/IbJbeXMoHwg4idu8hQRGkl5OdsaOAAK?=
 =?us-ascii?Q?ZnTGHYL7BPNuPa52a6MT6768a26PlwMDSkNm3A7TVs1V1JbdtXOyXgeJmfgo?=
 =?us-ascii?Q?BjU83v1PixfJt8AVwTxZRXoNPUE2LPRSfdyy+09cH6NPderDWsriiRbcdjXj?=
 =?us-ascii?Q?Lj1wDKyYOyN2zJUM0XNfbRsRgJZd8TAXdFa4Z132C/ymxqiQ34K5PQ93yRbr?=
 =?us-ascii?Q?I/EMwug7MDQ2FuoZt+80RW8zJlisRL1OncIwvEjPJcssomuVtWciQbMeIxT3?=
 =?us-ascii?Q?a17CpM+BQs4U5UHyyTiLZWobBi+/0deHsgD4jdgiy1nKU4pKoJEHh1/fmNWi?=
 =?us-ascii?Q?+XvQ3Xn2FERL5vn+RhjIKsfN1Hwg7E9PYBpkJJBpSjVl+Lj0cfGrPkdW8EF/?=
 =?us-ascii?Q?AgKp/BXz4RZfdo4EtXLCh+pjRGBDFCuaujCCbe0peppVJuX5tHVpfScv/OcZ?=
 =?us-ascii?Q?ug=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f6cca49-a9d7-4c59-b501-08dab2308f5b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 00:18:06.1729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: drmCaWD30Y6GgIsYzwUmy+Q1wRLgNOW7QTNQUbSA09bp1Hl30YmB1oeOUfG1KKKorVA0iK/fR1Qv77WHbuMf5YD33HTvtZem0Hssty7xcew=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5302
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_13,2022-10-19_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0
 spamscore=0 bulkscore=0 malwarescore=0 mlxlogscore=771 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210200000
X-Proofpoint-GUID: nos3pIJ36RedcNCvkz4Gvn8RXJNqILtK
X-Proofpoint-ORIG-GUID: nos3pIJ36RedcNCvkz4Gvn8RXJNqILtK
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Xingui,

> When the host protection capabilities are 0x77 and a DIF disk is
> connected, the DIX and DIF of the disk are default enabled. Then if
> that DIF disk is reformatted as a non-DIF format, per the currently
> flow, the DIX is kept enabled which is not correct

DIX is orthogonal to DIF and a host property. DIX should not be disabled
just because the disk is no longer formatted with protection
information.

That said, your patch is probably fine. I'll take a closer look
tomorrow.

-- 
Martin K. Petersen	Oracle Linux Engineering