Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp97754rwi; Wed, 19 Oct 2022 18:03:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6AoB13a01PZdLbx2wyaabjpl3e/o6uXKHv1PUx0s/WxMW6UlfHl/CWHlCEdhDUbPcpsbem X-Received: by 2002:a17:902:d4c5:b0:183:6e51:503 with SMTP id o5-20020a170902d4c500b001836e510503mr11213519plg.84.1666227781348; Wed, 19 Oct 2022 18:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666227781; cv=none; d=google.com; s=arc-20160816; b=Cd4U8nirCEEWHJ85BNh6f87HxiuK+UhkK/yCB0FwwaivY6k/IFTc2XGczJYbpuZdX1 JtfjxCChbYhXc4xQK9BUuti0g3q2vlk7IHvJqSG6aqTHhuGGGls8wzQr2td1c7wvUum6 dTmcXfqlspaVEFwvuxJM1TUjnS+9wSmlW/vFFUU2acblQKqfEj8eaEnH6m9yJdgr5boN SJaH/hYe1+L+8IocxzHMHnbpHB6yudFZaEfZn9v1uVuc+jlnya1mNBW6/xgWzLyhwCnG ctmXl7s3ldedLhkKcSJI3/DLyrgqau2yJdN3Y6WC8MDgOaXRm73HW0n8+wbXFeRKPmug C5IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QxOAiLLKnkIwYJBhLx+QPAK34cgnSKgZOm1FUORlp+o=; b=K+Nx/slt22oroTPJdPfDeIweoNUzwbYRuYUvtLnlFI8/9xIDpZ8jkYfa4xAnUlnRax CvG4dh0XY01muFTmg6Xp/oPi+0qwEY+YcTfipIHhBEJ/JPDcJFYrBBYA7lmSZXIjGKdH tU6MMu8F5QULkU8sTZxZcQVDd6H2nBcnhtQ+r3GDN16yh9LbBT11kTymdQaJVK9qiDx+ PgAbEGFGoAgFCWo4KtB1t6RPKqxD88G0rNxK80i/50euUvL3Hd13oey+f3YFxpbLa4dR dSm1k6dIBkUK2SxtfRldd2/kOd+NmOeUb2omRv3S89pdol5oLJG4UdpBMv/7Tlwv+v76 PVtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bOv8LMpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a056a000b8700b00563ad44ddf9si20139169pfj.380.2022.10.19.18.02.36; Wed, 19 Oct 2022 18:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bOv8LMpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbiJTAme (ORCPT + 99 others); Wed, 19 Oct 2022 20:42:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbiJTAmc (ORCPT ); Wed, 19 Oct 2022 20:42:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDFB8196B47; Wed, 19 Oct 2022 17:42:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 832C26101F; Thu, 20 Oct 2022 00:42:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 864F2C433D6; Thu, 20 Oct 2022 00:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666226550; bh=2i2TU/chYRViGs6o0UqmsoDbDk+GHNK2T+VUhf5H6cc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bOv8LMpy1Y9zh6G06dnTU5mzblPLC778VlPDn+bWEGfA2zN+ZXqnXAxjHxIYLPGrs lG9mXXAyuW8ITSiuKhGS6+x0PWYlpXE96lQUSVc9zuYhdq20/B1lIxpP6keBK4r5nf CzNUHvTtzP9uIlTjJ7J0T6PpfDfFUTUZjLV2xrzsNPRBfvJLbIJU4WeKagflSRzIkB 7XETlxj9LMxLWqV2KBEPqydSDDU3doYGScAaDYe78a8Q5vw9Ce9UKvhu8lnXt4oXoL If1SsaqWC8fznztyagx7l3N/Z0pEVLjnY44L/c76m4DmJTNUwRHc83mkBiN8am8d5O ZRkC5LFdWsCTQ== Date: Wed, 19 Oct 2022 17:42:29 -0700 From: Jakub Kicinski To: Alexandru Tachici Cc: , , , , , , Subject: Re: [net-next] net: ethernet: adi: adin1110: Fix notifiers Message-ID: <20221019174229.5faaaaea@kernel.org> In-Reply-To: <20221019101750.8978-1-alexandru.tachici@analog.com> References: <20221019101750.8978-1-alexandru.tachici@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Oct 2022 13:17:50 +0300 Alexandru Tachici wrote: > ADIN1110 was registering netdev_notifiers on each device probe. > This leads to warnings/probe failures because of double registration > of the same notifier when to adin1110/2111 devices are connected to > the same system. > > Move the registration of netdev_notifiers in module init call, > in this way multiple driver instances can use the same notifiers. > > Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support") > Signed-off-by: Alexandru Tachici Could you please repost with [PATCH net] as the subject prefix (the change you're fixing has made its way to Linus's tree by now so you need to target the tree for fixes [1]), and please CC Lennart since he co-developed the original change. [1] https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in