Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221018100132.355393-1-zys.zljxml@gmail.com>
In-Reply-To: <20221018100132.355393-1-zys.zljxml@gmail.com>
From:   Ming Lei <ming.lei@redhat.com>
Date:   Thu, 20 Oct 2022 09:26:12 +0800
Message-ID: <CAFj5m9L-=DL-bB9iKRkAdVB+Jjdb5LaF12K1hfj5SCKmii1gXw@mail.gmail.com>
Subject: Re: [PATCH] ublk_drv: use flexible-array member instead of
 zero-length array
To:     zys.zljxml@gmail.com
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yushan Zhou <katrinzhou@tencent.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 18, 2022 at 6:02 PM <zys.zljxml@gmail.com> wrote:
>
> From: Yushan Zhou <katrinzhou@tencent.com>
>
> Eliminate the following coccicheck warning:
> ./drivers/block/ublk_drv.c:127:16-19: WARNING use flexible-array member instead
>
> Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>
> ---
>  drivers/block/ublk_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 2651bf41dde3..5afce6ffaadf 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -124,7 +124,7 @@ struct ublk_queue {
>         bool force_abort;
>         unsigned short nr_io_ready;     /* how many ios setup */
>         struct ublk_device *dev;
> -       struct ublk_io ios[0];
> +       struct ublk_io ios[];
>  };
>
>  #define UBLK_DAEMON_MONITOR_PERIOD     (5 * HZ)

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming