Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5a7c385-4155-af0c-ed51-865f274fa030@infradead.org>
Date:   Wed, 19 Oct 2022 18:54:57 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] of: fix repeated words in comments
Content-Language: en-US
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     Jilin Yuan <yuanjilin@cdjrlc.com>, robh+dt@kernel.org,
        frowand.list@gmail.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221019130200.60460-1-yuanjilin@cdjrlc.com>
 <9fb4c010-b465-e908-6868-d9e493a9688f@infradead.org>
 <Y1Cm2Hvf7W7NxVzk@mit.edu>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <Y1Cm2Hvf7W7NxVzk@mit.edu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/19/22 18:39, Theodore Ts'o wrote:
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>>
>> On 10/19/22 06:02, Jilin Yuan wrote:
>>> Delete the redundant word 'of'.
>>>
>>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>>> ---
>>>  drivers/of/device.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>>> index 8cefe5a7d04e..16c7e5a2a868 100644
>>> --- a/drivers/of/device.c
>>> +++ b/drivers/of/device.c
>>> @@ -19,7 +19,7 @@
>>>  
>>>  /**
>>>   * of_match_device - Tell if a struct device matches an of_device_id list
>>> - * @matches: array of of device match structures to search in
>>> + * @matches: array of device match structures to search in
>>
>> Hi,
>> Rob has already explained this at least 2 times.
>>
>> The second "of" is "open firmware".
>> I would write it
>>               array of OF device match structures to search in
>> :)
> 
> Actually, I'd probably do something like
> 
>     	     array of Open Firmware (OF) device match structures...

Sure, that's good.

> This is the first place in that file (at least in a comment) where OF
> gets used, and I've always been a big fan of using the fully expanded
> acronym before using the acronym form.  Remember, PCMCIA stands for
> People Can't Memorize Computer Industry Acronyms.  :-)
> 
> (Actually, it's Personal Computer Memory Chip Industry Association,

                                           Card International Association :)

> but most people don't know that, because using acronyms without
> defining them first makes you feel like you're an "insider".  :-)


-- 
~Randy