Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp208626rwi; Wed, 19 Oct 2022 20:07:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6UqYFBEDkRbh74pt+WqLGgWHrI0i4kdV5V1Y47NxVv/GVmSqD7LRFwJvwdCfmfqZnNtL1u X-Received: by 2002:a17:907:c78e:b0:78d:138a:ec4b with SMTP id tz14-20020a170907c78e00b0078d138aec4bmr9130467ejc.381.1666235238297; Wed, 19 Oct 2022 20:07:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666235238; cv=none; d=google.com; s=arc-20160816; b=E84gZejx2GaXqpBm6xJEikplbR744GFMCioCF5+0wN9QvTg3SNhkTEUS2rcL2dA5RY 1dDEocrJgs9pYL9wigHiNBejqM9w4A3wv5H1dzEjND0VtjcJlfRxMdPWXmZIbLKGPkkp qpmNkDhKENC7ZRPw9Kd/Y+Htuv2vTPTRhh+ZWBMeICdkj7va4TgYsiTOEV89VqALmqXa ie8UmgryPaQr2yaRLfPpL80pIUZLnOewhZ0Dxe3Xz/jDjHznz7ed94flagQbtqefkVFq PovlkdJxn+SujDHXSaWHbZjB23EjAGbA3bydt6xHHGn+c7qGf1FbboNUq61PPsSP42g+ 3dAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=a2OClsHKpo3Tjp4QxjNEiYIi/AAsotytmBhfVU47Xe0=; b=VVqXjxgW31zuzX6ONdZx2nmw2xfM4G9+/BcCcNT0VugL3Kb5oA5Vw+J6d8Uuhcz6jg 9egoNEsgFrjEHXn9gRsEFWjX6SjaplOi/Ai8QjmAvB/KFMiZxz4j/Cusgz9WFAI9y0qQ kqWv7MUKRum/R6/HIZMKWBBVFtRP/cnkecQcCH6GkE3RMTFlQVY53c8DV9fE9CZFLrk0 IRzRuVKKTcbq7oXYZaNwAuFzq97zcr3WgK1DDGnErfRwOPAfr16buDvXwabdb+pty/SD o/gr/AYNUQiXUGh5tMW+uAtvsCV3BvIomJmH3UPT4BG2cDO7cYzJR9FL6m8SE4KKLZZd jKyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mKGgw3O4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu13-20020a170906eecd00b0078db3556bddsi17403299ejb.804.2022.10.19.20.06.51; Wed, 19 Oct 2022 20:07:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mKGgw3O4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbiJTDEj (ORCPT + 99 others); Wed, 19 Oct 2022 23:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbiJTDEf (ORCPT ); Wed, 19 Oct 2022 23:04:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E599FDDA; Wed, 19 Oct 2022 20:04:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2BF3EB8264A; Thu, 20 Oct 2022 03:04:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DDDBC433D6; Thu, 20 Oct 2022 03:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666235060; bh=OBbPh3uuOP84WsLDpOq6PnPUi4rGs/kimwF5mglmUNE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mKGgw3O4VQFvQM2V9wntuEFr60/7HP602gYW3NSZ5+K60G0ukvwNUpXEf96bixLp6 xnqTPM48Klh35EiPRaYV9DREN0upjpleSCTsEYDJn2PcyyPqV63UQ+F7JZMl8jMqFf k2zeyrrRKmz9YylbSe6ALa/IDXxKRoNpYG4lOG8q7J6NxheGwAVy082D/Aca1MqaTX 8QhPgtcoZowNHhNc9pOo6gaTCH/I2XfPMOZDj2T1ifKmGybi870zvD+1LMJmwV5/xi dRqeBPwCum+noCjvU5eZJW5HvtjUC1Tw8RprfTstEDx9sfeEiCscQqywDfYnbmoWXF qNkzqHPrDp56Q== Date: Wed, 19 Oct 2022 20:04:19 -0700 From: Jakub Kicinski To: Xin Long Cc: syzbot , andrew@lunn.ch, bagasdotme@gmail.com, davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, linux@rempel-privat.de, lkp@intel.com, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] general protection fault in pse_prepare_data Message-ID: <20221019200419.45f2c063@kernel.org> In-Reply-To: References: <00000000000044139d05eb617b1c@google.com> <20221019153018.2ca0580d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Oct 2022 22:25:47 -0400 Xin Long wrote: > > Yeah, looking at ethtool internals - info can be NULL :( > It seems that eeprom_prepare_data() doesn't check info before > accessing info->extack either. Good catch, looks like that one dumps as well! Perhaps we should require netdevsim support for all new commands going forward :S Otherwise this code is hard for syzbot to exercise.