Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <effb4a2a-2bdd-a4b7-f6db-948666515996@kernel.org>
Date:   Thu, 20 Oct 2022 07:29:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH -next] tty: hvc: make hvc_rtas_dev static
Content-Language: en-US
To:     ruanjinjie <ruanjinjie@huawei.com>, gregkh@linuxfoundation.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20221019064412.3759874-1-ruanjinjie@huawei.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20221019064412.3759874-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19. 10. 22, 8:44, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
> not declared. Should it be static?

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
>   drivers/tty/hvc/hvc_rtas.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
> index e8b8c645482b..184d325abeed 100644
> --- a/drivers/tty/hvc/hvc_rtas.c
> +++ b/drivers/tty/hvc/hvc_rtas.c
> @@ -26,7 +26,7 @@
>   #include "hvc_console.h"
>   
>   #define hvc_rtas_cookie 0x67781e15
> -struct hvc_struct *hvc_rtas_dev;
> +static struct hvc_struct *hvc_rtas_dev;
>   
>   static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
>   static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;

-- 
js
suse labs