Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Y06yiBaluz6X0C4G@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net>
 <c3c211c1c99cd19f86fb801576c55b2ae2216c6f.camel@perches.com>
In-Reply-To: <c3c211c1c99cd19f86fb801576c55b2ae2216c6f.camel@perches.com>
From:   Tanju Brunostar <tanjubrunostar0@gmail.com>
Date:   Thu, 20 Oct 2022 07:08:18 +0100
Message-ID: <CAHJEyKXnSdgzGVaFX6ayU3DusETOLZRcpKJJ9ZO_76ofbBTacA@mail.gmail.com>
Subject: Re: [PATCH] staging: rts5208: Replace instances of udelay by usleep_range
To:     Joe Perches <joe@perches.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 20, 2022 at 5:40 AM Joe Perches <joe@perches.com> wrote:
>
> On Tue, 2022-10-18 at 14:04 +0000, Tanjuate Brunostar wrote:
> > Replace the use of udelay by usleep_range as suggested by checkpatch:
> >
> > CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
> > +               udelay(30);
> []
> > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> []
> > @@ -3235,7 +3235,7 @@ static int ms_write_multiple_pages(struct rtsx_chip *chip, u16 old_blk,
> >                       return STATUS_FAIL;
> >               }
> >
> > -             udelay(30);
> > +             usleep_range(30, 30);
>
> >This isn't useful.  Please read the Documentation/timers.

Yes I read the documentation and realized the changes were not necessary