Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 10:41:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Mikko Perttunen <mperttunen@nvidia.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Thierry Reding <treding@nvidia.com>
Subject: drivers/gpu/host1x/context.c:77 host1x_memory_context_list_init()
 warn: missing error code 'err'
Message-ID: <202210201547.ejolabSg-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KHoOQUyLZDqa23E1Uzhjrqq36e25WYhB9yCSV75EsbZRzq5KGnxZcVM03+te?=
 =?us-ascii?Q?2jrV7VZa74FhT5J5QThq5QJoURH8Jq7G5Z8o6UvLArSbe+JfJOUCebUkjdiP?=
 =?us-ascii?Q?ppmkaTje8tQB9HkrfMgVvQyBi76BDvy2qLs2DujeO2HhPZWnMvUKCF8NGCKO?=
 =?us-ascii?Q?YiZHRm7ONl41GLWf+dGuhMf1kpHdEOS+qMGrtU+MCppgXAMIZQ8W1anlj0EK?=
 =?us-ascii?Q?VQkAal5zubu2Fk+7nEr14ly9MXJ3GJWnhXqbVjzcjw466hRMGsDN6O2ALjX+?=
 =?us-ascii?Q?/RaP/zEy0G0nV/8mFVbB9iYiuzLXMNywjLCKhEaNDFXZPSVShIifj28JaoYs?=
 =?us-ascii?Q?IxuHCW9JWoluVcB5qzvqvHVChNZDni9XCgm7+qrhgLdiO9ffyRsyddZuL3xN?=
 =?us-ascii?Q?/4Lb9hZYWPAxi7NOuuuFTPFVK/Sp0LsTBTw7nLUCEPq40BPPrXZyKFaXkvn0?=
 =?us-ascii?Q?LvJDZF+H2movbpivjiqH3h8uce6/tmpYHrT7yLDmmh3/D4R+I3RgQTaM1Kao?=
 =?us-ascii?Q?3VcIfQTYYpMBn62WDIc2q00QuNQ3Hg+5D+/YuaU6QotivkkgDJz7MwHrSoup?=
 =?us-ascii?Q?jxuNmadfNR6+C3p4YjrdpYY1iBhyw4fHxe9a9huYKH0naqBlaKT57Hpv3iLU?=
 =?us-ascii?Q?9IswfJJdbxg8DS3kv7wa2jmxekaKT7R1KTCNpOA/uSfEdiWVTMoLslJNy6Ay?=
 =?us-ascii?Q?fQzUn2BYMzXiBaQlnlpmGG1xQHGRnP31j6h3UZYeOmZ2QETHkKRAZc+9AwHx?=
 =?us-ascii?Q?RCYHCMdLwSMmjLWWCx2DE7ufQUWHlD9/XFj652c4+hdl3x+wDUO7WgbEDuhP?=
 =?us-ascii?Q?JFAAVI54fiIbwaPuf5pVfJVjDICIPJhr3gxD3WmTZQp+epmwDQ1Ue7AOx7KE?=
 =?us-ascii?Q?kmnKQK3dvJ8HfyUSh1LVgo4ii9idD0XE2UQIZOKKV1+RYDL1NPHrPYYvvEbF?=
 =?us-ascii?Q?VVV0tBrO50g6IYeoHTMhagWKlBAzrR0w5Vxis9Ytq5DM/9M0fr5mggAwKeEf?=
 =?us-ascii?Q?Dhd7z4onfn8UDTYuG+BREPNZ20Vicx7B2cthnFZRN57A26X4xCzoX+sNmgJ6?=
 =?us-ascii?Q?gBwqD8Nz1Ec095cJsvKYynw8Le4WGLSALbudxnvQADBEWAMO/CYQzxlriE5G?=
 =?us-ascii?Q?eoOSn2iZknwApvnTMtcpLCV2p0msigCDnPr6ZUDIWW6Ae5y7uQfVdMULEPwd?=
 =?us-ascii?Q?VkxZK7fS1Pr6J84/nk3JZgL4YvmA9mBmVO7Uy9e9A7tJhPrfdfMRVxLEwO3p?=
 =?us-ascii?Q?6fNmCAukiADFk8/DyPfx1kdnAD0nAdMLHy/tQZ2+fetjnuZiFU1rsDDeLCAE?=
 =?us-ascii?Q?A8UUgirPwXZE1i/F4fUq3doeDsnRV2X/uYeJxa4dZP+5toa0m5tH1KkXw7MM?=
 =?us-ascii?Q?4FRMrgPYxIcALjbSHFAmnnN5aL9F5/tIzDs2FGOajZhS9ujRZDVHu9NAm6O1?=
 =?us-ascii?Q?mWKOE+l6M0CLgVvrpqzf2GpTwYwvQGokCliNtKVEs8B7yfbqKhkEQ1H8nToz?=
 =?us-ascii?Q?To5ML47DU1T49J4eKR8TnABxSB/gmYEAnAQHyy1HgSw5UF9k3gkLb9oQ9tgS?=
 =?us-ascii?Q?OttFG+bKXern8IaJmPawemmfzRdlDzglHCOeLaeBORuYx82wU0Fr3Kca2zHX?=
 =?us-ascii?Q?0Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa389952-fe03-4664-fb18-08dab26e7aea
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 07:41:20.8306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rjkK4E+i4oW2ZizlGEu2g9vQ3STUrfOLJgZsEtNalyi8jCpUqza+WEVOOTMTsI+J6Qk8nXUaPwFptniOar5LZqXGzTASfDPY2KSV3ReCgOM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5103
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_02,2022-10-19_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210200044
X-Proofpoint-GUID: JLjrg-HfagR0h8n-pCtmtc40fTksNNtG
X-Proofpoint-ORIG-GUID: JLjrg-HfagR0h8n-pCtmtc40fTksNNtG
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   aae703b02f92bde9264366c545e87cec451de471
commit: 8aa5bcb61612060429223d1fbb7a1c30a579fc1f gpu: host1x: Add context device management code
config: arm-randconfig-m031-20221019
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/host1x/context.c:77 host1x_memory_context_list_init() warn: missing error code 'err'

vim +/err +77 drivers/gpu/host1x/context.c

8aa5bcb6161206 Mikko Perttunen 2022-06-27  16  int host1x_memory_context_list_init(struct host1x *host1x)
8aa5bcb6161206 Mikko Perttunen 2022-06-27  17  {
8aa5bcb6161206 Mikko Perttunen 2022-06-27  18  	struct host1x_memory_context_list *cdl = &host1x->context_list;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  19  	struct device_node *node = host1x->dev->of_node;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  20  	struct host1x_memory_context *ctx;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  21  	unsigned int i;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  22  	int err;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  23  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  24  	cdl->devs = NULL;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  25  	cdl->len = 0;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  26  	mutex_init(&cdl->lock);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  27  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  28  	err = of_property_count_u32_elems(node, "iommu-map");
8aa5bcb6161206 Mikko Perttunen 2022-06-27  29  	if (err < 0)
8aa5bcb6161206 Mikko Perttunen 2022-06-27  30  		return 0;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  31  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  32  	cdl->devs = kcalloc(err, sizeof(*cdl->devs), GFP_KERNEL);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  33  	if (!cdl->devs)
8aa5bcb6161206 Mikko Perttunen 2022-06-27  34  		return -ENOMEM;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  35  	cdl->len = err / 4;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  36  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  37  	for (i = 0; i < cdl->len; i++) {
8aa5bcb6161206 Mikko Perttunen 2022-06-27  38  		struct iommu_fwspec *fwspec;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  39  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  40  		ctx = &cdl->devs[i];
8aa5bcb6161206 Mikko Perttunen 2022-06-27  41  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  42  		ctx->host = host1x;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  43  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  44  		device_initialize(&ctx->dev);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  45  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  46  		/*
8aa5bcb6161206 Mikko Perttunen 2022-06-27  47  		 * Due to an issue with T194 NVENC, only 38 bits can be used.
8aa5bcb6161206 Mikko Perttunen 2022-06-27  48  		 * Anyway, 256GiB of IOVA ought to be enough for anyone.
8aa5bcb6161206 Mikko Perttunen 2022-06-27  49  		 */
8aa5bcb6161206 Mikko Perttunen 2022-06-27  50  		ctx->dma_mask = DMA_BIT_MASK(38);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  51  		ctx->dev.dma_mask = &ctx->dma_mask;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  52  		ctx->dev.coherent_dma_mask = ctx->dma_mask;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  53  		dev_set_name(&ctx->dev, "host1x-ctx.%d", i);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  54  		ctx->dev.bus = &host1x_context_device_bus_type;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  55  		ctx->dev.parent = host1x->dev;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  56  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  57  		dma_set_max_seg_size(&ctx->dev, UINT_MAX);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  58  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  59  		err = device_add(&ctx->dev);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  60  		if (err) {
8aa5bcb6161206 Mikko Perttunen 2022-06-27  61  			dev_err(host1x->dev, "could not add context device %d: %d\n", i, err);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  62  			goto del_devices;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  63  		}
8aa5bcb6161206 Mikko Perttunen 2022-06-27  64  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  65  		err = of_dma_configure_id(&ctx->dev, node, true, &i);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  66  		if (err) {
8aa5bcb6161206 Mikko Perttunen 2022-06-27  67  			dev_err(host1x->dev, "IOMMU configuration failed for context device %d: %d\n",
8aa5bcb6161206 Mikko Perttunen 2022-06-27  68  				i, err);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  69  			device_del(&ctx->dev);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  70  			goto del_devices;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  71  		}
8aa5bcb6161206 Mikko Perttunen 2022-06-27  72  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  73  		fwspec = dev_iommu_fwspec_get(&ctx->dev);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  74  		if (!fwspec || !device_iommu_mapped(&ctx->dev)) {
8aa5bcb6161206 Mikko Perttunen 2022-06-27  75  			dev_err(host1x->dev, "Context device %d has no IOMMU!\n", i);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  76  			device_del(&ctx->dev);
8aa5bcb6161206 Mikko Perttunen 2022-06-27 @77  			goto del_devices;

Set error code here?

8aa5bcb6161206 Mikko Perttunen 2022-06-27  78  		}
8aa5bcb6161206 Mikko Perttunen 2022-06-27  79  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  80  		ctx->stream_id = fwspec->ids[0] & 0xffff;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  81  	}
8aa5bcb6161206 Mikko Perttunen 2022-06-27  82  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  83  	return 0;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  84  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  85  del_devices:
8aa5bcb6161206 Mikko Perttunen 2022-06-27  86  	while (i--)
8aa5bcb6161206 Mikko Perttunen 2022-06-27  87  		device_del(&cdl->devs[i].dev);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  88  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  89  	kfree(cdl->devs);
8aa5bcb6161206 Mikko Perttunen 2022-06-27  90  	cdl->len = 0;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  91  
8aa5bcb6161206 Mikko Perttunen 2022-06-27  92  	return err;
8aa5bcb6161206 Mikko Perttunen 2022-06-27  93  }