Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 09:31:34 +0200
From:   Casper Andersson <casper.casan@gmail.com>
To:     Steen Hegelund <steen.hegelund@microchip.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        Randy Dunlap <rdunlap@infradead.org>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Nathan Huckleberry <nhuck@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 4/9] net: microchip: sparx5: Adding initial
 tc flower support for VCAP API
Message-ID: <20221020073134.ru2p5m5ittadthzr@wse-c0155>
Organization: Westermo Network Technologies AB
References: <20221019114215.620969-1-steen.hegelund@microchip.com>
 <20221019114215.620969-5-steen.hegelund@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221019114215.620969-5-steen.hegelund@microchip.com>
Precedence: bulk

Hi Steen,

It's a pretty big patch series, but overall I think it looks very good.
I've got some minor comments. I also tested it on the Microchip PCB135
switch and it works as described.

On 2022-10-19 13:42, Steen Hegelund wrote:
> +static void sparx5_tc_flower_set_exterr(struct net_device *ndev,
> +					struct flow_cls_offload *fco,
> +					struct vcap_rule *vrule)
> +{
> +	switch (vrule->exterr) {
> +	case VCAP_ERR_NONE:
> +		break;
> +	case VCAP_ERR_NO_ADMIN:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "Missing VCAP instance");
> +		break;
> +	case VCAP_ERR_NO_NETDEV:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "Missing network interface");
> +		break;
> +	case VCAP_ERR_NO_KEYSET_MATCH:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "No keyset matched the filter keys");
> +		break;
> +	case VCAP_ERR_NO_ACTIONSET_MATCH:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "No actionset matched the filter actions");
> +		break;
> +	case VCAP_ERR_NO_PORT_KEYSET_MATCH:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "No port keyset matched the filter keys");
> +		break;
> +	}
> +}

Could this also be shared in the VCAP API? It currently doesn't use
anything Sparx5 specific. Though, net_device is unused so I'm guessing
you might have plans for this in the future. And it might fit better
here according to your design goals.

Tested-by: Casper Andersson <casper.casan@gmail.com>
Reviewed-by: Casper Andersson <casper.casan@gmail.com>