Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp494021rwi; Thu, 20 Oct 2022 01:09:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7gC4YhuCcOvtfDgfQuh7ua+ejm79j7HyOkx1cw3g22D9ByefT0Am/c5PrEMQJsWGzHzfm6 X-Received: by 2002:aa7:da43:0:b0:45f:f0aa:76e4 with SMTP id w3-20020aa7da43000000b0045ff0aa76e4mr2436575eds.165.1666253368004; Thu, 20 Oct 2022 01:09:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666253367; cv=none; d=google.com; s=arc-20160816; b=PnHQ8nBotVoIv9krKUk5n7GJnjksRBnMQ3v8mt0jpt/vUGT9DP87cACa9WXj7k4ZEf E/rq+uFViasjydvlXwAv+nGY9XIb/QINhcleeiu8gAE5bh9zycQEMiPZ0feiS2CuglVe F/Hf8OOHW5fd0cGrHhWZgPadUAow4aAhH/AC8sWy+Zhsh65QO/QumV07XUaxVpLscW1M PfjSswEXwWDsuTmKpKxSl+6tybjkIL8hXfZcchzkjFlHLV2wwU09yD9I3iR3aYdpCP9z G5uV07E0Da6i1ZSrg+4My7m+AU4MbYfqbQdtrG1a18LjNQ+EdovG7QFNMxJh2P/JgdlJ VGew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=9MEnlFVwJkmWtLtkKEfx0ZXfHEzbCZAmDXy26LRGs4Y=; b=HLsD+6PAHzNhAntV5AKVx2sNLddQAvzOw7MtN7fE6u1B/118XVhFj2rGh4+4zUZ/rk ugq8a2q55SLY+7Xcrn4SrTVcRbM0OC992ZGnZh9K5iL/5duxwQqc8SyJHgUo1LLpsAcB Ub64C6HsQw8/RNe1w1dax2zE1xDcr9/mMba28CFcQAN3loTTxxrdo5yk8zWbfcbWqq+W 3zvljrsp8yyI/N1eigkSmBVg577c08yxIFZUMwIIR8huzXu5mT7OLtpe28Iua9g0UKnK 3lrbiPBl7ikhJwrv8vqogxfEw4VKRIZMNlE12KAtvmj00l4xmD3C6abup4Z5+jJ4+/lF hXKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=kZt9Qh5u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a1709067e4300b0078e19e971b2si11395408ejr.915.2022.10.20.01.09.02; Thu, 20 Oct 2022 01:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=kZt9Qh5u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiJTHyL (ORCPT + 99 others); Thu, 20 Oct 2022 03:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231124AbiJTHxw (ORCPT ); Thu, 20 Oct 2022 03:53:52 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D98E613728E for ; Thu, 20 Oct 2022 00:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666252417; bh=zHYAYQCcnlsxx2uC96j0anWRnyR5lcqsPx8S7lulGuw=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=kZt9Qh5uE3ToX8QkJapntuXJRsV8Xu17ntQb90uyMOngJnKhwiZIAO3IhwmKHKE9N IzH6IaiTCQ6HzxQn9714R33WvPzMOpfkxQkiwlAF0A+Lao5X0DAhqN2zT/yZphv7Ft GjkFmuet1VipI+hQ0NnfkY8n0ib6Nbjl2KdPn3jY= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Thu, 20 Oct 2022 09:53:37 +0200 (CEST) X-EA-Auth: kxwkC+LfXIT3Z/qsXSiQHzyS/fMd9zQmbbMn0YHsvakVQZbis0gT72PNJ4vhhmSFLi1hIqNbSWVER2GXr+cVDYjGicv9xkwL Date: Thu, 20 Oct 2022 13:23:32 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH v3 02/10] staging: r8188eu: reformat long computation lines Message-ID: <5c3c0ef7c90ab2eec73067e1dd88f337932363e3.1666249716.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reformat long running computation instructions to improve code readability. Address checkpatch script complaints like: CHECK: line length of 171 exceeds 100 columns Signed-off-by: Deepak R Varma --- Changes in v3: -- None Changes in v1 [actually v2]: 1. Further improve the formatting per feedback from gregkh@linuxfoundation.org drivers/staging/r8188eu/core/rtw_br_ext.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c index 79daf8f269d6..8b1c9fdf6ed2 100644 --- a/drivers/staging/r8188eu/core/rtw_br_ext.c +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c @@ -211,8 +211,9 @@ static int __nat25_network_hash(unsigned char *network_addr) } else if (network_addr[0] == NAT25_IPX) { unsigned long x; - x = network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr[4] ^ network_addr[5] ^ - network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ network_addr[9] ^ network_addr[10]; + x = network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr[4] ^ + network_addr[5] ^ network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ + network_addr[9] ^ network_addr[10]; return x & (NAT25_HASH_SIZE - 1); } else if (network_addr[0] == NAT25_APPLE) { @@ -224,16 +225,18 @@ static int __nat25_network_hash(unsigned char *network_addr) } else if (network_addr[0] == NAT25_PPPOE) { unsigned long x; - x = network_addr[0] ^ network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr[4] ^ network_addr[5] ^ network_addr[6] ^ network_addr[7] ^ network_addr[8]; + x = network_addr[0] ^ network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ + network_addr[4] ^ network_addr[5] ^ network_addr[6] ^ network_addr[7] ^ + network_addr[8]; return x & (NAT25_HASH_SIZE - 1); } else if (network_addr[0] == NAT25_IPV6) { unsigned long x; - x = network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr[4] ^ network_addr[5] ^ - network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ network_addr[9] ^ network_addr[10] ^ - network_addr[11] ^ network_addr[12] ^ network_addr[13] ^ network_addr[14] ^ network_addr[15] ^ - network_addr[16]; + x = network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr[4] ^ + network_addr[5] ^ network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ + network_addr[9] ^ network_addr[10] ^ network_addr[11] ^ network_addr[12] ^ + network_addr[13] ^ network_addr[14] ^ network_addr[15] ^ network_addr[16]; return x & (NAT25_HASH_SIZE - 1); } else { -- 2.30.2