Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp514544rwi; Thu, 20 Oct 2022 01:31:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Lo8rYgzXLEIpLYgTm+UXwQu+Eixi/B/vYebOpMYWaQ1pCBeVkYXo3hMjW7VRB6evlKUck X-Received: by 2002:a17:907:3f85:b0:733:3f0e:2f28 with SMTP id hr5-20020a1709073f8500b007333f0e2f28mr9671266ejc.376.1666254668853; Thu, 20 Oct 2022 01:31:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666254668; cv=none; d=google.com; s=arc-20160816; b=f4vf2I9Dz6RpVBKRpR59M/O58wLBCeMSjkQSD0r0/SQkP6g4OcR9HTzJ4YXGsjpW27 tp/CZws4d9Snkluv5UfdHU1Zx2qRlRSXDl2ipaoyy3j9AofdfWSaCnm2Tr3YgT554x5U zu6SXt7MlGNMEtZ01KjRM+vH8DeMALpFqskMVWA3irUQZACU9mTGWpLPszsBfdxvVAit QOIeEIL5rw0+Omfqr1J8l1RnbJjC/jdD6rtjuhop0nJPikWZ6Xu4JApNi/fgHWyTwn09 N3kJfM4NuTyCkf++CD2g49jF/zD8Z5llQv9MWPRC7ocTNQQMLRaa6fQA2m5nGcWOJ2Zj F9oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qBH+AWbAo+Gl0uKNfNEy4P9h6AZPNyWEVK1hOo2IV6w=; b=V2ZQ7Isl07fBUcJ+5uOvT4h6rcr3OmKHgktaWIucOMu/8tuZlMOhxF7Wg9+ou76eq3 kLQuafiF1bjf56unQ7g59ZsVo2qdTxK7rpiQ69q7NLBp+yeCPahb4p1DGkRtUBg/8lKM 1ciK/HjJKqX8K6UFEERpVIZbC+YP5St1jVSR9k8mbWoLr4ujynhO6G+CUi3iYptbykPR 8a+jnxR0EP76z9c4OYogrndB0uSRb5zafgyI+UohoyuarGIH3XU16fKIKoNJCnUMidq8 CQ5DRw/IHXXvvGymVO0pZTMPZ6fkd6Cxgc3X4QzfjxlyIqewx+5eUZgJ38q7dk0p3Uin E31Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=MHhEfsRB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i23-20020a170906251700b007827639faffsi14420523ejb.760.2022.10.20.01.30.30; Thu, 20 Oct 2022 01:31:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=MHhEfsRB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbiJTIID (ORCPT + 99 others); Thu, 20 Oct 2022 04:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbiJTIH6 (ORCPT ); Thu, 20 Oct 2022 04:07:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E22316C23F; Thu, 20 Oct 2022 01:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qBH+AWbAo+Gl0uKNfNEy4P9h6AZPNyWEVK1hOo2IV6w=; b=MHhEfsRBQHbqqUcVBr37yDxzsW ZbBcLbwkEVE1a4iMe9iSA1oA4WJtrXmv9JO8iaYhJtMDHDEFAe+7x6r6+W/jLF+O1EjQu7xGdz9/f OMCBgrx2hVpIYCWG8puROVR9S7EDyd52t5+PqTpahy1URTcNGHf9hSBsRLOU5GEEOL0DssY4A6zNf E+YsaqM2q2/LOm0UI9ZeheHPVfNFaLNeh48/OOgK4U8yB3bXFOVJkcSo+pCR+V1yAWOko7w27dUyu SAipytc9aW92io99feQO2MtRzBMaU6ZiZ7T/E1VHtkzKzViWEO4aeWuzrJ7lWZrLrpXfeFiwcn4iM ZkMJS7eQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1olQak-00C4EV-Es; Thu, 20 Oct 2022 08:07:50 +0000 Date: Thu, 20 Oct 2022 01:07:50 -0700 From: Christoph Hellwig To: Niklas Schnelle Cc: Matthew Rosato , iommu@lists.linux.dev, Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Gerd Bayer , Pierre Morel , linux-s390@vger.kernel.org, borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com, svens@linux.ibm.com, linux-kernel@vger.kernel.org, Wenjia Zhang , Julian Ruess Subject: Re: [RFC 1/6] s390/ism: Set DMA coherent mask Message-ID: References: <20221019144435.369902-1-schnelle@linux.ibm.com> <20221019144435.369902-2-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019144435.369902-2-schnelle@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2022 at 04:44:30PM +0200, Niklas Schnelle wrote: > if (ret) > goto err_resource; > > + ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); Nit: but you could also just replace the call to dma_set_mask abobe with a call to dma_set_mask_and_coherent.