Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5639218e-bcc8-55b0-ea30-7bf2b26c92b9@redhat.com>
Date:   Thu, 20 Oct 2022 10:03:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] drm: tests: Fix a buffer overflow in format_helper_test
Content-Language: en-US
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        David Gow <davidgow@google.com>
Cc:     David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>,
        dri-devel@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
        linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com,
        Linux Kernel Functional Testing <lkft@linaro.org>
References: <20221019073239.3779180-1-davidgow@google.com>
 <20221019172919.GA5336@elementary>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221019172919.GA5336@elementary>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/19/22 19:29, José Expósito wrote:

[...]

>>  drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
>> index 8d86c250c2ec..2191e57f2297 100644
>> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
>> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
>> @@ -438,7 +438,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
>>  	iosys_map_set_vaddr(&src, xrgb8888);
>>  
>>  	drm_fb_xrgb8888_to_xrgb2101010(&dst, &result->dst_pitch, &src, &fb, &params->clip);
>> -	buf = le32buf_to_cpu(test, buf, TEST_BUF_SIZE);
>> +	buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));
>>  	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);
>>  }
> 
> Thanks a lot for fixing this bug David, I just tested it and
> worked as expected.
>

I've pushed this to drm-misc (drm-misc-fixes) now. Thanks!
 
> Do you think that we should update the other calls to
> le32buf_to_cpu() to follow a similar approach?
>

Feel free to post follow-up patches if you think that other changes are needed.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat