Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp535424rwi; Thu, 20 Oct 2022 01:53:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5KwrDNqDOCkEqD+NkgaR9BzU4VYiU53QZ+EOMqvUHQRIlTnUKkXCJQBHwY7a7CD5Ft/VBU X-Received: by 2002:a17:907:7da2:b0:78e:25f8:8803 with SMTP id oz34-20020a1709077da200b0078e25f88803mr10006511ejc.723.1666256022468; Thu, 20 Oct 2022 01:53:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666256022; cv=none; d=google.com; s=arc-20160816; b=U+ORw8NbNM1OP06i8JAJcAy3QY++gBV10PWy22UNHdEzEZCUMN7ln4LKkwUZmSiMy8 YZdxSO8HCJvxEisuKZ9jSoiNevV+F/v1GMcyKH7dclclHAelkE1BDerqM7mZlnS4/xiB Ii5u8QZWKQI+lJYMusND9gL6H3LqoR1Kr6+5+iF+Tg3eGcyng6YFAWUufdobqH+1cwup 6/mNHVBvUYItzlUaCY7/oyefrBHeMnpunC26sjFnqHC2WGY8ua/W4dnmpUtqi6dJiouN sUpN6Yv5CnQN1BtVm5ZHy6BHjTIhrx8iceL2ZVbVbg6gK6sVzsrDv+Dt36Jtj7ZrtrX3 bbIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nzKugFjin02AsmVSO2SO0VwhTWFBPSTkNTSFyYe251I=; b=JRcH1wFa/lyEwrfhHCR3QwVej6EHZaB3OdBMi8sSbSe1Jqw0O6LyiDWcc8sS8IzGos McTmtbMTgZ+ACiYArW48BOxUwy3jftpxoabDSzl1s/kNS3COQiihb0M0qQcl36lsj4LR b5kz3TcUizmX5CaWn9XALdYt6EmweavRpJB38KBNoI6q3L0MsjjvPpyqS4tnwBiBHWqG nTfZHGA3bfXJB3JGYEUL7mGa+ip8Nri6cjhrVUEftXFWsHhoazQeDluyLugd/k+pcVWa 22gaibHll3FuQlugb0jfHiK3d47jl5wSRr6fh10NKRix1W5cecm6zXfTmJM73EaWQ5lq 6cSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=giFg8cmW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a170906268700b0073de493b83esi14241377ejc.147.2022.10.20.01.53.17; Thu, 20 Oct 2022 01:53:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=giFg8cmW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbiJTI0o (ORCPT + 99 others); Thu, 20 Oct 2022 04:26:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbiJTI0l (ORCPT ); Thu, 20 Oct 2022 04:26:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDE4188A85; Thu, 20 Oct 2022 01:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nzKugFjin02AsmVSO2SO0VwhTWFBPSTkNTSFyYe251I=; b=giFg8cmWtAJ+oOhF6XZcXqFAPi jZ/26cqTs4SRs/bBLLzAIglFyvHeG1I/OG+TVy1zvB1DTnenH+rJQBm41hPJZxzV1yCvCms87Q1x6 ATqWDUE3mwDLrZvVCF9+2U4Kh3hL3H1lXjce7om1NWsEeRCgegLpZooIQVUC9YDmFbjZxU5mqz7+z 79DHJD2eHUKtEj8V/EnOBvCH7apHoICpdmevMPSDBRfFZfpqJRPz2ciiVw56pL7IGHs2WmVbheyOu 8xF7aRZF7jLWy5LctIP/N4LGJ0O7AWxdW2YLSTIAmygSn6oyPM6GxEodfZVIxguCUiuTmBACU6fOm Kf05jfww==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1olQsx-00CBhc-8o; Thu, 20 Oct 2022 08:26:39 +0000 Date: Thu, 20 Oct 2022 01:26:39 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: Jens Axboe , linux-block@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC for-next v2 1/4] bio: safeguard REQ_ALLOC_CACHE bio put Message-ID: References: <558d78313476c4e9c233902efa0092644c3d420a.1666122465.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <558d78313476c4e9c233902efa0092644c3d420a.1666122465.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 08:50:55PM +0100, Pavel Begunkov wrote: > bio_put() with REQ_ALLOC_CACHE assumes that it's executed not from > an irq context. Let's add a warning if the invariant is not respected, > especially since there is a couple of places removing REQ_POLLED by hand > without also clearing REQ_ALLOC_CACHE. Looks good: Reviewed-by: Christoph Hellwig