Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5e80cef1df473b2b401b803c5ad6fc1dddba17fc.camel@mediatek.com>
Subject: Re: [PATCH v3] arm64: dts: mt8195: Add Ethernet controller
From:   Biao Huang <biao.huang@mediatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
CC:     <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <macpaul.lin@mediatek.com>
Date:   Thu, 20 Oct 2022 16:49:13 +0800
In-Reply-To: <0fb91a39-e356-4785-3ab1-11cbc3e78877@collabora.com>
References: <20221020024155.24520-1-biao.huang@mediatek.com>
         <20221020024155.24520-2-biao.huang@mediatek.com>
         <0fb91a39-e356-4785-3ab1-11cbc3e78877@collabora.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Angelo,
	Thanks for your comments~

On Thu, 2022-10-20 at 10:09 +0200, AngeloGioacchino Del Regno wrote:
> Il 20/10/22 04:41, Biao Huang ha scritto:
> > Add Ethernet controller node for mt8195.
> > 
> > Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88
> > ++++++++++++++++++++
> >   arch/arm64/boot/dts/mediatek/mt8195.dtsi     | 88
> > ++++++++++++++++++++
> >   2 files changed, 176 insertions(+)
> > 
> 
> ..snip..
> 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index 905d1a90b406..7efaf92c5ff3 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -1042,6 +1042,94 @@ spis1: spi@1101e000 {
> >   			status = "disabled";
> >   		};
> >   
> > +		eth: ethernet@11021000 {
> > +			compatible = "mediatek,mt8195-gmac",
> > "snps,dwmac-5.10a";
> 
> ..snip..
> 
> > +			#address-cells = <0>;
> > +			#size-cells = <0>;
> 
> I'm truly sorry for a partial bad suggestion, you don't need to
> specify address nor
> size cells = <0>; in the ethernet node, or you get a warning:
> 
> arch/arm64/boot/dts/mediatek/mt8195.dtsi:1174.26-1260.5: Warning 
> (avoid_unnecessary_addr_size): /soc/ethernet@11021000: unnecessary 
> #address-cells/#size-cells without "ranges" or child "reg" property
> 
> So please remove these two.
OK, will remove in next send.
> 
> After which...
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
OK, will add in next send.
> 
> 
Best Regards!
Biao