Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp538138rwi; Thu, 20 Oct 2022 01:57:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6yIR7A4VquR9sqjyA51JP9GRaSKfyD0z0pLU0C+PEyhr8xdwE6VpC9yTqpgxkriXCLhaQI X-Received: by 2002:a17:906:8a64:b0:78d:b00d:fe with SMTP id hy4-20020a1709068a6400b0078db00d00femr10355651ejc.32.1666256224092; Thu, 20 Oct 2022 01:57:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666256224; cv=none; d=google.com; s=arc-20160816; b=vpQRbKHDybhQMZfpJfRWeoCWudCUCWr4mAiMayaxq8IcB4RSf8GFlf7JJY6GFy2gL5 o9HEpeEuwyNPTYZYr/3PJuAyOXpm/sAwP0/Oraun/pLgE2gDxTcOZm7ONfJNn+kBmf3W 0rAfM2hodTlEL3Ou64nS1FsufuWUqZ0IH1qWmmogQi6dLEt534mjzEId3yvaZIJEgfCh iLsXKj/jQQg5zlT3pxRFGu7zEjGkpUiFXDv/O6ribUSoG1LNPGYaCropzkYJs/sU47zy J4cGJJMMOMHkWtvOeV9ywadfqBtuw2Sf0Tw12pqvN2rPJaKTaCe4H954Hw98iI7YUJrD nwNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :feedback-id:dkim-signature:dkim-signature; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=fX/TDCcWl2Yu4lSfowRi+MxPP8UKrJIm7T4TTdJAYZjgW1d+QFToOECncg1v24pB0U 2SgFgjMvzVD2PACHtbilK1yjowMZ5A82jTgyPz/nmdb6E5VgFe7Wfs5ofWs8KkTNZNXd /an72p9kIwJyyxUazAv7yIx6nVZc3K+OOkij36M2U5Re/wvDsNu+Azz4bGZKNp13PSE9 KVEKs2WoazRjO5l8YwH726D+2ugHKNiVjlys4Mj0C5whLjJv2NjtshIUhp9tJo+V4B5l D7ymX1So+Sya2mSUymj8f1Y7QkW+Na5XUQtAeTQI2t/zz4uQLgqdzXyeIzdhQ1F0KjLx f0pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=pIVewE0Z; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=CYXW505x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr11-20020a170907720b00b00783afe864c6si18267999ejc.124.2022.10.20.01.56.37; Thu, 20 Oct 2022 01:57:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=pIVewE0Z; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=CYXW505x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbiJTIwB (ORCPT + 99 others); Thu, 20 Oct 2022 04:52:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbiJTIvo (ORCPT ); Thu, 20 Oct 2022 04:51:44 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231C018C962 for ; Thu, 20 Oct 2022 01:51:22 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6F4C6320091A; Thu, 20 Oct 2022 04:51:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 20 Oct 2022 04:51:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255878; x= 1666342278; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=p IVewE0Z001+xXD14v17px7/vL/VxtVJrbQt+NJ6J9T8W/JvZY0/LJ6bkUmDm6fQw QoQvlOtwBp8Wa1wAuf1PRQK4Z8Zp29IQIZB0mSL7Cp7I05vGgLvFNY6gM64dWcQC ngCxUgzgTA8G5i4wmUP9xT4M+5QoERh+3tM4kOe4B0ynR+ZU+AZ4ZzCEU36bgYGW bzlcrKflb9qW41WBomCSmi/vV6lN15P4q1R5rWIWHT2Su8Maw1gUQpbjrmB1wExd 7mN6PhxI2fEGXrNrvlHXn+DJRLjk0u9F/vtiNMF1OBVngXkVvSimJE/cptsALTQR n1cc3r6b85CeX8OeaHnCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255878; x= 1666342278; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=C YXW505xbvqJ2G9zUNNnOvQMxGHFv/58s3C41nZicrHh0R89cuLhDmM3wtW6XplC1 Zt0Er0ad66JMQN6UcG2uB4KaaSCpo1KTE1J8AZuJB5RlJ5eulFmaOKwdgFfhTQLm PTemKkm88XPxWlbkAu8KDRNv00ZYkwLjV5diX1YOeWjhhyGkuIeMomzIhmUD91BF KH/RMl90dh1L2nYyT9szLoHDXQOs/Tw/lo4gRlf0iNW9KHJF5RXlE/N9aI6s5By7 dH+WPRjIgVe2+MPgGqsZYtXd/V6NMpsH5FWAtOeayZ7U1TDRYC1pilO6xXBhcEtL 08tne4wslk6/9tzqyokeg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:17 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:51 +0200 Subject: [PATCH v2 7/7] drm/vc4: dpi: Fix format mapping for RGB565 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20221013-rpi-dpi-improvements-v2-7-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1022; i=maxime@cerno.tech; h=from:subject:message-id; bh=43Ff0zFIOvU8ONzBI2sMboXcyvjpYfdtbjUUqEZ+IMo=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BZun+9cOHhhZkG26VLBhMoqro9zxHQ+PCx667xsuZma k/aijlIWBjEuBlkxRZYYYfMlcadmve5k45sHM4eVCWQIAxenAEzkNyfDH44Js/RL30h/b5r/keNHVN 69AHY+vat1EfyvqnU+Tz7wroCRYe/BjROqBet2JGWJf3k4TzZpjwfzZlad31VF87ebilinsQIA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson The mapping is incorrect for RGB565_1X16 as it should be DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3. Fixes: 08302c35b59d ("drm/vc4: Add DPI driver") Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index fdae02760b6d..a7bebfa5d5b0 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -185,7 +185,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X16: - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1, DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: -- b4 0.10.1