Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Joel Fernandes <joel@joelfernandes.org>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v3] rcu: Make call_rcu() lazy only when CONFIG_RCU_LAZY is enabled
Date:   Thu, 20 Oct 2022 04:27:56 -0400
Message-Id: <07E5D3DD-2AA5-48B2-ADCF-48004D889724@joelfernandes.org>
References: <20221020010242.453121-1-qiang1.zhang@intel.com>
Cc:     paulmck@kernel.org, frederic@kernel.org, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <20221020010242.453121-1-qiang1.zhang@intel.com>
To:     Zqiang <qiang1.zhang@intel.com>
Precedence: bulk


> On Oct 19, 2022, at 8:56 PM, Zqiang <qiang1.zhang@intel.com> wrote:
>=20
> =EF=BB=BFCurrently, regardless of whether the CONFIG_RCU_LAZY is enabled,
> invoke the call_rcu() is always lazy, it also means that when
> CONFIG_RCU_LAZY is disabled, invoke the call_rcu_flush() is also
> lazy. therefore, this commit make call_rcu() lazy only when
> CONFIG_RCU_LAZY is enabled.
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> ---
> v1->v2->v3:
> Use IS_ENABLED(CONFIG_RCU_LAZY) to the existing function of the same name.=
=20

Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Best,

 - J


> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index abc615808b6e..1f6a4b2b13da 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2887,7 +2887,7 @@ EXPORT_SYMBOL_GPL(call_rcu_flush);
>  */
> void call_rcu(struct rcu_head *head, rcu_callback_t func)
> {
> -    return __call_rcu_common(head, func, true);
> +    return __call_rcu_common(head, func, IS_ENABLED(CONFIG_RCU_LAZY));
> }
> EXPORT_SYMBOL_GPL(call_rcu);
>=20
> --=20
> 2.25.1
>=20