Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9bac72cf3c7ee92ad399fff5dcaae85903adda5.camel@redhat.com>
Subject: Re: [PATCH v3] net: hinic: Set max_mtu/min_mtu directly to simplify
 the code.
From:   Paolo Abeni <pabeni@redhat.com>
To:     Cai Huoqing <cai.huoqing@linux.dev>, kuba@kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Qiao Ma <mqaio@linux.alibaba.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 20 Oct 2022 11:09:31 +0200
In-Reply-To: <20221018110701.3958-1-cai.huoqing@linux.dev>
References: <20221018110701.3958-1-cai.huoqing@linux.dev>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-10-18 at 19:06 +0800, Cai Huoqing wrote:
> Set max_mtu/min_mtu directly to avoid making the validity judgment
> when set mtu, because the judgment is made in net/core: dev_validate_mtu,
> so to simplify the code.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
> v1->v2:
> 	1.Update changelog.
> 	2.Reverse MAX_MTU to max jumbo frame size.
> 
> v2->v3:
> 	1.Update signature
> 
> 	v1 link: https://lore.kernel.org/lkml/20221012082945.10353-1-cai.huoqing@linux.dev/
>         v2 link: https://lore.kernel.org/lkml/20220429033733.GA15753@chq-T47/
> 
> 
>  drivers/net/ethernet/huawei/hinic/hinic_dev.h  |  4 ++++
>  drivers/net/ethernet/huawei/hinic/hinic_main.c |  3 ++-
>  drivers/net/ethernet/huawei/hinic/hinic_port.c | 17 +----------------
>  3 files changed, 7 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_dev.h b/drivers/net/ethernet/huawei/hinic/hinic_dev.h
> index a4fbf44f944c..2bbc94c0a9c1 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_dev.h
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_dev.h
> @@ -22,6 +22,10 @@
>  
>  #define LP_PKT_CNT		64
>  
> +#define HINIC_MAX_JUMBO_FRAME_SIZE 	15872
> +#define HINIC_MAX_MTU_SIZE 	(HINIC_MAX_JUMBO_FRAME_SIZE - ETH_HLEN - ETH_FCS_LEN)
> +#define HINIC_MIN_MTU_SIZE 	256

I'm sorry for the nit pick, but the above is whitespace-damaged: you
are mixing spaces and tabs.

Cheers,

Paolo