Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 12:18:12 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Tanju Brunostar <tanjubrunostar0@gmail.com>
cc:     Nam Cao <namcaov@gmail.com>, greg@kroah.com,
        forest@alittletooquiet.net, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: vt6655: Fix Lines should not end with a
 '('
In-Reply-To: <CAHJEyKUsZ-V0waEwBEy67g+MNMR29MGJbBx3qCA4axKyPk9RGQ@mail.gmail.com>
Message-ID: <814aa14-25b-d579-e2d4-5c61ddb749b1@inria.fr>
References: <Y1BN6wPMrpxPB3qP@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net> <20221019223446.GA154747@nam-dell> <CAHJEyKUsZ-V0waEwBEy67g+MNMR29MGJbBx3qCA4axKyPk9RGQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Thu, 20 Oct 2022, Tanju Brunostar wrote:

> On Wed, Oct 19, 2022 at 11:35 PM Nam Cao <namcaov@gmail.com> wrote:
> >
> > On Wed, Oct 19, 2022 at 07:20:11PM +0000, Tanjuate Brunostar wrote:
> > > Code style warnings reported by checkpatch.
> > > Improve the layout of a function header:
> > > Put the first parameter immediately after the '(' and align the other
> > > parameters underneath it.
> > >
> > > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
> > >
> > > ---
> > > v2: put static and void on the same line and adjusted the indentation as
> > > suggested by Greg KH
> >
> > I think he meant putting "static" and "void" and also function name on
> > the same line.
> >
> Oh I will do this now. thanks
>
> > Additionally, I think your patch introduces new checkpatch problems. Did
> > you run checkpatch.pl on your patch?
> >
> > Best regards,
> > Nam
> >
> Yes I did. the checkpatch says this:
> Alignment should match open parenthesis
> #89: FILE: drivers/staging/vt6655/rxtx.c:89:
> +static void s_vFillRTSHead(struct vnt_private *pDevice,
> +               unsigned char byPktType,
>
> The only way to resolve this would be to add white space which would
> generate another checkpatch problem. how do i fix this please?

You mean that the ( is not at a point that is a precise multiple of the
tab size?  You can put as many tabs as possible and then use spaces
afterwards.

julia