Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9906b1bf-c938-e918-62bc-0c7118e954a9@gmail.com>
Date:   Thu, 20 Oct 2022 19:43:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
From:   Yuwei Guan <ssawgyw@gmail.com>
To:     paolo.valente@linaro.org, axboe@kernel.dk
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yuwei.Guan@zeekrlife.com
References: <20221018030139.159-1-Yuwei.Guan@zeekrlife.com>
In-Reply-To: <20221018030139.159-1-Yuwei.Guan@zeekrlife.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jens,

On 2022/10/18 11:01, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
> Acked-by: Paolo Valente <paolo.valente@linaro.org>
> ---
>   block/bfq-iosched.h | 4 ----
>   1 file changed, 4 deletions(-)

Can you help to check this patch again?

Thanks

> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..71f721670ab6 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -369,12 +369,8 @@ struct bfq_queue {
>   	unsigned long split_time; /* time of last split */
>   
>   	unsigned long first_IO_time; /* time of first I/O for this queue */
> -
>   	unsigned long creation_time; /* when this queue is created */
>   
> -	/* max service rate measured so far */
> -	u32 max_service_rate;
> -
>   	/*
>   	 * Pointer to the waker queue for this queue, i.e., to the
>   	 * queue Q such that this queue happens to get new I/O right