Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From:   Mario Limonciello <mario.limonciello@amd.com>
To:     <mario.limonciello@amd.com>, Hans de Goede <hdegoede@redhat.com>,
        <platform-driver-x86@vger.kernel.org>
CC:     Anson Tsao <anson.tsao@amd.com>,
        You-Sheng Yang <vicamo.yang@canonical.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/1] Fix using rtcwake on Cezanne platforms
Date:   Thu, 20 Oct 2022 06:37:48 -0500
Message-ID: <20221020113749.6621-1-mario.limonciello@amd.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 11:37:57.8776
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 69116e30-1757-445d-6a75-08dab28f8942
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT018.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5595
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Vicamo reports that rtcwake is not working properly on 6.0 kernel, but
worked properly on 5.17 kernel.  He bisected it down to:

commit b0c07116c8943 ("platform/x86: amd-pmc: Avoid reading SMU version at
probe time")

The issue is that commit made it possible to issue a suspend where SMU
version isn't known, meaning amd-pmc can't decide whether to activate
behavior to add a timer value to the OS_HINT message.

This wasn't reproduced on AMD's side initially because the testing
scripts were reading the idle mask from debugfs which would cache the
value in the driver.

This patch ensures that SMU version has been read even if debugfs hasn't
been accessed so that rtcwake can work again.

Mario Limonciello (1):
  platform/x86/amd: pmc: Read SMU version during suspend on Cezanne
    systems

 drivers/platform/x86/amd/pmc.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.34.1