Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp859342rwi; Thu, 20 Oct 2022 06:10:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM76w1Z4dzIzVG+qFybok8vyHbJTLZ3NXPdJGmgR3gTu4GbmO79k9p0NY17Dwue4H4H+uGDI X-Received: by 2002:a05:6402:3584:b0:45d:8fd7:f798 with SMTP id y4-20020a056402358400b0045d8fd7f798mr12011198edc.356.1666271407079; Thu, 20 Oct 2022 06:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666271407; cv=none; d=google.com; s=arc-20160816; b=r+uQjjYDNgt0ApDLkJh4+QjSslBU3WhwevALP3iqesQp2beXETpBLMNyyblfaJvT25 3anqCu6qzovj0IPkiDhSSA1z1UU240bbYY/ORicP3Z7M+iGdOnuQuLZ4xSnJsSb3IPrv crp5FoL7JmCNO1V+LXaPVU/P8IyFHsaUR3qpoVPQJHWDgesnzepH9SJLJfgETvZufBDp Cbbd2KNI7Uw9Dz/1gh2OpQJ1RRztx/XxxZxdIJr5I1zUtN1RhxhU2cYkNprQxrimEL2j o0QeHO4pMYcgTsdw95xeYNo3E4BF6SkmjjT9qHdTDCad62GobRoM/GSyE0IQLfRu9+Dm Yyzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=1CrWKVZtOI32J1eyiZca0oyo4c9aEVy1KXMgpcMBc2M=; b=Kxtg3IkBgrN8ALUGThQFz3Xqn2fQGEmyV8MxDHq2nQarzrNzHmN3Jh4OqkJUpgqwIi xfgCRUL4omfLERlC0ppDLRfKwyk17h7/doqPt16xlZaeSmDXFXYUnxnmrl1Mx9JMA2Lf 2m5p3xMmeA/6C4aDIYDIA4ZIZNh4MP1M7OYM2jO9BwvBox4e4nXxPWpUoInTBdjQIxLJ AFLPt1nFJwOnjPPguoMm+YKkFZV+nYBLb8jfDiOw2ux6j8PI+/Rh29EwoSLRg/4BPpCv UAHWPqcdNyw1K52LXgp6HHiOv/LQBxsXzV3hzF2CC6J5C4nYpkV7Bn+BaY2dSQ/t1Div FNNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=7hI7lCiv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw10-20020a170906478a00b0078db89b526asi18134215ejc.108.2022.10.20.06.09.41; Thu, 20 Oct 2022 06:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=7hI7lCiv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbiJTNDn (ORCPT + 99 others); Thu, 20 Oct 2022 09:03:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbiJTNDe (ORCPT ); Thu, 20 Oct 2022 09:03:34 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A9E41C6BCB for ; Thu, 20 Oct 2022 06:03:33 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id y8so20162047pfp.13 for ; Thu, 20 Oct 2022 06:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1CrWKVZtOI32J1eyiZca0oyo4c9aEVy1KXMgpcMBc2M=; b=7hI7lCivt4hx9vW2nR0DjQJmQ0HXCPZCnu0Pr7TM/bDO8uGWVGOdq69I7X/yhTvozo FZBowiYLhf1p6Ag4rKysrfyJJJvXRT0qCdz0TgTX2D72YmiUqr6eeJckZin7gptZc4CY gZZ5aCoCvQYK57fRrGcMOfoCx2FcrcQOcXaas2xxOcf+4q/A7tvLp2kAJan7XOo8gh84 iouCbnEN4WKbm9CS7ygwL81MBZHqJFAfXfWQXI0F45RvWc1rm70obsjv5ZZPFRLU0zWT 1KQjh+KjUfL+70epkmMRS9hrsGq0GOPHt2VjG70insx0oG2+RWlApfqgrj2rQ7pEhTVu RfaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1CrWKVZtOI32J1eyiZca0oyo4c9aEVy1KXMgpcMBc2M=; b=3dp8Plt6aYQUIxTWnZkKX8HcVKkuW1O+A/0uzijFucZLBvanLz7S6Mm1c5tRpokH4m lq9tHZi9fu+wftoXQcIphL49DUIQ3Q227RHnWFBtia+6yDAGg+fkpDDZ71Xv8TA9Pu3t Y5aIKXM8gL6zRxYIsvtz1yBE17UGmcRzphyhN89+KJb12IzaJxSdxD0wAKq9sxp6DBjn /Qp7L/P7KzymXxKUo1RdCfisuJzOYhHPKA4rsQg46kdIhuWnXMFK3cx55f9vrbNaIDsh T5uhtUTMAPRzSZcFaTlr8iTAO2KUYOC1j2x7wypVYsAE8+edUNSv4ThhYHMDtKV5YUro hObA== X-Gm-Message-State: ACrzQf0fqkj3sXyAfyNNZsgtRep4KgDKh78+iQf6+qp99qPxep38WZsm 8QVUGL/0A2MX9Dm0G/5K9PFYwiI2iLouzcv9 X-Received: by 2002:a63:5a41:0:b0:430:673e:1e13 with SMTP id k1-20020a635a41000000b00430673e1e13mr11902186pgm.435.1666271012904; Thu, 20 Oct 2022 06:03:32 -0700 (PDT) Received: from [127.0.0.1] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id q5-20020aa79825000000b005695accca74sm2551230pfl.111.2022.10.20.06.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 06:03:32 -0700 (PDT) From: Jens Axboe To: linux-block@vger.kernel.org, mhiramat@kernel.org, Ye Bin , rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, Ye Bin In-Reply-To: <20221019033602.752383-1-yebin@huaweicloud.com> References: <20221019033602.752383-1-yebin@huaweicloud.com> Subject: Re: [PATCH v3 0/3] fix possible memleak in '__blk_trace_remove' Message-Id: <166627101165.162941.2701658237902573676.b4-ty@kernel.dk> Date: Thu, 20 Oct 2022 06:03:31 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-d9ed3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Oct 2022 11:35:59 +0800, Ye Bin wrote: > From: Ye Bin > > Diff v3 VS v2 > 1. Invert the check of 'blk_trace_{start,stop}' and return early from the > function for the error case. > > Diff v2 VS v1: > 1. Introduce 'blk_trace_{start,stop}' helper instead of 'blk_trace_switch_state'. > 2. Move stop block trace from '__blk_trace_remove' to 'blk_trace_cleanup'. > > [...] Applied, thanks! [1/3] blktrace: introduce 'blk_trace_{start,stop}' helper commit: 60a9bb9048f9e95029df10a9bc346f6b066c593c [2/3] blktrace: fix possible memleak in '__blk_trace_remove' commit: dcd1a59c62dc49da75539213611156d6db50ab5d [3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown' commit: 2db96217e7e515071726ca4ec791742c4202a1b2 Best regards, -- Jens Axboe