Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221019130200.60460-1-yuanjilin@cdjrlc.com> <9fb4c010-b465-e908-6868-d9e493a9688f@infradead.org>
 <Y1Cm2Hvf7W7NxVzk@mit.edu>
In-Reply-To: <Y1Cm2Hvf7W7NxVzk@mit.edu>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 20 Oct 2022 08:15:22 -0500
Message-ID: <CAL_JsqLypcBCOVZ8yYWK0J_xc2Vcr+ANrX_3v4vN55Srp4RknQ@mail.gmail.com>
Subject: Re: [PATCH] of: fix repeated words in comments
To:     "Theodore Ts'o" <tytso@mit.edu>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Jilin Yuan <yuanjilin@cdjrlc.com>, frowand.list@gmail.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 19, 2022 at 8:39 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> >
> > On 10/19/22 06:02, Jilin Yuan wrote:
> > > Delete the redundant word 'of'.
> > >
> > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > > ---
> > >  drivers/of/device.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > index 8cefe5a7d04e..16c7e5a2a868 100644
> > > --- a/drivers/of/device.c
> > > +++ b/drivers/of/device.c
> > > @@ -19,7 +19,7 @@
> > >
> > >  /**
> > >   * of_match_device - Tell if a struct device matches an of_device_id list
> > > - * @matches: array of of device match structures to search in
> > > + * @matches: array of device match structures to search in
> >
> > Hi,
> > Rob has already explained this at least 2 times.
> >
> > The second "of" is "open firmware".
> > I would write it
> >               array of OF device match structures to search in
> > :)
>
> Actually, I'd probably do something like
>
>              array of Open Firmware (OF) device match structures...

Or just put the struct name in there: of_device_id

But at this point I prefer to just leave it alone for the
entertainment factor of how many times can I get this patch from
send-only email accts.

Rob