Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
Date:   Thu, 20 Oct 2022 15:16:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>
Cc:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221020113759.17402-1-jgross@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221020113759.17402-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ek0wTzY1dVIwSlRmOWtGdzN6eEt1RjI1Q0ZlMFZJd0xOSFl4M2YzUEVJUTA1?=
 =?utf-8?B?K2sxS3B1bE41d0kxQVQydFNvSDBudUFiSzgrRm0zbFFTc1ZuNUx1U2Jra2VZ?=
 =?utf-8?B?eFRIVHFOY3VZNzJXOU1EL1RSeVRETjVMQnJqSkZ4MitIMWNBOVhaL2ZaaDUz?=
 =?utf-8?B?clZVZm1jNlJqVmYrTVNZQTJ2OW9QTjRuUW9hUVBoQnBKaUo2T2piYTdmUFMw?=
 =?utf-8?B?SEkwNy9XdlEvYzFLTDBSaEVGaFlZdEZZMG1Qc1dNaThlUjNRZk9ZNHhDM002?=
 =?utf-8?B?RmtVb0VSWXV0cUNVYm1DRUJFajYySjIvTGo2TVE3c0ptTUNhdGQ2R1hVY05h?=
 =?utf-8?B?anY3YkJ3QndXZGZlQ3hJRE10TXd1cVU0bUdLQU1Tc1dRa0ZwTlBnT1hGaWZC?=
 =?utf-8?B?QzNlYitBekR4TTRGY2g5d0U1aDZmNjdsUWhwRlZzcjJTOUZsSzd0KzVlTUlH?=
 =?utf-8?B?WE4wUE1WRjh0UkVKSGlwOHN0bFo2aVBJSkdlaSt3U1lwWG5NWVJReTB6Rjd6?=
 =?utf-8?B?UUhDUXlUNktkeW9FNGlRS3puODVuemlFandsWkh2ckVPQ1A4eGZJTVBkVWlv?=
 =?utf-8?B?WDYxNHRnSFBQbGVhVnlRVmFFZUFGdWF6ODY1WEJXSmVsTGRmcFBRd3ZmNDYz?=
 =?utf-8?B?M3lzWG5RQXJqcGtlYVpxVmkxMGJPbXdtVHc3V3pXTTZuVzZLd0YwR2dmSEVq?=
 =?utf-8?B?a00yaGQwczVFd3ZOaldvZk00eE9sVnhlNVFQS2VEV3FKRzBpM1FaWnZNTk5C?=
 =?utf-8?B?NGdqMjZZaHJXSUNUb083TldvRVhuNkFoVTc2YzFNR2pkVFhVV1ByRVZMVGJX?=
 =?utf-8?B?Z3ZSSkpyUTFlVFpOTE95OVJMY2NTc2JqaU00TSt1WldJdUpGSXVRUWowckQ4?=
 =?utf-8?B?b2EwcldZckJWeGNYb3ZaYXRUZ2JHaGYvckNuRm5YdjRQUHI5QmFxeGFvWjAr?=
 =?utf-8?B?Zm5aU2E5RmQ1eUFoVjhqM1BFeDNJSThBQzN5YlpoaXZoSThYaWVQU1kveXZy?=
 =?utf-8?B?akZ0Smpxc0p6NXo4bXNTNEM2SWdkZ1dsZ0NkMVpEZ0RvSVNSempNMXpmejRo?=
 =?utf-8?B?ZFZGeTRPd2h6VFZDeW5PNm9MazRQVnVweTJiWWtxd0NhYkd5UTMxNktrVThK?=
 =?utf-8?B?NWhrakNGL1RRekJaY3V0M0Y4UERBMjZlVEI5U0k3d0xDdmNTODB3WkRva1p2?=
 =?utf-8?B?bFVjZ2pTSC8xaHJ2WndxQ0hjQ3d4Y1B3MHJSWHZ4UEptNmNiV29hdmFGUUJO?=
 =?utf-8?B?L3N0NUJNSXM0UjhsTFFZR1N4eG1aM1FVSzkxQjVNUFBMU3BUUklaZWl0STZx?=
 =?utf-8?B?d1JwWlh1aDFwV1F0T2tPT1U5aE1DYUFTc2hiWHlMTy84NDgzM2p5OUF1MDVN?=
 =?utf-8?B?NTczZXpxcmZ0V1FqdTY1VUJxd2Q5SUViQXlNYWE3WVc3d3VocGluS0YxNFlH?=
 =?utf-8?B?RmFldlI4bDVwVFdRK0ZrcUw3b0huNkg1Z0FhSmMwWmwzclhBd1VzcEZmRitp?=
 =?utf-8?B?TGd2RE9jRW9BUGgzaEJwVFJHbkxTc2liejhUSy9MeE1nL3ZTTjNRRnROMFFj?=
 =?utf-8?B?clVhZHhUbktQWURHNWplN05lRGVISEJzY0E0eXlOQURsRjZmSFN5TDRzRFl5?=
 =?utf-8?B?dGdmTElmL3VXUU82NVpoQmc3NFJBVmFOZ1lRa2g4S3p6Wjkvd0lZalRYVnd0?=
 =?utf-8?B?K3Y2YVB5SG9Fd0Y3OWF6SHNpRVRUMHl0QlViY3l0Q0ZqWlF4aHNpYUNxL3Rj?=
 =?utf-8?B?M0kyMmtTQUJRWXZiUE53Z09kNU9zcDFVSW16SCsydjMrOWRKb2s1c082TTlZ?=
 =?utf-8?B?K1RXNDdQTUJhT1N5dmx0YlhkNDY3em1naUg3WjQ0QndzVng5ZFNtZkJzSHl1?=
 =?utf-8?B?WjZldWtYUEQ2SUZSbDJSWGduOEc0Y0dtVUdIT3ZTcDJyOXNtKzZuWFIxTUV5?=
 =?utf-8?B?cWMzZlhQaUlzNjBuTDJDZkFzb0x1UUtHRE40UmNKSmt0Q3A3aFpHMTQ5RjlK?=
 =?utf-8?B?VGtCckdidDk0b0ZTNWVMcDhUUEJnNE8rYmwwajRIaGJ5bEdKQUVndWZjdlNL?=
 =?utf-8?B?Skd6TjFvTmVJbjRKbXp1alBES2h1U1A4TXltanhaNW9VdFd6dW9HUVU5bnlW?=
 =?utf-8?Q?t2GQgDgPqz+U2738SUOZd6eO9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cc33f2c-131e-4ec1-9e02-08dab29d3dbe
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 13:16:04.3264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i8kEBRFC3b8HKOsUE9aC/d/OJyqvoAfKljj6cuSRoZvrrVxIqOhHEpx/X4x/5cUz9yF7zDW7uLVCIS9erI8ItQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7217
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20.10.2022 13:37, Juergen Gross wrote:
> Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr
> accesses") introduced code resulting in a warning issued by the smatch
> static checker, claiming to use an uninitialized variable.
> 
> This is a false positive, but work around the warning nevertheless.

The risk of introducing a problem might be quite low here, but in general
it exists: With the adjustment you remove any chance of the compiler
spotting a missing initialization before use. And I'm not convinced using
0 in such a case would actually be ending up sufficiently benign.

Jan

> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -302,7 +302,7 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read)
>  static bool pmu_msr_chk_emulated(unsigned int msr, uint64_t *val, bool is_read,
>  				 bool *emul)
>  {
> -	int type, index;
> +	int type = 0, index = 0;
>  
>  	if (is_amd_pmu_msr(msr))
>  		*emul = xen_amd_pmu_emulate(msr, val, is_read);