Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
CC:     "kernel@axis.com" <kernel@axis.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mmc: core: Fix WRITE_ZEROES CQE handling
Thread-Topic: [PATCH] mmc: core: Fix WRITE_ZEROES CQE handling
Thread-Index: AQHY5IQdeSlWv4Wq9km8G48ujeqxG64XP2rw
Date:   Thu, 20 Oct 2022 13:03:20 +0000
Message-ID: <DM6PR04MB6575278202A8BA1B8B98BD91FC2A9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221020130123.4033218-1-vincent.whitchurch@axis.com>
In-Reply-To: <20221020130123.4033218-1-vincent.whitchurch@axis.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1BW+RwyxmVH31n9Cq/njwU13e+fQzJE3p5mX4FYLYy3Jk97mT0dFetu1/wrr?=
 =?us-ascii?Q?mAo+Tm8nLehP/wpd4vGTLGa1uVJkxVwPdPulQhAxo4M7zcm3aAhB9EKzucmx?=
 =?us-ascii?Q?t0t35wFrKh+VhJqJMhBiZ2SRDVjOM+0KWulJfX0ID9HCBfdiCulEVllg+He4?=
 =?us-ascii?Q?UL8V/gru8RC2x6188H9RxrsWFUk+duZtxndYMA/ZBJRvaeHfWAlotsBCd30Z?=
 =?us-ascii?Q?tK0OkgfA71P1CPLs2bhhVYOHgcd3RvAc5r31MTerCzmoLfINz8xHSKyPTLbj?=
 =?us-ascii?Q?aM/lmgOC20ro0J8Ye0D6g8h0zmz5jZ+YnU5kfne9UKJDbBRDd+yYMYjzwqTP?=
 =?us-ascii?Q?QYOeU5F83n+U67jqDtSE0xpkQiDgSk/WHS/h86DvgoC7nPRqV7qcwY7pt47h?=
 =?us-ascii?Q?YpqyFfrGOry/Cw0sRWgKne9sd6kFg4Jpzc+f14B9/BS0giyOOPJfQGgKsehy?=
 =?us-ascii?Q?DmwZ6WCnt+i5/Y94LmSFeTPRCXyX0Zhw29DMPA72kT3I2i+ZDuiLNQzfsQiN?=
 =?us-ascii?Q?hiT8WIZL3lrV7yjF2FVCbHyCNP9QVKEfJGsOUJSy8FWQdAHRIEn6Vuyo8TzB?=
 =?us-ascii?Q?/5diHtcEL0sV9mquBAvnVRJDl6QsnGIu79QnUf+5yVy8iqoJvjh8nNAHTYby?=
 =?us-ascii?Q?HweeacxtUrO18chs9Ky/+YdysYTZQzOoh8z2DeCpt3g0Ei7fRVJj4gksN/Ly?=
 =?us-ascii?Q?6pSxh0ppeqXm3iWVWp4qJZdXesndlHOZtOTtBqHqNJvyUqnuQxHbzECyz4Vv?=
 =?us-ascii?Q?0iMhcuiIIcD+u/VFy0k7ka+npeaNsn0KUvt0KcdOlI6CuI8FS3bsqDusuKJu?=
 =?us-ascii?Q?NVMaJoATAm2RJxVipz0AKiaWBZgshlZeIb2qYU2PdfA9pYVpDl8uXgYA2+0U?=
 =?us-ascii?Q?zLpEH9ebqjAguuiysj5Rr4sqjitur6iikVPCwFdFEMMA/NiJJcqo+cSSEQ20?=
 =?us-ascii?Q?DSAq0KEvVqASmgPX6Nmt5zzYJTRcR3eSYnPYNYqY60EUyjuOEtjBhPol1mNB?=
 =?us-ascii?Q?AMDcJnSId/DEdCNobO8472ynVnez5S2vPgSXEhGxus09H0x28DGcaZte/CU+?=
 =?us-ascii?Q?0hw1E2Cu9COuCiA/m0YK8uSQWmHCFjGHXjsjdlh+BHUld6ApNkNfwuu8OhE2?=
 =?us-ascii?Q?2Hv/tvKbOA06aF5R56ELXsMsIFeZ0GzoH8isaeKrOiV80UPSLyrE2zfknn0e?=
 =?us-ascii?Q?1MyJbIupxnNjoI1VHksPYIFy+RkfyosIehn5G8X/oqt9i1na7GHzvVgpujML?=
 =?us-ascii?Q?hvVDm3zavwM93TwB93StBeZF71XZr105CPhs+eATZlT0mNgAg6XzQoTDv8aC?=
 =?us-ascii?Q?ZG/nly96kozdPgHCqSXRgyxPpbhp6xOyJQVZ5DNn2zhSY7mH9Lkb1YzZnvD5?=
 =?us-ascii?Q?UHPZpSnF2eyk+Ve4e0PogXV4PshdZHT+cv8ahfxv5mr0u9QRCP/zgERWRCea?=
 =?us-ascii?Q?T1dpSRbpbd69sojnF5ODi3oQsel03fz/0YR9rcdg8K5jUrFbdM55c/n7cvgs?=
 =?us-ascii?Q?xlaMTLIujUnVkrzl9urvG6ay5QuPBwjYS2oDbJPnCFzLtulGFsyvEMDeGUgE?=
 =?us-ascii?Q?DCbKnMDXaXd3N+/kHI2ETU1A2W+maGC1HZ1Z67Ts?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee428a08-bf57-4747-9162-08dab29b7673
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 13:03:20.2838
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4u2fPkpEgN4vUgNsyUSzx480JmmE6ml95+OPkNNWW/eLJg74rjABFOx9vrJf0YBGWmf1c12ghWCZivuZxo7B+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR04MB4532
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> WRITE_ZEROES requests use TRIM, so mark them as needing to be issued
> synchronously even when a CQE is being used.  Without this,
> mmc_blk_mq_issue_rq() triggers a WARN_ON_ONCE() and fails the request
> since we don't have any handling for issuing this asynchronously.
>=20
> Fixes: f7b6fc327327 ("mmc: core: Support zeroout using TRIM for eMMC")
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/mmc/core/queue.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index
> fefaa901b50f..3661ba0bbc87 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -48,6 +48,7 @@ static enum mmc_issue_type
> mmc_cqe_issue_type(struct mmc_host *host,
>         case REQ_OP_DRV_OUT:
>         case REQ_OP_DISCARD:
>         case REQ_OP_SECURE_ERASE:
> +       case REQ_OP_WRITE_ZEROES:
>                 return MMC_ISSUE_SYNC;
>         case REQ_OP_FLUSH:
>                 return mmc_cqe_can_dcmd(host) ? MMC_ISSUE_DCMD :
> MMC_ISSUE_SYNC;
> --
> 2.28.0